12/21 modernizations from TG live (#103)

* sync (#3)

* shuttle auto call

* Merge /vore into /master (#39)

* progress

* Compile errors fixed

No idea if it's test worthy tho as conflicts with race overhaul and
narky removal.

* Update admins.txt

* efforts continue

Fuck grab code, seriously

* grab code is cancer

* Execute the Narkism

Do not hesitate.

Show no mercy.

* holy shit grab code is awful

* have I bitched about grab code

My bitching, let me show you it

* código de agarre es una mierda

No really it is

* yeah I don't even know anymore.

* Lolnope. Fuck grab code

* I'm not even sure what to fix anymore

* Self eating is not an acceptable fate

* Taste the void, son.

* My code doesn't pass it's own sanity check.

Maybe it's a sign of things to come.

* uncommented and notes

* It Works and I Don't Know Why (#38)

* shuttle auto call

* it works and I don't know why

* Subsystem 12/21

Most Recent TG subsystem folder

* globalvars 12/21

Tossed out the flavor_misc and parallax files

* Onclick 12/21

as well as .dme updates

* _defines 12/21

ommited old _MC.dm

* _HELPERS 12/21

Preserved snowflake placement of furry sprites

* _defeines/genetics

reapplied narkism holdover for snowflake races.

* Oops forgot mutant colors

* modules porting 12/21 + Sounds/icons

Admin, Client and most of mob life files ommitted

* enviroment file

* Admin optimizations

ahelp log system kept

* Mob ports 12/21

Flavor text preserved

* datums ported 12/21

* Game ported 12/21

* batch of duplicate fixes/dogborg work

Dogborgs need to be modernized to refractored borg standards.

* moar fixes

* Maps and futher compile fixes

code/modules/atmospherics/machinery/components/binary_devices/dp_vent_pump.dm

@@ -65,7 +65,7 @@ Acts like a normal vent, but has an input AND output.
 	..()
 
 	if(!on)
-		return 0
+		return FALSE
 	var/datum/gas_mixture/air1 = AIR1
 	var/datum/gas_mixture/air2 = AIR2
 
@@ -85,6 +85,9 @@ Acts like a normal vent, but has an input AND output.
 				var/transfer_moles = pressure_delta*environment.volume/(air1.temperature * R_IDEAL_GAS_EQUATION)
 
 				var/datum/gas_mixture/removed = air1.remove(transfer_moles)
+				//Removed can be null if there is no atmosphere in air1
+				if(!removed)
+					return FALSE
 
 				loc.assume_air(removed)
 				air_update_turf()
@@ -105,6 +108,9 @@ Acts like a normal vent, but has an input AND output.
 				var/transfer_moles = pressure_delta*air2.volume/(environment.temperature * R_IDEAL_GAS_EQUATION)
 
 				var/datum/gas_mixture/removed = loc.remove_air(transfer_moles)
+				//removed can be null if there is no air in the location
+				if(!removed)
+					return FALSE
 
 				air2.merge(removed)
 				air_update_turf()
@@ -112,7 +118,7 @@ Acts like a normal vent, but has an input AND output.
 				var/datum/pipeline/parent2 = PARENT2
 				parent2.update = 1
 
-	return 1
+	return TRUE
 
 	//Radio remote control
 
@@ -195,4 +201,4 @@ Acts like a normal vent, but has an input AND output.
 
 #undef EXT_BOUND
 #undef INPUT_MIN
-#undef OUTPUT_MAX
+#undef OUTPUT_MAX

code/modules/atmospherics/machinery/components/binary_devices/valve.dm

@@ -54,6 +54,10 @@ It's like a regular ol' straight pipe, but you can turn it on and off.
 		close()
 		return
 	open()
+	investigate_log("Valve, [src.name], was manipiulated by [key_name(usr)] at [x], [y], [z], [loc.loc]", "atmos")
+	message_admins("Valve, [src.name], was manipulated by [key_name(usr)] at [x], [y], [z], [loc.loc]")
+	log_admin("[key_name(usr)] manipulated a manual valve at [x], [y], [z]")
+
 
 /obj/machinery/atmospherics/components/binary/valve/digital		// can be controlled by AI
 	name = "digital valve"

code/modules/atmospherics/machinery/components/binary_devices/volume_pump.dm

@@ -119,7 +119,10 @@ Thus, the two variables affect pump operation are set in New():
 	switch(action)
 		if("power")
 			on = !on
-			investigate_log("was turned [on ? "on" : "off"] by [key_name(usr)]", "atmos")
+			investigate_log("Volume Pump, [src.name], was turned [on ? "on" : "off"] by [key_name(usr)] at [x], [y], [z], [loc.loc]", "atmos")
+			message_admins("Volume Pump, [src.name], turned [on ? "on" : "off"] by [key_name(usr)] at [x], [y], [z], [loc.loc]")
+			log_admin("[key_name(usr)] manipulated a volume pump at [x], [y], [z]")
+
 			. = TRUE
 		if("rate")
 			var/rate = params["rate"]
@@ -135,7 +138,9 @@ Thus, the two variables affect pump operation are set in New():
 				. = TRUE
 			if(.)
 				transfer_rate = Clamp(rate, 0, MAX_TRANSFER_RATE)
-				investigate_log("was set to [transfer_rate] L/s by [key_name(usr)]", "atmos")
+				investigate_log("Volume Pump, [src.name], was set to [transfer_rate] L/s by [key_name(usr)] at [x], [y], [z], [loc.loc]", "atmos")
+				message_admins("Volume Pump, [src.name], was set to [transfer_rate] L/s by [key_name(usr)] at [x], [y], [z], [loc.loc]")
+				log_admin("[key_name(usr)] manipulated a volume pump at [x], [y], [z]")
 	update_icon()
 
 /obj/machinery/atmospherics/components/binary/volume_pump/receive_signal(datum/signal/signal)
@@ -174,5 +179,9 @@ Thus, the two variables affect pump operation are set in New():
 		if(!(stat & NOPOWER) && on)
 			user << "<span class='warning'>You cannot unwrench this [src], turn it off first!</span>"
 		else
+			investigate_log("Volume Pump, [src.name], was unwrenched by [key_name(usr)] at [x], [y], [z], [loc.loc]", "atmos")
+			message_admins("Volume Pump, [src.name], was unwrenched by [key_name(usr)] at [x], [y], [z], [loc.loc]")
+			log_admin("[key_name(usr)] unwrenched a volume pump at [x], [y], [z]")
+
 			return 1