From e6b07f5e96640a32f7332917960620852aee391e Mon Sep 17 00:00:00 2001 From: kevinz000 Date: Thu, 3 Aug 2017 05:59:30 -0700 Subject: [PATCH] Revert "Fixes DoS vulnerability" (#2240) --- goon/code/datums/browserOutput.dm | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/goon/code/datums/browserOutput.dm b/goon/code/datums/browserOutput.dm index a6cabcba87..d928397728 100644 --- a/goon/code/datums/browserOutput.dm +++ b/goon/code/datums/browserOutput.dm @@ -2,9 +2,6 @@ For the main html chat area *********************************/ -#define BICON_X_MAX 96 -#define BICON_Y_MAX 96 - //Precaching a bunch of shit GLOBAL_DATUM_INIT(iconCache, /savefile, new("data/iconCache.sav")) //Cache of icons for the browser output @@ -191,10 +188,6 @@ GLOBAL_LIST_EMPTY(bicon_cache) /proc/icon2base64(icon/icon, iconKey = "misc") if (!isicon(icon)) return FALSE - //DOS exploit - if(icon.Width() > BICON_X_MAX || icon.Length() > BICON_Y_MAX) - return FALSE - // GLOB.iconCache[iconKey] << icon var/iconData = GLOB.iconCache.ExportText(iconKey) var/list/partial = splittext(iconData, "{") @@ -293,4 +286,4 @@ GLOBAL_LIST_EMPTY(bicon_cache) return M.current.client /datum/log //exists purely to capture to_chat() output - var/log = "" + var/log = "" \ No newline at end of file