From 5614da1d3bffac473ddf4902fa83100170195a37 Mon Sep 17 00:00:00 2001 From: Jordie Date: Tue, 3 Apr 2018 21:10:55 +1000 Subject: [PATCH 1/2] Merge pull request #36945 from KorPhaeron/aprilfools Removes april fools from heirlooms --- code/datums/traits/negative.dm | 38 ++++++++++++++-------------------- 1 file changed, 15 insertions(+), 23 deletions(-) diff --git a/code/datums/traits/negative.dm b/code/datums/traits/negative.dm index 2865877fce..8d161db9d5 100644 --- a/code/datums/traits/negative.dm +++ b/code/datums/traits/negative.dm @@ -21,29 +21,21 @@ /datum/trait/family_heirloom/on_spawn() var/mob/living/carbon/human/H = trait_holder var/obj/item/heirloom_type - if(SSevents.holidays && SSevents.holidays[APRIL_FOOLS]) //on april fools, pick from any item in the game - var/list/heirlooms = subtypesof(/obj/item) - for(var/V in heirlooms) - var/obj/item/I = V - if((!initial(I.icon_state)) || (!initial(I.item_state)) || (initial(I.flags_1) & ABSTRACT_1)) - heirlooms -= V - heirloom_type = pick(heirlooms) - else - switch(trait_holder.mind.assigned_role) - if("Clown") - heirloom_type = /obj/item/bikehorn/golden - if("Mime") - heirloom_type = /obj/item/reagent_containers/food/snacks/baguette - if("Lawyer") - heirloom_type = /obj/item/gavelhammer - if("Janitor") - heirloom_type = /obj/item/mop - if("Security Officer") - heirloom_type = /obj/item/book/manual/wiki/security_space_law - if("Scientist") - heirloom_type = /obj/item/toy/plush/slimeplushie - if("Assistant") - heirloom_type = /obj/item/storage/toolbox/mechanical/old/heirloom + switch(trait_holder.mind.assigned_role) + if("Clown") + heirloom_type = /obj/item/bikehorn/golden + if("Mime") + heirloom_type = /obj/item/reagent_containers/food/snacks/baguette + if("Lawyer") + heirloom_type = /obj/item/gavelhammer + if("Janitor") + heirloom_type = /obj/item/mop + if("Security Officer") + heirloom_type = /obj/item/book/manual/wiki/security_space_law + if("Scientist") + heirloom_type = /obj/item/toy/plush/slimeplushie + if("Assistant") + heirloom_type = /obj/item/storage/toolbox/mechanical/old/heirloom if(!heirloom_type) heirloom_type = pick( /obj/item/toy/cards/deck,