fixing a bunch of unit test/runtime issues

code/controllers/subsystem/activity.dm

@@ -11,6 +11,7 @@ SUBSYSTEM_DEF(activity)
 /datum/controller/subsystem/activity/Initialize(timeofday)
 	RegisterSignal(SSdcs,COMSIG_GLOB_EXPLOSION,.proc/on_explosion)
 	RegisterSignal(SSdcs,COMSIG_GLOB_MOB_DEATH,.proc/on_death)
+	return ..()
 
 /datum/controller/subsystem/activity/fire(resumed = 0)
 	calculate_threat()
@@ -54,7 +55,10 @@ SUBSYSTEM_DEF(activity)
 		var/weight = (text2num(threat_history[i+1])-text2num(threat_history[i]))
 		total_weight += weight
 		total_amt += weight * (threat_history[threat_history[i]])
-	return round(total_amt / total_weight,0.1)
+	if(total_weight == 0)
+		return total_amt
+	else
+		return round(total_amt / total_weight,0.1)
 
 /datum/controller/subsystem/activity/proc/get_max_threat()
 	. = 0

code/controllers/subsystem/research.dm

@@ -409,8 +409,7 @@ SUBSYSTEM_DEF(research)
 		var/datum/techweb_node/TN = techweb_nodes[id]
 		TN.Initialize()
 	techweb_nodes = returned
-	if (!verify_techweb_nodes())	//Verify all nodes have ids and such.
-		stack_trace("Invalid techweb nodes detected")
+	verify_techweb_nodes()
 	calculate_techweb_nodes()
 	calculate_techweb_boost_list()
 	if (!verify_techweb_nodes())		//Verify nodes and designs have been crosslinked properly.
@@ -442,52 +441,52 @@ SUBSYSTEM_DEF(research)
 	for(var/n in techweb_nodes)
 		var/datum/techweb_node/N = techweb_nodes[n]
 		if(!istype(N))
-			WARNING("Invalid research node with ID [n] detected and removed.")
+			stack_trace("Invalid research node with ID [n] detected and removed.")
 			techweb_nodes -= n
 			research_node_id_error(n)
 			. = FALSE
 		for(var/p in N.prereq_ids)
 			var/datum/techweb_node/P = techweb_nodes[p]
 			if(!istype(P))
-				WARNING("Invalid research prerequisite node with ID [p] detected in node [N.display_name]\[[N.id]\] removed.")
+				stack_trace("Invalid research prerequisite node with ID [p] detected in node [N.display_name]\[[N.id]\] removed.")
 				N.prereq_ids  -= p
 				research_node_id_error(p)
 				. = FALSE
 		for(var/d in N.design_ids)
 			var/datum/design/D = techweb_designs[d]
 			if(!istype(D))
-				WARNING("Invalid research design with ID [d] detected in node [N.display_name]\[[N.id]\] removed.")
+				stack_trace("Invalid research design with ID [d] detected in node [N.display_name]\[[N.id]\] removed.")
 				N.design_ids -= d
 				design_id_error(d)
 				. = FALSE
 		for(var/u in N.unlock_ids)
 			var/datum/techweb_node/U = techweb_nodes[u]
 			if(!istype(U))
-				WARNING("Invalid research unlock node with ID [u] detected in node [N.display_name]\[[N.id]\] removed.")
+				stack_trace("Invalid research unlock node with ID [u] detected in node [N.display_name]\[[N.id]\] removed.")
 				N.unlock_ids -= u
 				research_node_id_error(u)
 				. = FALSE
 		for(var/p in N.boost_item_paths)
 			if(!ispath(p))
 				N.boost_item_paths -= p
-				WARNING("[p] is not a valid path.")
+				stack_trace("[p] is not a valid path.")
 				node_boost_error(N.id, "[p] is not a valid path.")
 				. = FALSE
 			var/list/points = N.boost_item_paths[p]
 			if(islist(points))
 				for(var/i in points)
 					if(!isnum(points[i]))
-						WARNING("[points[i]] is not a valid number.")
+						stack_trace("[points[i]] is not a valid number.")
 						node_boost_error(N.id, "[points[i]] is not a valid number.")
 						. = FALSE
 					else if(!point_types[i])
-						WARNING("[i] is not a valid point type.")
+						stack_trace("[i] is not a valid point type.")
 						node_boost_error(N.id, "[i] is not a valid point type.")
 						. = FALSE
 			else if(!isnull(points))
 				N.boost_item_paths -= p
 				node_boost_error(N.id, "No valid list.")
-				WARNING("No valid list.")
+				stack_trace("No valid list.")
 				. = FALSE
 		CHECK_TICK
 

code/controllers/subsystem/title.dm

@@ -10,7 +10,7 @@ SUBSYSTEM_DEF(title)
 
 /datum/controller/subsystem/title/Initialize()
 	if(file_path && icon)
-		return
+		return ..()
 
 	if(fexists("data/previous_title.dat"))
 		var/previous_path = file2text("data/previous_title.dat")
@@ -31,15 +31,13 @@ SUBSYSTEM_DEF(title)
 	if(length(title_screens))
 		file_path = "[global.config.directory]/title_screens/images/[pick(title_screens)]"
 
-	if(!file_path)
+	if(!file_path || !fexists(file_path))
 		file_path = "icons/default_title.dmi"
 
-	ASSERT(fexists(file_path))
-
-	icon = new(fcopy_rsc(file_path))
-
-	if(splash_turf)
-		splash_turf.icon = icon
+	if(fexists(file_path))
+		icon = new(fcopy_rsc(file_path))
+		if(splash_turf)
+			splash_turf.icon = icon
 
 	return ..()