shikix/GS13NG
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

code quality

Browse Source
This commit is contained in:
Letter N
2020-12-29 11:12:56 +08:00
parent 51143f89e5
commit f28363ae56
65 changed files with 950 additions and 347 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/unit_tests/heretic_knowledge.dm
+21
View File
@@ -0,0 +1,21 @@
/// This test checks all heretic knowledge nodes - excluding the ones which are unreachable on purpose - and ensures players can reach them in game.
/// If it finds a node that is unreachable, it throws an error.
/datum/unit_test/heretic_knowledge/Run()
///List of all knowledge excluding the unreachable base types.
var/list/blacklist = list(/datum/eldritch_knowledge/spell,/datum/eldritch_knowledge/curse,/datum/eldritch_knowledge/final,/datum/eldritch_knowledge/summon)
var/list/all_possible_knowledge = subtypesof(/datum/eldritch_knowledge) - blacklist
var/list/list_to_check = GLOB.heretic_start_knowledge.Copy()
var/i = 0
while(i < length(list_to_check))
var/datum/eldritch_knowledge/eldritch_knowledge = allocate(list_to_check[++i])
for(var/next_knowledge in eldritch_knowledge.next_knowledge)
if(next_knowledge in list_to_check)
continue
list_to_check += next_knowledge
if(length(all_possible_knowledge) != length(all_possible_knowledge & list_to_check))
var/list/unreachables = all_possible_knowledge - list_to_check
for(var/X in unreachables)
var/datum/eldritch_knowledge/eldritch_knowledge = X
Fail("[initial(eldritch_knowledge.name)] is unreachable by players! Add it to the blacklist in /code/modules/unit_tests/heretic_knowledge.dm if it is purposeful!")