Bleeding edgy refresh (#303)

* not code stuff

* other things

* global vars, defines, helpers

* onclick hud stuff, orphans, world.dm

* controllers and datums

* game folder

* everything not client/mobs in modules

* client folder

* stage 1 mob stuff

* simple animal things

* silicons

* carbon things

* ayylmaos and monkeys

* hyoomahn

* icons n shit

* sprite fixes

* compile fixes

* some fixes I cherrypicked.

* qdel fixes

* forgot brain refractors

code/modules/clothing/head/hardhat.dm

@@ -27,23 +27,11 @@
 		var/datum/action/A = X
 		A.UpdateButtonIcon()
 
-/obj/item/clothing/head/hardhat/pickup(mob/user)
-	..()
-	if(on)
-		user.AddLuminosity(brightness_on)
-		SetLuminosity(0)
-
-/obj/item/clothing/head/hardhat/dropped(mob/user)
-	..()
-	if(on)
-		user.AddLuminosity(-brightness_on)
-		SetLuminosity(brightness_on)
-
 /obj/item/clothing/head/hardhat/proc/turn_on(mob/user)
-	user.AddLuminosity(brightness_on)
+	set_light(brightness_on)
 
 /obj/item/clothing/head/hardhat/proc/turn_off(mob/user)
-	user.AddLuminosity(-brightness_on)
+	set_light(0)
 
 /obj/item/clothing/head/hardhat/orange
 	icon_state = "hardhat0_orange"

code/modules/clothing/head/helmet.dm

@@ -2,7 +2,6 @@
 	name = "helmet"
 	desc = "Standard Security gear. Protects the head from impacts."
 	icon_state = "helmet"
-	flags = HEADBANGPROTECT
 	item_state = "helmet"
 	armor = list(melee = 35, bullet = 30, laser = 30,energy = 10, bomb = 25, bio = 0, rad = 0, fire = 50, acid = 50)
 	flags_inv = HIDEEARS
@@ -17,8 +16,9 @@
 	dog_fashion = /datum/dog_fashion/head/helmet
 
 
-/obj/item/clothing/head/helmet/New()
+/obj/item/clothing/head/helmet/Initialize()
 	..()
+	SET_SECONDARY_FLAG(src, BANG_PROTECT)
 
 /obj/item/clothing/head/helmet/sec
 	can_flashlight = 1
@@ -28,7 +28,7 @@
 	desc = "A bulletproof combat helmet that excels in protecting the wearer against traditional projectile weaponry and explosives to a minor extent."
 	icon_state = "helmetalt"
 	item_state = "helmetalt"
-	armor = list(melee = 15, bullet = 40, laser = 10, energy = 10, bomb = 40, bio = 0, rad = 0, fire = 50, acid = 50)
+	armor = list(melee = 15, bullet = 60, laser = 10, energy = 10, bomb = 40, bio = 0, rad = 0, fire = 50, acid = 50)
 	can_flashlight = 1
 	dog_fashion = null
 
@@ -44,7 +44,6 @@
 	toggle_message = "You pull the visor down on"
 	alt_toggle_message = "You push the visor up on"
 	can_toggle = 1
-	flags = HEADBANGPROTECT
 	armor = list(melee = 45, bullet = 15, laser = 5,energy = 5, bomb = 5, bio = 2, rad = 0, fire = 50, acid = 50)
 	flags_inv = HIDEEARS|HIDEFACE
 	strip_delay = 80
@@ -64,7 +63,7 @@
 			flags_inv ^= visor_flags_inv
 			flags_cover ^= visor_flags_cover
 			icon_state = "[initial(icon_state)][up ? "up" : ""]"
-			user << "[up ? alt_toggle_message : toggle_message] \the [src]"
+			to_chat(user, "[up ? alt_toggle_message : toggle_message] \the [src]")
 
 			user.update_inv_head()
 			if(iscarbon(user))
@@ -182,12 +181,16 @@
 	icon_state = "knight_green"
 	item_state = "knight_green"
 	armor = list(melee = 41, bullet = 15, laser = 5,energy = 5, bomb = 5, bio = 2, rad = 0, fire = 0, acid = 50)
-	flags = null
 	flags_inv = HIDEMASK|HIDEEARS|HIDEEYES|HIDEFACE|HIDEHAIR
 	flags_cover = HEADCOVERSEYES | HEADCOVERSMOUTH
 	strip_delay = 80
 	dog_fashion = null
 
+/obj/item/clothing/head/helmet/knight/Initialize(mapload)
+	..()
+	// old knight helmets do not offer protection against loud noises
+	CLEAR_SECONDARY_FLAG(src, BANG_PROTECT)
+
 /obj/item/clothing/head/helmet/knight/blue
 	icon_state = "knight_blue"
 	item_state = "knight_blue"
@@ -219,7 +222,6 @@
 //LightToggle
 
 /obj/item/clothing/head/helmet/update_icon()
-
 	var/state = "[initial(icon_state)]"
 	if(F)
 		if(F.on)
@@ -233,8 +235,6 @@
 		var/mob/living/carbon/human/H = loc
 		H.update_inv_head()
 
-	return
-
 /obj/item/clothing/head/helmet/ui_action_click(mob/user, action)
 	if(istype(action, /datum/action/item_action/toggle_helmet_flashlight))
 		toggle_helmlight()
@@ -248,9 +248,9 @@
 			if(!F)
 				if(!user.transferItemToLoc(S, src))
 					return
-				user << "<span class='notice'>You click [S] into place on [src].</span>"
+				to_chat(user, "<span class='notice'>You click [S] into place on [src].</span>")
 				if(S.on)
-					SetLuminosity(0)
+					set_light(0)
 				F = S
 				update_icon()
 				update_helmlight(user)
@@ -263,7 +263,7 @@
 	if(istype(I, /obj/item/weapon/screwdriver))
 		if(F)
 			for(var/obj/item/device/flashlight/seclite/S in src)
-				user << "<span class='notice'>You unscrew the seclite from [src].</span>"
+				to_chat(user, "<span class='notice'>You unscrew the seclite from [src].</span>")
 				F = null
 				S.loc = get_turf(user)
 				update_helmlight(user)
@@ -289,46 +289,21 @@
 	if(user.incapacitated())
 		return
 	F.on = !F.on
-	user << "<span class='notice'>You toggle the helmetlight [F.on ? "on":"off"].</span>"
+	to_chat(user, "<span class='notice'>You toggle the helmetlight [F.on ? "on":"off"].</span>")
 
 	playsound(user, 'sound/weapons/empty.ogg', 100, 1)
 	update_helmlight(user)
-	return
 
 /obj/item/clothing/head/helmet/proc/update_helmlight(mob/user = null)
 	if(F)
 		if(F.on)
-			if(loc == user)
-				user.AddLuminosity(F.brightness_on)
-			else if(isturf(loc))
-				SetLuminosity(F.brightness_on)
+			set_light(F.brightness_on)
 		else
-			if(loc == user)
-				user.AddLuminosity(-F.brightness_on)
-			else if(isturf(loc))
-				SetLuminosity(0)
+			set_light(0)
 		update_icon()
 
 	else
-		if(loc == user)
-			user.AddLuminosity(-5)
-		else if(isturf(loc))
-			SetLuminosity(0)
+		set_light(0)
 	for(var/X in actions)
 		var/datum/action/A = X
 		A.UpdateButtonIcon()
-
-/obj/item/clothing/head/helmet/pickup(mob/user)
-	..()
-	if(F)
-		if(F.on)
-			user.AddLuminosity(F.brightness_on)
-			SetLuminosity(0)
-
-
-/obj/item/clothing/head/helmet/dropped(mob/user)
-	..()
-	if(F)
-		if(F.on)
-			user.AddLuminosity(-F.brightness_on)
-			SetLuminosity(F.brightness_on)

code/modules/clothing/head/jobs.dm

@@ -88,10 +88,10 @@
 		if(candy_cooldown < world.time)
 			var/obj/item/weapon/reagent_containers/food/snacks/candy_corn/CC = new /obj/item/weapon/reagent_containers/food/snacks/candy_corn(src)
 			M.put_in_hands(CC)
-			M << "You slip a candy corn from your hat."
+			to_chat(M, "You slip a candy corn from your hat.")
 			candy_cooldown = world.time+1200
 		else
-			M << "You just took a candy corn! You should wait a couple minutes, lest you burn through your stash."
+			to_chat(M, "You just took a candy corn! You should wait a couple minutes, lest you burn through your stash.")
 
 
 //Mime

code/modules/clothing/head/misc_special.dm

@@ -96,12 +96,12 @@
 		src.icon_state = "ushankaup"
 		src.item_state = "ushankaup"
 		earflaps = 0
-		user << "<span class='notice'>You raise the ear flaps on the ushanka.</span>"
+		to_chat(user, "<span class='notice'>You raise the ear flaps on the ushanka.</span>")
 	else
 		src.icon_state = "ushankadown"
 		src.item_state = "ushankadown"
 		earflaps = 1
-		user << "<span class='notice'>You lower the ear flaps on the ushanka.</span>"
+		to_chat(user, "<span class='notice'>You lower the ear flaps on the ushanka.</span>")
 
 /*
  * Pumpkin head

code/modules/clothing/head/soft_caps.dm

@@ -24,7 +24,7 @@
 /obj/item/clothing/head/soft/AltClick(mob/user)
 	..()
 	if(!user.canUseTopic(src, be_close=TRUE))
-		user << "<span class='warning'>You can't do that right now!</span>"
+		to_chat(user, "<span class='warning'>You can't do that right now!</span>")
 		return
 	else
 		flip(user)
@@ -35,15 +35,15 @@
 		src.flipped = !src.flipped
 		if(src.flipped)
 			icon_state = "[item_color]soft_flipped"
-			user << "<span class='notice'>You flip the hat backwards.</span>"
+			to_chat(user, "<span class='notice'>You flip the hat backwards.</span>")
 		else
 			icon_state = "[item_color]soft"
-			user << "<span class='notice'>You flip the hat back in normal position.</span>"
+			to_chat(user, "<span class='notice'>You flip the hat back in normal position.</span>")
 		usr.update_inv_head()	//so our mob-overlays update
 
 /obj/item/clothing/head/soft/examine(mob/user)
 	..()
-	user << "<span class='notice'>Alt-click the cap to flip it [flipped ? "forwards" : "backwards"].</span>"
+	to_chat(user, "<span class='notice'>Alt-click the cap to flip it [flipped ? "forwards" : "backwards"].</span>")
 
 /obj/item/clothing/head/soft/red
 	name = "red cap"

code/modules/clothing/head/vg_hats.dm

@@ -4,6 +4,7 @@
 	desc = "Judge, Jury, and Executioner."
 	icon_state = "dredd-helmet"
 	item_state = "dredd-helmet"
+	icon = 'icons/obj/clothing/vg_clothes.dmi'
 	armor = list(melee = 40, bullet = 30, laser = 30,energy = 30, bomb = 50, bio = 90, rad = 20, fire = 50, acid = 50)
 	cold_protection = HEAD
 	min_cold_protection_temperature = SPACE_HELM_MIN_TEMP_PROTECT
@@ -19,12 +20,14 @@
 	armor = list(melee = 25, bullet = 0, laser = 20, energy = 10, bomb = 10, bio = 0, rad = 0)
 	item_state = "aviator_helmet"
 	icon_state = "aviator_helmet"
+	icon = 'icons/obj/clothing/vg_clothes.dmi'
 
 /obj/item/clothing/head/helmet/biker
 	name = "Biker's Helmet"
 	desc = "This helmet should protect you from russians and masked vigilantes."
 	armor = list(melee = 25, bullet = 15, laser = 20, energy = 10, bomb = 10, bio = 0, rad = 0)
 	icon_state = "biker_helmet"
+	icon = 'icons/obj/clothing/vg_clothes.dmi'
 	flags_inv = HIDEMASK|HIDEEARS|HIDEEYES|HIDEFACE|HIDEHAIR
 
 /obj/item/clothing/head/helmet/richard
@@ -32,6 +35,7 @@
 	desc = "Do you like hurting people?"
 	armor = list(melee = 0, bullet = 0, laser = 0, energy = 0, bomb = 0, bio = 0, rad = 0)
 	icon_state = "richard"
+	icon = 'icons/obj/clothing/vg_clothes.dmi'
 	flags_inv = HIDEMASK|HIDEEARS|HIDEEYES|HIDEFACE|HIDEHAIR
 
 /obj/item/clothing/head/helmet/megahelmet
@@ -39,6 +43,7 @@
 	desc = "The helmet of the DRN-001 model. A simple, sturdy blue helmet."
 	icon_state = "megahelmet"
 	item_state = "megahelmet"
+	icon = 'icons/obj/clothing/vg_clothes.dmi'
 	siemens_coefficient = 1
 
 /obj/item/clothing/head/helmet/protohelmet
@@ -46,6 +51,7 @@
 	desc = "Shiny red helmet with white accents and a built in shaded visor that does absolutely nothing, nothing but look rad as hell."
 	icon_state = "protohelmet"
 	item_state = "protohelmet"
+	icon = 'icons/obj/clothing/vg_clothes.dmi'
 	siemens_coefficient = 1
 
 /obj/item/clothing/head/helmet/megaxhelmet
@@ -53,6 +59,7 @@
 	desc = "Heavily armored upgrade to the DRN-001 model's helmet, now comes with a pointless red crystal thing!"
 	icon_state = "megaxhelmet"
 	item_state = "megaxhelmet"
+	icon = 'icons/obj/clothing/vg_clothes.dmi'
 	siemens_coefficient = 1
 
 /obj/item/clothing/head/helmet/joehelmet
@@ -61,6 +68,7 @@
 	icon_state = "joehelmet"
 	flags_inv = HIDEMASK|HIDEEARS|HIDEEYES|HIDEFACE|HIDEHAIR
 	item_state = "joehelmet"
+	icon = 'icons/obj/clothing/vg_clothes.dmi'
 	siemens_coefficient = 1
 
 /obj/item/clothing/head/helmet/doomguy
@@ -69,6 +77,7 @@
 	icon_state = "doom"
 	flags_inv = HIDEMASK|HIDEEARS|HIDEEYES|HIDEFACE|HIDEHAIR
 	item_state = "doom"
+	icon = 'icons/obj/clothing/vg_clothes.dmi'
 	armor = list(melee = 50, bullet = 40, laser = 40,energy = 40, bomb = 5, bio = 0, rad = 0)
 	siemens_coefficient = 1
 
@@ -77,6 +86,7 @@
 	desc = "This piece of equipment can double as a pillow, a bowl, an emergency toilet, and sometimes as a helmet."
 	icon_state = "nr_helmet"
 	item_state = "nr_helmet"
+	icon = 'icons/obj/clothing/vg_clothes.dmi'
 
 
 /obj/item/clothing/head/stalhelm
@@ -84,18 +94,21 @@
 	desc = "Ein Helm, um die Nazi-Interesse an fremden Raumstationen zu sichern."
 	icon_state = "stalhelm"
 	item_state = "stalhelm"
+	icon = 'icons/obj/clothing/vg_clothes.dmi'
 
 /obj/item/clothing/head/panzer
 	name = "Panzer Cap"
 	desc = "Ein Hut passen nur für die größten Tanks."
 	icon_state = "panzercap"
 	item_state = "panzercap"
+	icon = 'icons/obj/clothing/vg_clothes.dmi'
 
 /obj/item/clothing/head/naziofficer
 	name = "Officer Cap"
 	desc = "Ein Hut von Offizieren in der Nazi-Partei getragen."
 	icon_state = "officercap"
 	item_state = "officercap"
+	icon = 'icons/obj/clothing/vg_clothes.dmi'
 
 
 /obj/item/clothing/head/russobluecamohat
@@ -103,17 +116,20 @@
 	desc = "A symbol of discipline, honor, and lots and lots of removal of some type of skewered food."
 	icon_state = "russobluecamohat"
 	item_state = "russobluecamohat"
+	icon = 'icons/obj/clothing/vg_clothes.dmi'
 
 /obj/item/clothing/head/russofurhat
 	name = "russian fur hat"
 	desc = "Russian winter got you down? Maybe your enemy, but not you!"
 	icon_state = "russofurhat"
 	item_state = "russofurhat"
+	icon = 'icons/obj/clothing/vg_clothes.dmi'
 
 /obj/item/clothing/head/squatter_hat
 	name = "slav squatter hat"
 	icon_state = "squatter_hat"
 	item_state = "squatter_hat"
+	icon = 'icons/obj/clothing/vg_clothes.dmi'
 	desc = "Cyka blyat."
 
 /obj/item/clothing/head/snake
@@ -121,6 +137,7 @@
 	desc = "Reenact acts of violence against reptiles, or sneak into a swamp unnoticed."
 	icon_state = "snakehead"
 	item_state = "snakehead"
+	icon = 'icons/obj/clothing/vg_clothes.dmi'
 
 /obj/item/clothing/head/mummy_rags
 	name = "mummy rags"
@@ -128,6 +145,7 @@
 	icon_state = "mummy"
 	item_state = "mummy"
 	item_color = "mummy"
+	icon = 'icons/obj/clothing/vg_clothes.dmi'
 	flags_inv = HIDEHAIR|HIDEFACE|HIDEEARS
 
 /obj/item/clothing/head/clownpiece
@@ -135,18 +153,21 @@
 	desc = "A purple polka-dotted jester's hat with yellow pompons."
 	icon_state = "clownpiece"
 	item_state = "clownpiece"
+	icon = 'icons/obj/clothing/vg_clothes.dmi'
 
 /obj/item/clothing/head/mitre
 	name = "mitre"
 	desc = "A funny hat worn by extremely boring people."
 	icon_state = "mitre"
 	item_state = "mitre"
+	icon = 'icons/obj/clothing/vg_clothes.dmi'
 
 /obj/item/clothing/head/tinfoil
 	name = "tinfoil hat"
 	desc = "There's no evidence that the security staff is NOT out to get you."
 	icon_state = "foilhat"
 	item_state = "paper"
+	icon = 'icons/obj/clothing/vg_clothes.dmi'
 	siemens_coefficient = 2
 
 /obj/item/clothing/head/celtic
@@ -154,3 +175,4 @@
 	desc = "According to legend, Celtic kings would use crowns like this one to shield their subjects from harsh winters back on Earth."
 	icon_state = "celtic_crown"
 	item_state = "celtic_crown"
+	icon = 'icons/obj/clothing/vg_clothes.dmi'