* [s] Fixes exploit where botany trays can be refilled at no cost.
* Merge pull request #38422 from DaxDupont/hydroponics
[s] Fixes exploit where botany trays can be refilled at no cost.
* A few additions, tweaks, and fixes for integrated circuits, and some very minor tweaks to hydroponics and carbon/silicon examine() to support those changes.
🆑 SailorDave
rscadd: A new manipulation circuit, the Seed Extractor. Extracts seeds from produce, and outputs a list of the extracted seeds.
rscadd: A new list circuit, the List Filter. Searches through a list for anything matching the desired element and outputs two lists: one containing just the matches, and the other with matches filtered out.
rscadd: A new list circuit, the Set circuit. Removes duplicate entries from a list.
tweak: The Plant Manipulation circuit can now plant seeds, and outputs a list of harvested plants.
tweak: Reagent circuits can now irrigate connected hydroponic trays and inject blood samples into Replica pods.
tweak: The Examiner circuit outputs worn items and other examined details of carbon and silicon mobs into the description pin.
tweak: List Advanced Locator circuit now accepts refs as well as strings.
bugfix: Fixed the Power Transmitter circuit not properly displaying a message when activated.
bugfix: Medical Analyzer circuit can now properly scan non-human mobs.
/🆑
Additional details:
- Plant Manipulation: obj/item/seeds harvest() proc and obj/machinery/hydroponics attack_hand() procs were adjusted slightly to allow this, returning a list when harvested.
- Seed Extractor Module: obj/machinery/seed_extractor /proc/seedify() was adjusted to return a list of seeds.
- Hydroponics replica pod was adjusted to be injectable|drawable, and use reagents and on_reagent_change() rather than a hardcoded attackby(), so other injection methods can use it to allow blood sampling/future reagent reactions regardless of type.
- IC Examiner Module returns a list of examine() messages from mob/living/carbon, mob/living/carbon/human, mob/living/carbon/silicon, and mob/living/carbon/silicon/ai in the description data pin, rather than outputting null since they had an empty desc var. The relevant examine procs were adjusted to return their messages.
- IC get_data() and set_pin_data() adjusted to return text/num properly and to WEAKREF/un-WEAKREF the contents of passed lists.
* fixes errors from screwy merge conflicts and replaces illegal proc name
* re-added a traits tag that accidentally got removed
* review changes
* plant analyzer outputs irrigation status and connected trays, search circuit uses 2 Cx down from 6
* examiner outputs the occupied turf of the examined object and can also scan turfs
* string inputs on circuit pins now use multiline input; fixed edit/remove not working on list pins; fixed large screens not outputting visible messages when held
* locomotion now has a cooldown of 0.1sec and their complexity + pathfinder complexity reduced
* assemblies can open doors they have access to from a card reader through collision
* Merge master branch; fixes pathfinder AStar runtime; fixes tile pointer; fixes material manager self-ref; various grammar touchups
* review changes
* fixes improper weakref type checking
* fixes seed extractor merge confict, removes unnecessary weakref change
* dang ol merge undoing my changes HECK
* updated to robbym's tile pointer PR with clearer var names
* added missing "not scanned" results to tile analyzer, removes duplicate circuit entries(???? how)
* buncha things from upstream
* datums globals, onclick
* datums
* game folder, holy shit mirror bot why
* modules
* icons
* dme
* compiles cleanly
* tools purge
* updates maps
* double check just because. and wew lad
* incidentally, this needs more work first
* some things
* weh
* sound cleanup and icons
* reeeee
* compile issues
* oh look, fresh code sync
* cleans up some unused icons
* dirty vars
* reeeeeeeeeeeeeeee
* wew lad. fuck off with this already
* maps, tgui, tools
* defines and helpers
* onclick and controllers
* datums
fucking caught that hulk reversal too.
* game and shuttle modular
* module/admin
* oh god they fucking moved antag shit again
* haaaaate. Haaaaaaaaaate.
* enables moff wings
* more modules things
* tgstation.dme
before I forget something important
* some mob stuff
* s'more mob/living stuff
* some carbon stuff
* ayy lmaos and kitchen meat
* Human stuff
* species things
moff wings have a 'none' version too
* the rest of the module stuff.
* some strings
* misc
* mob icons
* some other icons.
* It compiles FUCK BORERS
FUCK BORERS
Plurality, capitalization, punctuation, and item icons have been
improved. Status displays now show the same text on examination that
they do visually. Inducers only show a success message when they
actually succeed.
* map tweaks/shuttle engines
* helpers and defines
* global/onclick
* controllers and datums
* mapping
* game folder
* some other stuff
* some modules
* modules that aren't mobs
* some mob stuff
* new player stuff
* mob living
* silicon stuff
* simple animal things
* carbon/ayylmao
* update_icons
* carbon/human
* sounds and tools
* icons and stuff
* hippie grinder changes + tgui
* kitchen.dmi
* compile issues fixed
* mapfix
* Mapfixes 2.0
* mapedit2.0
* mapmerger pls
* Revert "mapedit2.0"
This reverts commit 74139a3cacea10df7aafca06c0a10bd3daf3a481.
* clean up vore folder + 2 hotfixes
* admin ticket refinement
* Blob tweaks and LAZYADD
* LAZYADD IS LAZY
* Magic strings purged
* DEFINES NEED HIGHER PRIORITIES
* Only a sleepless idiot deals in absolute TRUE|FALSE
* u h g
* progress bar fix
* reverts ticket logs
* there's always that one guy
* fixes and stuff
* 2/27 fixes
* game folder stuff
* stats
* some modules again
* clothing stuff
gets vg clothing out of the main files
* everything not mobs again
* mob stuff
* maps, tgui, sql stuff
* icons
* additional fixes and compile errors
* don't need this anymore
* Oh right this isn't needed anymore
* maint bar re-added
* that doesn't need to be here
* stupid events
* wtfeven
* probably makes Travis happy
* don't care to fix the grinder atm
* fixes vending sprites, changes turret
* lethal, not lethals
* overylays are finicky creatures
* lazy fix for bleeding edgy (#252)
* map tweaks/shuttle engines
* helpers and defines
* global/onclick
* controllers and datums
* mapping
* game folder
* some other stuff
* some modules
* modules that aren't mobs
* some mob stuff
* new player stuff
* mob living
* silicon stuff
* simple animal things
* carbon/ayylmao
* update_icons
* carbon/human
* sounds and tools
* icons and stuff
* hippie grinder changes + tgui
* kitchen.dmi
* compile issues fixed
* mapfix
* Mapfixes 2.0
* mapedit2.0
* mapmerger pls
* Revert "mapedit2.0"
This reverts commit 74139a3cacea10df7aafca06c0a10bd3daf3a481.
* clean up vore folder + 2 hotfixes
* admin ticket refinement
* Blob tweaks and LAZYADD
* LAZYADD IS LAZY
* Magic strings purged
* DEFINES NEED HIGHER PRIORITIES
* Only a sleepless idiot deals in absolute TRUE|FALSE
* u h g
* progress bar fix
* reverts ticket logs
* there's always that one guy
* fixes and stuff
* 2/27 fixes
* game folder stuff
* stats
* some modules again
* clothing stuff
gets vg clothing out of the main files
* everything not mobs again
* mob stuff
* maps, tgui, sql stuff
* icons
* additional fixes and compile errors
* don't need this anymore
* Oh right this isn't needed anymore
* maint bar re-added
* that doesn't need to be here
* stupid events
* wtfeven
* probably makes Travis happy
* don't care to fix the grinder atm
* fixes vending sprites, changes turret
* lethal, not lethals
* overylays are finicky creatures
