chaosrebel/pico-openpgp
1
0
Fork 0
mirror of https://github.com/polhenarejos/pico-openpgp.git synced 2026-08-27 07:05:07 +01:00
Code Issues Packages Projects Releases Wiki Activity

Authenticate before IMPORT slot parsing

Browse Source 
Signed-off-by: Pol Henarejos <pol.henarejos@cttc.es>
This commit is contained in:
Pol Henarejos
2026-08-14 14:15:50 +02:00
parent 5be7c83e5d
commit 6e2e3ca269
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/openpgp/cmd_import_data.c
+3 -7
View File
@@ -46,7 +46,6 @@ static bool tag_len(uint8_t **data, const uint8_t *end, uint16_t *len_out) {
}
int cmd_import_data(void) {
file_t *ef = NULL;
uint16_t fid = 0x0;
if (P1(apdu) != 0x3F || P2(apdu) != 0xFF) {
return SW_WRONG_P1P2();
@@ -54,6 +53,9 @@ int cmd_import_data(void) {
if (apdu.nc < 5) {
return SW_WRONG_LENGTH();
}
if (!has_pw3) {
return SW_SECURITY_STATUS_NOT_SATISFIED();
}
uint8_t *start = apdu.data;
uint8_t *apdu_end = apdu.data + apdu.nc;
if (*start++ != 0x4D) {
@@ -83,12 +85,6 @@ int cmd_import_data(void) {
return SW_WRONG_DATA();
}
start++;
if (!(ef = file_search_by_fid(fid, NULL, SPECIFY_EF))) {
return SW_REFERENCE_NOT_FOUND();
}
if (!file_authenticate_action(ef, ACL_OP_UPDATE_ERASE)) {
return SW_SECURITY_STATUS_NOT_SATISFIED();
}
if (start >= outer_end || (size_t)(outer_end - start) < (size_t)*start + 1u) {
return SW_WRONG_DATA();
}