Adding improvised signal jammers

Adds improvised signal jammers, does a bit of light refactoring, makes
signal jammers stop radio signallers.

code/game/objects/items/devices/PDA/PDA.dm

@@ -968,12 +968,10 @@ var/global/list/obj/item/device/pda/PDAs = list()
 			for (var/obj/machinery/message_server/MS in message_servers)
 			//PDAs are now dependent on the Message Server.
 				if(MS.active)
-					if (active_radio_jammers && active_radio_jammers.len)
-						for (var/obj/item/device/radiojammer/Jammer in active_radio_jammers)
-							if (get_dist(MS, Jammer) <= Jammer.radius && prob(75))
-								continue finding_server
-						useMS = MS
-						break
+					if (within_jamming_range(MS) && prob(75))
+						continue finding_server
+					useMS = MS
+					break
 
 	var/datum/signal/signal = src.telecomms_process()
 
@@ -984,22 +982,13 @@ var/global/list/obj/item/device/pda/PDAs = list()
 			var/turf/pos = get_turf(P)
 			if(pos.z in signal.data["level"])
 				useTC = 2
-				//Jamming the recipient
-				if (active_radio_jammers && active_radio_jammers.len)
-					for (var/obj/item/device/radiojammer/Jammer in active_radio_jammers)
-						if (get_dist(P, Jammer) <= Jammer.radius)
-							useTC = 1
-							break
+				if(within_jamming_range(P)) //Jamming the recipient
+					useTC = 1
 				//Let's make this barely readable
 				if(signal.data["compression"] > 0)
 					t = Gibberish(t, signal.data["compression"] + 50)
 
-	var/isjammed = 0
-	if (active_radio_jammers && active_radio_jammers.len)
-		for (var/obj/item/device/radiojammer/Jammer in active_radio_jammers)
-			if (get_dist(src, Jammer) <= Jammer.radius)
-				isjammed = 1
-				break
+	var/isjammed = within_jamming_range(src)
 
 	if(useMS && useTC && !isjammed) // only send the message if it's stable
 		if(useTC != 2) // Does our recipient have a broadcaster on their level?

code/game/objects/items/devices/radio/radio.dm

@@ -320,11 +320,8 @@ var/GLOBAL_RADIO_TYPE = 1 // radio type to use
 	  /* ###### Radio headsets can only broadcast through subspace ###### */
 
 		if(subspace_transmission)
-			//Actually, first we check if we're being jammed or not!
-			if (active_radio_jammers && active_radio_jammers.len)
-				for (var/obj/item/device/radiojammer/Jammer in active_radio_jammers)
-					if (get_dist(src, Jammer) <= Jammer.radius)
-						return
+			if (within_jamming_range(src)) //Actually, first we check if we're being jammed or not!
+				return
 
 			// First, we want to generate a new radio signal
 			var/datum/signal/signal = new
@@ -638,10 +635,8 @@ var/GLOBAL_RADIO_TYPE = 1 // radio type to use
 		return -1
 	if(!listening)
 		return -1
-	if (subspace_transmission == 1 && active_radio_jammers && active_radio_jammers.len)
-		for (var/obj/item/device/radiojammer/Jammer in active_radio_jammers)
-			if (get_dist(src, Jammer) <= Jammer.radius)
-				return -1
+	if (subspace_transmission == 1 && within_jamming_range(src))
+		return -1
 	if(!(0 in level))
 		var/turf/position = get_turf(src)
 		if(!position || !(position.z in level))

code/game/objects/items/devices/radio_jammer.dm

@@ -1,6 +1,12 @@
 //Global list for housing active radiojammers:
 var/list/active_radio_jammers = list()
 
+proc/within_jamming_range(var/atom/test) // tests if an object is near a radio jammer
+	if (active_radio_jammers && active_radio_jammers.len)
+		for (var/obj/item/device/radiojammer/Jammer in active_radio_jammers)
+			if (get_dist(test, Jammer) <= Jammer.radius)
+				return TRUE
+
 /obj/item/device/radiojammer
 	name = "radio jammer"
 	desc = "A small, inconspicious looking item with an 'ON/OFF' toggle."
@@ -10,29 +16,102 @@ var/list/active_radio_jammers = list()
 
 	var/active = 0
 	var/radius = 7
+	var/icon_state_active = "shield1"
+	var/icon_state_inactive = "shield0"
 
 /obj/item/device/radiojammer/New()
 	..()
+	update()
 
+/obj/item/device/radiojammer/Del()
 	if (active)
-		active_radio_jammers += src
-		icon_state = "shield1"
+		active_radio_jammers -= src
+	..()
+
 
 /obj/item/device/radiojammer/attack_self()
 	toggle()
 
+
 /obj/item/device/radiojammer/emp_act()
 	toggle()
 
+
 /obj/item/device/radiojammer/proc/toggle()
-	switch (active)
-		if (0)
-			usr << "<span class='notice'>You activate \the [src].</span>"
-			active = 1
-			active_radio_jammers += src
-			icon_state = "shield1"
-		if (1)
-			usr << "<span class='notice'>You deactivate \the [src].</span>"
-			active = 0
-			active_radio_jammers -= src
-			icon_state = "shield0"
+	if(active)
+		usr << "<span class='notice'>You deactivate \the [src].</span>"
+	else
+		usr << "<span class='notice'>You activate \the [src].</span>"
+	set_active(!active)
+
+
+/obj/item/device/radiojammer/proc/set_active(var/new_value)
+	active = new_value
+	update()
+
+
+/obj/item/device/radiojammer/proc/update()
+	if (active)
+		active_radio_jammers += src
+		icon_state = icon_state_active
+	else
+		active_radio_jammers -= src
+		icon_state = icon_state_inactive
+
+
+/obj/item/device/radiojammer/improvised
+	name = "improvised radio jammer"
+	desc = "An awkward bundle of wires, batteries, and radio transmitters."
+	var/obj/item/device/assembly_holder/assembly_holder
+	var/obj/item/weapon/cell/cell
+	var/power_drain_per_second = 200
+	var/last_updated = null
+	radius = 5
+	icon = 'icons/obj/assemblies/new_assemblies.dmi'
+	icon_state_active = "improvised_jammer_active"
+	icon_state_inactive = "improvised_jammer_inactive"
+
+
+/obj/item/device/radiojammer/improvised/New(var/obj/item/device/assembly_holder/incoming_holder, var/obj/item/weapon/cell/incoming_cell, var/mob/user)
+	..()
+	var/active_hand = user.hand
+	var/cell_was_in_hand = (user.l_hand==incoming_cell || user.r_hand ==incoming_cell)
+	user.drop_item_if_in_either_hand(incoming_holder,src)
+	user.drop_item_if_in_either_hand(incoming_cell,src)
+	assembly_holder = incoming_holder
+	assembly_holder.loc = src // this should never be necessary, but lets just be sure
+	cell = incoming_cell
+	cell.loc = src
+	set_active(TRUE)
+	last_updated = world.timeofday
+	processing_objects.Add(src) // drain that battery
+	if (cell_was_in_hand)
+		if(active_hand)
+			user.put_in_l_hand(src)
+		else
+			user.put_in_r_hand(src)
+	else
+		src.loc = user.loc
+
+/obj/item/device/radiojammer/improvised/Del()
+	if(active)
+		processing_objects.Remove(src)
+	..()
+
+
+/obj/item/device/radiojammer/improvised/process()
+	var/current = world.timeofday // current tick
+	var/delta = (current - last_updated) / 10.0 // delta in seconds
+	last_updated = current
+	if (!(cell.use(delta * power_drain_per_second)))
+		set_active(FALSE)
+		cell.charge = 0 // drain the last of the battery
+		processing_objects.Remove(src)
+
+
+/obj/item/device/radiojammer/improvised/attack_self(mob/user as mob)
+	user << "<span class='notice'>You disassemble the improvised signal jammer.</span>"
+	user.put_in_hands(assembly_holder)
+	user.put_in_hands(cell)
+	del(src)
+