Refactored all the backslash ref and ref() calls to use REF() instead (#19847)

Refactored all the backslash ref and ref() calls to use REF() instead.
Added a linting for raw ref proc calls.
This commit is contained in:
Fluffy
2024-09-13 10:17:32 +00:00
committed by GitHub
parent 40b8ac6a55
commit 0ae0b10764
233 changed files with 1629 additions and 1564 deletions
@@ -42,7 +42,7 @@ PROCESSING_SUBSYSTEM_DEF(nanoui)
* * ui_key - A string key used for the ui
*/
/datum/controller/subsystem/processing/nanoui/proc/get_open_ui(mob/user, src_object, ui_key)
var/src_object_key = SOFTREF(src_object)
var/src_object_key = REF(src_object)
if (!LAZYLEN(open_uis[src_object_key]) || !LAZYLEN(open_uis[src_object_key][ui_key]))
return null
@@ -61,7 +61,7 @@ PROCESSING_SUBSYSTEM_DEF(nanoui)
* Returns the number of UIs updated
*/
/datum/controller/subsystem/processing/nanoui/proc/update_uis(src_object)
var/src_object_key = SOFTREF(src_object)
var/src_object_key = REF(src_object)
if (!LAZYLEN(open_uis[src_object_key]))
return 0
@@ -82,7 +82,7 @@ PROCESSING_SUBSYSTEM_DEF(nanoui)
* Returns the number of UIs closed
*/
/datum/controller/subsystem/processing/nanoui/proc/close_uis(src_object)
var/src_object_key = SOFTREF(src_object)
var/src_object_key = REF(src_object)
if (!open_uis[src_object_key] || !islist(open_uis[src_object_key]))
return 0
@@ -134,7 +134,7 @@ PROCESSING_SUBSYSTEM_DEF(nanoui)
* * ui - The `/nanoui` ui to add
*/
/datum/controller/subsystem/processing/nanoui/proc/ui_opened(datum/nanoui/ui)
var/src_object_key = SOFTREF(ui.src_object)
var/src_object_key = REF(ui.src_object)
LAZYINITLIST(open_uis[src_object_key])
LAZYADD(ui.user.open_uis, ui)
@@ -151,7 +151,7 @@ PROCESSING_SUBSYSTEM_DEF(nanoui)
* Returns FALSE if no ui was removed, TRUE if removed successfully
*/
/datum/controller/subsystem/processing/nanoui/proc/ui_closed(datum/nanoui/ui)
var/src_object_key = SOFTREF(ui.src_object)
var/src_object_key = REF(ui.src_object)
var/ui_key = ui.ui_key
var/list/obj_uis = open_uis[src_object_key]
@@ -32,10 +32,10 @@ PROCESSING_SUBSYSTEM_DEF(psi)
if(PC.psionic_rank >= PSI_RANK_SENSITIVE)
to_chat(PC.owner, SPAN_NOTICE(FONT_HUGE("The Nlom field prompts you for your emotional state.")))
to_chat(PC.owner,
"<a href='?src=\ref[src];emotion=Calm;voter=[ref(PC)]'>Calm</a> | <a href='?src=\ref[src];emotion=Happy;voter=[ref(PC)]'>Happy</a> | \
<a href='?src=\ref[src];emotion=Sad;voter=[ref(PC)]'>Sad</a> | <a href='?src=\ref[src];emotion=Fearful;voter=[ref(PC)]'>Fearful</a> | \
<a href='?src=\ref[src];emotion=Angry;voter=[ref(PC)]'>Angry</a> | <a href='?src=\ref[src];emotion=Stressed;voter=[ref(PC)]'>Stressed</a> | \
<a href='?src=\ref[src];emotion=Confused;voter=[ref(PC)]'>Confused</a")
"<a href='?src=[REF(src)];emotion=Calm;voter=[REF(PC)]'>Calm</a> | <a href='?src=[REF(src)];emotion=Happy;voter=[REF(PC)]'>Happy</a> | \
<a href='?src=[REF(src)];emotion=Sad;voter=[REF(PC)]'>Sad</a> | <a href='?src=[REF(src)];emotion=Fearful;voter=[REF(PC)]'>Fearful</a> | \
<a href='?src=[REF(src)];emotion=Angry;voter=[REF(PC)]'>Angry</a> | <a href='?src=[REF(src)];emotion=Stressed;voter=[REF(PC)]'>Stressed</a> | \
<a href='?src=[REF(src)];emotion=Confused;voter=[REF(PC)]'>Confused</a")
complete_nlom_time = world.time + 2 MINUTES
completing_nlom = TRUE
if(completing_nlom && world.time >= complete_nlom_time)