Refactored all the backslash ref and ref() calls to use REF() instead (#19847)

Refactored all the backslash ref and ref() calls to use REF() instead.
Added a linting for raw ref proc calls.
This commit is contained in:
Fluffy
2024-09-13 10:17:32 +00:00
committed by GitHub
parent 40b8ac6a55
commit 0ae0b10764
233 changed files with 1629 additions and 1564 deletions
@@ -85,7 +85,7 @@
var/account_number = "[M]"
var/list/transactions = list()
for(var/datum/transaction/T in D.transactions)
var/Tref = ref(T)
var/Tref = REF(T)
transactions += list(list(
"ref" = Tref,
"date" = T.date,
@@ -43,14 +43,14 @@
for(var/obj/machinery/teleport/pad/S in range(3, T))
var/list/pad_info = list(
"name" = "[S.name] ([S.x]-[S.y][S.z])",
"ref" = "\ref[S]"
"ref" = "[REF(S)]"
)
near_pads_info += list(pad_info)
data["nearby_pads"] = near_pads_info
else
var/atom/selected_atom = linked_pad.locked_obj ? linked_pad.locked_obj.resolve() : null
if(selected_atom)
data["selected_target"] = "\ref[selected_atom]"
data["selected_target"] = "[REF(selected_atom)]"
data["selected_target_name"] = linked_pad.locked_obj_name
data["calibration"] = 100 - linked_pad.calibration
var/list/area_index = list()
@@ -71,7 +71,7 @@
area_index[tmpname] = 1
var/list/teleporter_info = list(
"name" = tmpname,
"ref" = "\ref[R]"
"ref" = "[REF(R)]"
)
teleport_beacon_info += list(teleporter_info)
data["teleport_beacons"] = teleport_beacon_info
@@ -99,7 +99,7 @@
area_index[tmpname] = 1
var/list/implant_info = list(
"name" = tmpname,
"ref" = "\ref[I]"
"ref" = "[REF(I)]"
)
teleport_implant_info += list(implant_info)
data["teleport_implants"] = teleport_implant_info
@@ -62,7 +62,7 @@
for(var/obj/machinery/alarm/alarm in monitored_alarms)
alarms += list(list(
"name" = sanitize(alarm.name),
"ref"= "\ref[alarm]",
"ref"= "[REF(alarm)]",
"danger" = max(alarm.danger_level, alarm.alarm_area.atmosalm)
))
data["alarms"] = alarms
@@ -196,7 +196,7 @@
/datum/computer_file/program/law_manager/proc/package_laws(var/list/data, var/field, var/list/datum/ai_law/laws)
var/list/packaged_laws = list()
for(var/datum/ai_law/AL in laws)
packaged_laws += list(list("law" = AL.law, "index" = AL.get_index(), "state" = owner.laws.get_state_law(AL), "ref" = "\ref[AL]"))
packaged_laws += list(list("law" = AL.law, "index" = AL.get_index(), "state" = owner.laws.get_state_law(AL), "ref" = "[REF(AL)]"))
data[field] = packaged_laws
data["has_[field]"] = packaged_laws.len
@@ -208,7 +208,7 @@
package_laws(packaged_laws, "ion_laws", ALs.ion_laws)
package_laws(packaged_laws, "inherent_laws", ALs.inherent_laws)
package_laws(packaged_laws, "supplied_laws", ALs.supplied_laws)
law_sets += list(list("name" = ALs.name, "header" = ALs.law_header, "ref" = "\ref[ALs]","laws" = packaged_laws))
law_sets += list(list("name" = ALs.name, "header" = ALs.law_header, "ref" = "[REF(ALs)]","laws" = packaged_laws))
return law_sets
@@ -38,7 +38,7 @@
var/list/guntracker_info = list(
"gun_name" = capitalize_first_letters(P.gun.name),
"registered_info" = P.registered_user ? P.registered_user : "Unregistered",
"ref" = "\ref[P]",
"ref" = "[REF(P)]",
"lock_status" = P.lock_status
)
wireless_firing_pins_data += list(guntracker_info)
@@ -31,7 +31,7 @@
var/list/chem_info = list(
"implanted_name" = C.imp_in.real_name,
"remaining_units" = round(C.reagents.total_volume, 0.1),
"ref" = "\ref[C]"
"ref" = "[REF(C)]"
)
chem_implants += list(chem_info)
data["chem_implants"] = chem_implants
@@ -53,7 +53,7 @@
var/list/tracker_info = list(
"id" = T.id,
"loc_display" = loc_display,
"ref" = "\ref[T]"
"ref" = "[REF(T)]"
)
tracking_implants += list(tracker_info)
data["tracking_implants"] = tracking_implants
@@ -33,7 +33,7 @@
continue
if(!AreConnectedZLevels(computer.loc.z, M.loc.z))
continue
var/list/mechData = list("location" = null, "name" = null, "pilot" = null, "ref" = "\ref[M]", "camera" = null, "lockdown" = null)
var/list/mechData = list("location" = null, "name" = null, "pilot" = null, "ref" = "[REF(M)]", "camera" = null, "lockdown" = null)
mechData["name"] = M.name
mechData["pilot"] = "[M.old_mob]"
@@ -51,7 +51,7 @@
continue
if(!AreConnectedZLevels(computer.loc.z, R.loc.z))
continue
var/list/robotData = list("location" = null, "name" = null, "pilot" = null, "ref" = "\ref[R]")
var/list/robotData = list("location" = null, "name" = null, "pilot" = null, "ref" = "[REF(R)]")
robotData["name"] = R.name
robotData["pilot"] = "[R.old_mob]"
@@ -63,7 +63,7 @@
data["mechs"] = sortByKey(mechs, "pilot")
data["robots"] = sortByKey(robots, "pilot")
data["current_cam_loc"] = current_camera ? "\ref[current_camera.loc]" : null
data["current_cam_loc"] = current_camera ? "[REF(current_camera.loc)]" : null
return data