Security areas mapping improvements (#10366)

* Splits bigger security areas into multiple

* Adds low level APC and maps it into the security areas

code/modules/power/apc.dm

@@ -71,6 +71,9 @@
 /obj/machinery/power/apc/critical
 	is_critical = TRUE
 
+/obj/machinery/power/apc/low
+	cell_type = /obj/item/cell
+
 /obj/machinery/power/apc/high
 	cell_type = /obj/item/cell/high
 

html/changelogs/amunak-security-areas.yml

@@ -0,0 +1,10 @@
+author: Amunak
+delete-after: True
+changes:
+  - rscadd: "Added low level APCs (with just a regular battery), to be used in offices and other smaller, less critical areas. This allows long-term power loss to be of some consequence. Mapped into the security areas."
+  - maptweak: "Split upper security (investigations & training) into multiple per-room areas as it should be. Added light switches and APCs for those areas."
+  - maptweak: "The room with stairs to Training is now a part of the Training area, not Brig."
+  - maptweak: "Evidence Storage is now its own area as well."
+  - maptweak: "From security/brig there were two rooms split: the 'control room' and 'processing'. Also added APCs."
+  - tweak: "Added back the option to toggle lights to most Security areas (basically everything but places where prisoners are held)."
+  - tweak: "Added/modified area icons for most of the areas mentioned above for easier mapping."

maps/_common/areas/station/security.dm

@@ -11,11 +11,6 @@
 	icon_state = "security"
 
 // For mapppers
-/area/security/hallway
-	name = "Security - Hallway"
-	lightswitch = TRUE
-	icon_state = "security"
-
 /area/security/lobby
 	name = "Security - Lobby"
 	icon_state = "security"
@@ -36,6 +31,17 @@
 		temp_timer.releasetime = 1
 	..()
 
+/area/security/brig/control_room
+	name = "Security - Brig Control Room"
+	icon_state = "brig_control"
+	lightswitch = FALSE
+	no_light_control = 0
+
+/area/security/brig/processing
+	name = "Security - Brig Processing"
+	icon_state = "brig_proc"
+	no_light_control = 0
+
 /area/security/prison
 	name = "Security - Prison Wing"
 	lightswitch = TRUE
@@ -54,43 +60,83 @@
 	name = "Security - Warden's Office"
 	icon_state = "Warden"
 	sound_env = SMALL_SOFTFLOOR
+	no_light_control = 0
 
 /area/security/armory
 	name = "Security - Armory"
 	icon_state = "Warden"
 	ambience = AMBIENCE_HIGHSEC
+	no_light_control = 0
+
+/area/security/investigations
+	name = "Security - Investigations Division"
+	icon_state = "investigations"
+	allow_nightmode = 1
+	no_light_control = 0
+
+/area/security/investigations_storage
+	name = "Security - Evidence Storage"
+	icon_state = "evidence"
+	no_light_control = 0
 
 /area/security/forensics_office
 	name = "Security - Forensic Office"
-	icon_state = "detective"
+	icon_state = "investigations_office"
 	sound_env = MEDIUM_SOFTFLOOR
+	no_light_control = 0
+
+/area/security/forensics_laboratory
+	name = "Security - Forensic Laboratory"
+	icon_state = "investigations_office"
+	sound_env = SMALL_ENCLOSED
+	no_light_control = 0
+
+/area/security/forensics_morgue
+	name = "Security - Autopsy Lab"
+	icon_state = "morgue"
+	ambience = AMBIENCE_GHOSTLY
+	no_light_control = 0
 
 /area/security/detectives_office
 	name = "Security - Detective's Office"
 	icon_state = "detective"
 	sound_env = SMALL_SOFTFLOOR
-
-/area/security/investigations
-	name = "Security - Investigations Division"
-	icon_state = "detective"
+	no_light_control = 0
 
 /area/security/training
 	name = "Security - Training Wing"
-	icon_state = "firingrange"
+	icon_state = "training"
+	allow_nightmode = 1
+	no_light_control = 0
+
+/area/security/training_theoretical
+	name = "Security - Theoretical Training"
+	icon_state = "training_office"
+	sound_env = MEDIUM_SOFTFLOOR
+	no_light_control = 0
+
+/area/security/training_crimescene
+	name = "Security - Crime Scene Training"
+	icon_state = "training_office"
+	sound_env = SMALL_ENCLOSED
+	no_light_control = 0
 
 /area/security/range
 	name = "Security - Firing Range"
 	icon_state = "firingrange"
 	flags = FIRING_RANGE
+	no_light_control = 0
 
 /area/security/tactical
 	name = "Security - Tactical Equipment"
 	icon_state = "Tactical"
 	ambience = AMBIENCE_HIGHSEC
+	no_light_control = 0
 
 /area/security/security_office
 	name = "Security - Security Office"
 	icon_state = "security"
+	no_light_control = 0
 
 /*
 	New()
@@ -115,10 +161,12 @@
 	ambience = AMBIENCE_HIGHSEC
 	holomap_color = null
 	flags = HIDE_FROM_HOLOMAP
+	no_light_control = 0
 
 /area/security/checkpoint
 	name = "Security Checkpoint"
 	icon_state = "checkpoint1"
+	no_light_control = 0
 
 /area/security/checkpoint2
 	name = "Security - Arrivals Checkpoint"
@@ -148,9 +196,11 @@
 /area/security/vacantoffice
 	name = "Vacant Office"
 	icon_state = "security"
+	no_light_control = 0
 
 /area/security/vacantoffice2
 	name = "Security - Meeting Room"
+	no_light_control = 0
 
 /area/security/penal_colony
 	name = "\improper Security - Penal Mining Colony"