Fix loot crate runtime + bad mapped-in crate paths (#13747)

code/game/objects/structures/crates_lockers/crates.dm

@@ -537,8 +537,10 @@
 		"3" = (100 - ((STOCK_RARE_PROB * rarity) + (STOCK_UNCOMMON_PROB * rarity)))
 	)
 
-	var/icontype = pick(typesof(/obj/structure/closet/crate) - typesof(/obj/structure/closet/crate/secure/gear_loadout))
-	var/obj/structure/closet/crate/C = new icontype(src.loc)
+	var/list/valid_loot = typesof(/obj/structure/closet/crate) - typesof(/obj/structure/closet/crate/secure/gear_loadout)
+	valid_loot -= typesof(/obj/structure/closet/crate/loot)
+	var/icontype = pick(valid_loot)
+	var/obj/structure/closet/crate/C = new icontype(get_turf(src))
 
 	C.name = "unusual container"
 	C.desc = "A mysterious container of unknown origins. What mysteries lie within?"

html/changelogs/johnwildkins-fixcrate.yml

@@ -0,0 +1,6 @@
+author: JohnWildkins
+
+delete-after: True
+
+changes:
+  - bugfix: "Fix runtime errors related to bad loot crate spawns / old mapped-in crates."

maps/away/romanovich/first_aurora.dmm

@@ -2203,11 +2203,7 @@
 /turf/simulated/floor/airless,
 /area/derelict/hallway/northeast)
 "hp" = (
-/obj/structure/closet{
-	icon_closed = "cabinet_closed";
-	icon_opened = "cabinet_open";
-	icon_state = "cabinet_closed"
-	},
+/obj/structure/closet/cabinet,
 /obj/item/bananapeel,
 /obj/effect/decal/cleanable/dirt,
 /turf/simulated/floor/tiled/airless,

maps/away/romanovich/grand_romanovich.dmm

@@ -5799,7 +5799,7 @@
 /turf/simulated/floor/wood,
 /area/grand_romanovich)
 "ss" = (
-/obj/structure/closet/crate/radiation,
+/obj/structure/closet/crate/rad,
 /obj/machinery/light{
 	dir = 2;
 	icon_state = "tube1"