cyberpresidentvanellope/Aurora.3
1
0
Fork 0
mirror of https://github.com/Aurorastation/Aurora.3.git synced 2026-08-29 16:10:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

Icon smoothing and icon update refactor (#17569)

Browse Source 
* Atomization

* asdfsadf

* sdfas

---------

Co-authored-by: FluffyGhost <FluffyGhost>
This commit is contained in:
Fluffy
2023-10-12 21:23:28 +00:00
committed by GitHub
co-authored by FluffyGhost <FluffyGhost>
parent bb4d89a498
commit 8bb0ecfcd3
7 changed files with 223 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/controllers/subsystems/icon_updates.dm
+91 -28
View File
@@ -5,13 +5,20 @@ SUBSYSTEM_DEF(icon_update)
priority = SS_PRIORITY_ICON_UPDATE
init_order = SS_INIT_ICON_UPDATE
var/list/queue = list()
/**
* Associative list of atoms -> callback params
* A list of `/atoms` that are waiting to have its icon updated
*/
VAR_PRIVATE/list/icon_update_queue = list()
///Deferred list, contains atoms that were not ready to be processed in the previous run
VAR_PRIVATE/list/deferred = list()
/datum/controller/subsystem/icon_update/New()
NEW_SS_GLOBAL(SSicon_update)
/datum/controller/subsystem/icon_update/stat_entry(msg)
msg = "QU:[queue.len]"
msg = "QU:[icon_update_queue.len]"
return ..()
/datum/controller/subsystem/icon_update/Initialize()
@@ -19,45 +26,101 @@ SUBSYSTEM_DEF(icon_update)
..()
/datum/controller/subsystem/icon_update/fire(resumed = FALSE, no_mc_tick = FALSE)
var/list/curr = queue
var/list/icon_update_queue_cache = icon_update_queue
if (!curr.len)
suspend()
return
while (length(icon_update_queue_cache))
var/atom/A = icon_update_queue_cache[length(icon_update_queue_cache)]
var/list/argv = icon_update_queue_cache[A]
icon_update_queue_cache.len--
while (curr.len)
var/atom/A = curr[curr.len]
var/list/argv = curr[A]
curr.len--
if(A.initialized)
A.icon_update_queued = FALSE
A.icon_update_queued = FALSE
//Do not target qdeleted atoms
if(QDELETED(A))
continue
//Do not target qdeleted atoms
if(QDELETED(A))
continue
if (islist(argv))
A.update_icon(arglist(argv))
else
A.update_icon()
A.update_above()
A.last_icon_update = world.time
if (islist(argv))
A.update_icon(arglist(argv))
else
A.update_icon()
A.update_above()
A.last_icon_update = world.time
src.deferred[A] = argv
if (no_mc_tick)
CHECK_TICK
else if (MC_TICK_CHECK)
return
if (!length(icon_update_queue_cache))
if(deferred.len)
icon_update_queue = deferred
deferred = icon_update_queue_cache
else
can_fire = FALSE
/**
* Adds an atom to the queue to have its icon updated
*
* * item - An `/atom` to add to the queue
* * parameters - Parameters that will be passed to `update_icon()` on callback
*/
/datum/controller/subsystem/icon_update/proc/add_to_queue(var/atom/item, ...)
SHOULD_NOT_SLEEP(TRUE)
var/atom/item_cache = item
//Skip atoms that are being deleted
if(QDELETED(item_cache))
return
if(!item_cache.icon_update_queued && (!item_cache.icon_update_delay || (item_cache.last_icon_update + item_cache.icon_update_delay < world.time)))
item_cache.icon_update_queued = TRUE
//Determine if we got any parameter, and if we do set it in the associative list, otherwise just set it to TRUE
var/list/calling_arguments = length(args) > 1 ? args.Copy(2) : TRUE
src.icon_update_queue[item_cache] = calling_arguments
if(!src.can_fire)
can_fire = TRUE
/**
* Removes an atom from the queue of atoms waiting to have its icon updated
*
* * item - An `/atom` to add to the queue
* * VARIPARAM - Parameters that will be passed to `update_icon()` on callback
*/
/datum/controller/subsystem/icon_update/proc/remove_from_queue(var/atom/item)
SHOULD_NOT_SLEEP(TRUE)
var/atom/item_cache = item
if(item_cache.icon_update_queued)
item_cache.icon_update_queued = FALSE
src.icon_update_queue -= item_cache
src.deferred -= item_cache
/atom
var/tmp/last_icon_update
var/tmp/icon_update_queued
var/icon_update_delay
///When was the last time (in `world.time`) that the icon of this atom was updated via `SSicon_update`
var/tmp/last_icon_update = null
///If the atom is currently queued to have it's icon updated in `SSicon_update`
var/tmp/icon_update_queued = FALSE
///Delay to apply before updating the icon in `SSicon_update`
var/icon_update_delay = null
/atom/proc/update_icon()
/atom/proc/queue_icon_update(...)
if (!icon_update_queued && (!icon_update_delay || (last_icon_update + icon_update_delay < world.time)))
icon_update_queued = TRUE
SSicon_update.queue[src] = args.len ? args : TRUE
if (SSicon_update.suspended)
SSicon_update.wake()
/**
* DO NOT USE
*
* Left for backward compatibility, use `SSicon_update.add_to_queue(thing)`
*/
/atom/proc/queue_icon_update()
//Skip if we're being deleted
if(QDELETED(src))
return
SSicon_update.add_to_queue(src)