Post dreamchecker fixes (#8287)

Fixes lack of chat tags, and runtime on player panel preventing it from displaying stuff.

Don't really understand the problem with Cut() on the player panel data["players"], it should leave an empty list behind right..? Anyway. Let's see if this passes dreamchecker.
This commit is contained in:
mikomyazaki
2020-02-16 20:22:14 +00:00
committed by GitHub
parent 6074224d00
commit 9ddca0bc3c
3 changed files with 44 additions and 2 deletions
+1 -2
View File
@@ -332,11 +332,10 @@ proc/TextPreview(var/string,var/len=40)
//For generating neat chat tag-images
//The icon var could be local in the proc, but it's a waste of resources
// to always create it and then throw it out.
var/icon/text_tag_icons = new('./icons/chattags.dmi')
/proc/create_text_tag(var/tagname, var/tagdesc = tagname, var/client/C = null)
if(C && (C.prefs.toggles & CHAT_NOICONS))
return tagdesc
return "<IMG src='\ref[text_tag_icons]' class='text_tag' iconstate='[tagname]'" + (tagdesc ? " alt='[tagdesc]'" : "") + ">"
return "<IMG src='\ref['./icons/chattags.dmi']' class='text_tag' iconstate='[tagname]'" + (tagdesc ? " alt='[tagdesc]'" : "") + ">"
// For processing simple markup, similar to what Skype and Discord use.
// Enabled from a config setting.
+1
View File
@@ -62,6 +62,7 @@ var/datum/vueui_module/player_panel/global_player_panel
data["players"] = players.Cut()
for(var/mob/M in mobs)
var/ref = "\ref[M]"
LAZYINITLIST(data["players"][ref])
if(!M.ckey)
data["players"][ref] = FALSE
continue
+42
View File
@@ -0,0 +1,42 @@
################################
# Example Changelog File
#
# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb.
#
# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.)
# When it is, any changes listed below will disappear.
#
# Valid Prefixes:
# bugfix
# wip (For works in progress)
# tweak
# soundadd
# sounddel
# rscadd (general adding of nice things)
# rscdel (general deleting of nice things)
# imageadd
# imagedel
# maptweak
# spellcheck (typo fixes)
# experiment
# balance
# admin
# backend
# security
# refactor
#################################
# Your name.
author: mikomyazaki
# Optional: Remove this file after generating master changelog. Useful for PR changelogs that won't get used again.
delete-after: True
# Any changes you've made. See valid prefix list above.
# INDENT WITH TWO SPACES. NOT TABS. SPACES.
# SCREW THIS UP AND IT WON'T WORK.
# Also, all entries are changed into a single [] after a master changelog generation. Just remove the brackets when you add new entries.
# Please surround your changes in double quotes ("), as certain characters otherwise screws up compiling. The quotes will not show up in the changelog.
changes:
- bugfix: "Fixes lack of chat tags."
- bugfix: "Fixes runtime on the Player Panel."