Fixed vars getting set twice in the same class (#19294)

Fixed vars getting set twice in the same class
This commit is contained in:
Fluffy
2024-06-02 23:13:31 +00:00
committed by GitHub
parent 0dc6f03a46
commit aeb27e21e1
78 changed files with 93 additions and 132 deletions
@@ -5,7 +5,6 @@
its large xeno population which enjoys various privileges compared to other space powers. With a very lax migration policy, virtually everyone is welcome to live here. However, \
unrest and gridlock undermine the government, and the aggressive attitude of the Sol Alliance against its former system has made many worried for the future of the Republic."
consular_outfit = /obj/outfit/job/representative/consular/ceti
consular_outfit = /obj/outfit/job/representative/consular/ceti
assistant_outfit = /obj/outfit/job/consular_assistant/ceti
job_species_blacklist = list(
@@ -126,11 +126,10 @@
power_add = BATTLE_MONSTERS_POWER_COMMON
defense_add = 4
attack_add = 1
rarity = 0.25
rarity = BATTLE_MONSTERS_RARITY_UNCOMMON
description = "a proud male %SPECIES %NAME dorned in heavy %ELEMENT_AND armor and wielding a decorative %WEAPON_AND. They're sworn to protect the Great Kingdom of Garoosh from Barbarians."
special_effects = "%SPECIES_C Protection: As long as %NAME is visible, all other %SPECIES monsters are attack immune."
attack_type = BATTLE_MONSTERS_ATTACKTYPE_SWORDSMAN
rarity = BATTLE_MONSTERS_RARITY_UNCOMMON
rarity_score = 0
/datum/battle_monsters/monster/human/king
-1
View File
@@ -215,7 +215,6 @@
contained_sprite = TRUE
icon_state = "helm_heavy"
item_state = "helm_heavy"
contained_sprite = TRUE
armor = list(
melee = ARMOR_MELEE_VERY_HIGH,
bullet = ARMOR_BALLISTIC_RIFLE,
@@ -42,9 +42,8 @@
rad = ARMOR_RAD_SMALL
)
siemens_coefficient = 0.1
vision_restriction = 0
slowdown = 4
vision_restriction = TINT_NONE
slowdown = 4
glove_type = /obj/item/clothing/gloves/powerfist
allowed_module_types = MODULE_GENERAL | MODULE_LIGHT_COMBAT | MODULE_HEAVY_COMBAT | MODULE_SPECIAL
@@ -188,11 +187,10 @@
bio = ARMOR_BIO_SHIELDED,
rad = ARMOR_RAD_RESISTANT
)
siemens_coefficient = 0.1
siemens_coefficient = 0
vision_restriction = 0
slowdown = 2
offline_slowdown = 3
siemens_coefficient = 0
species_restricted = list(BODYTYPE_TAJARA)
@@ -18,10 +18,9 @@
)
siemens_coefficient = 0.1
emp_protection = 30
vision_restriction = 0
vision_restriction = TINT_NONE
slowdown = 0
offline_slowdown = 3
vision_restriction = TINT_NONE
species_restricted = list(BODYTYPE_SKRELL)
helm_type = /obj/item/clothing/head/helmet/space/rig/skrell
@@ -47,7 +47,6 @@
req_one_access = list()
helm_type = null
suit_type = null
glove_type = null
boot_type = null
@@ -623,7 +623,6 @@
refittable_species = list(BODYTYPE_HUMAN, BODYTYPE_TAJARA, BODYTYPE_IPC, BODYTYPE_UNATHI, BODYTYPE_SKRELL)
/obj/item/clothing/suit/space/void/freelancer
icon_state = "freelancer"
name = "armored voidsuit"
desc = "A suit from a commercial combat voidsuit design. Acceptably well-armored and prolific thoughout the Orion Spur, it can be seen in use by everyone from mercenaries to militia groups to police forces."
icon = 'icons/obj/clothing/voidsuit/mercenary.dmi'
@@ -18,7 +18,6 @@
and weak lasers. It is significantly more comfortable to wear than a full steel plate, and many soldiers on Sun Reach only wear their flak vests — \
much to the dismay of officers."
icon_state = "dom_carrier"
icon_state = "dom_carrier"
armor = list(
melee = ARMOR_MELEE_KNIVES,
bullet = ARMOR_BALLISTIC_SMALL,
+2 -4
View File
@@ -77,10 +77,9 @@
bomb = ARMOR_BOMB_SHIELDED
)
max_pressure_protection = FIRESUIT_MAX_PRESSURE
siemens_coefficient = 0.1
siemens_coefficient = 0
flags_inv = HIDEMASK|HIDEEARS|HIDEEYES
body_parts_covered = HEAD|FACE|EYES
siemens_coefficient = 0
tint = TINT_HEAVY
@@ -105,7 +104,7 @@
energy = ARMOR_ENERGY_RESISTANT,
bomb = ARMOR_BOMB_SHIELDED
)
siemens_coefficient = 0.1
siemens_coefficient = 0
item_flags = ITEM_FLAG_THICK_MATERIAL
flags_inv = HIDEJUMPSUIT|HIDETAIL
heat_protection = UPPER_TORSO|LOWER_TORSO|LEGS|FEET|ARMS
@@ -113,7 +112,6 @@
body_parts_covered = UPPER_TORSO|LOWER_TORSO|LEGS|FEET|ARMS
max_heat_protection_temperature = SPACE_SUIT_MAX_HEAT_PROTECTION_TEMPERATURE
max_pressure_protection = FIRESUIT_MAX_PRESSURE
siemens_coefficient = 0
var/mob/living/carbon/human/wearer = null
var/suit_temp = T20C
-1
View File
@@ -91,7 +91,6 @@
flags_inv = HIDEJUMPSUIT
body_parts_covered = UPPER_TORSO|LOWER_TORSO|ARMS
flags_inv = 0
/obj/item/clothing/suit/wizrobe/fake
name = "wizard robe"
@@ -313,7 +313,6 @@
icon_state = "capjacket"
item_state = "capjacket"
contained_sprite = TRUE
contained_sprite = TRUE
/obj/item/clothing/suit/storage/tajaran/hunting
name = "adhomian hunting coat"
@@ -17,7 +17,6 @@
bomb = ARMOR_BOMB_PADDED
)
body_parts_covered = LEGS|FEET
contained_sprite = TRUE
drop_sound = 'sound/items/drop/boots.ogg'
pickup_sound = 'sound/items/pickup/boots.ogg'
@@ -158,7 +157,6 @@
bomb = ARMOR_BOMB_PADDED
)
w_class = ITEMSIZE_NORMAL
contained_sprite = TRUE
drop_sound = 'sound/items/drop/axe.ogg'
pickup_sound = 'sound/items/pickup/axe.ogg'
@@ -3,9 +3,8 @@
desc = "A silver locket that seems to have space for a photo within."
icon_state = "locket"
item_state = "locket"
slot_flags = 0
w_class = ITEMSIZE_SMALL
slot_flags = SLOT_MASK | SLOT_TIE
w_class = ITEMSIZE_SMALL
var/open
var/obj/item/held //Item inside locket.
@@ -174,7 +174,6 @@
/obj/item/clothing/accessory/storage/pouches/colour
icon_state = "thigh_colour"
icon_state = "thigh_colour"
/obj/item/clothing/accessory/storage/knifeharness
name = "decorated harness"
@@ -230,7 +230,6 @@
icon = 'icons/obj/item/clothing/department_uniforms/command.dmi'
icon_state = "bridge_crew"
item_state = "bridge_crew"
contained_sprite = TRUE
/obj/item/clothing/under/rank/bridge_crew/alt
name = "bridge crew's skirt"
@@ -97,7 +97,6 @@
appliance = MIX
fruit = list("guami" = 4)
reagents = list(/singleton/reagent/drink/dynjuice = 10, /singleton/reagent/drink/milk = 10)
result = /obj/item/reagent_containers/food/snacks/qlguabi
reagent_mix = RECIPE_REAGENT_REPLACE //Simplify end product
result = /obj/item/reagent_containers/food/snacks/qlguabi
@@ -78,7 +78,6 @@
mutants = list("deathnettle")
chems = list(/singleton/reagent/nutriment = list(1,50), /singleton/reagent/acid = list(0,1))
kitchen_tag = "nettle"
kitchen_tag = "nettle"
/datum/seed/nettle/setup_traits()
..()
-2
View File
@@ -646,8 +646,6 @@
created_window = /obj/structure/window/borosilicate/reinforced
hardness = 40
weight = 30
stack_origin_tech = list(TECH_MATERIAL = 2)
composite_material = list() //todo
rod_product = null
/material/plastic
-1
View File
@@ -288,7 +288,6 @@
can_wield = 0
force = 25
digspeed = 2
digspeed_unwielded = 3
force_unwielded = 20.0
@@ -1479,7 +1479,6 @@ Follow by example and make good judgement based on length which list to include
chatname = "unshaved hair"
name = "Undercut 3"
icon_state = "hair_undercut3"
chatname = "unshaved hair"
/datum/sprite_accessory/hair/undercut4
name = "Undercut 4"
-1
View File
@@ -47,7 +47,6 @@
"a", "a", "e", "e", "i", "i", "o", "o", "u", "u", "s", "s"
)
partial_understanding = list(LANGUAGE_AZAZIBA = 25)
allow_accents = TRUE
/datum/language/unathi_azaziba
name = LANGUAGE_AZAZIBA
@@ -96,7 +96,7 @@
/datum/species/tajaran/tesla_body
name = SPECIES_TAJARA_TESLA_BODY
name_plural = "Tesla Rejuvenation Suit Tajara"
name_plural = "Created as part of the Tesla prosthetics program, the Tesla Rejuvenation Suit is a hulking suit that allows disabled Tajara to regain their vigor. \
blurb = "Created as part of the Tesla prosthetics program, the Tesla Rejuvenation Suit is a hulking suit that allows disabled Tajara to regain their vigor. \
Its users are surgically grafted in the machine; their limbs are replaced by large, industrial replacements; their organs are placed in a tank full of healing chemicals \
located inside their chest, and finally, a big tesla spine is installed. Only the head remains untouched. The suits are bulky and clumsy, restricting their wearers to jobs \
involving weight lifting and other menial tasks. Since this invention is still in its early stage, reports of it malfunctioning or causing pain to its user are not unheard off; \
@@ -345,9 +345,8 @@ GLOBAL_LIST_EMPTY(sparring_attack_cache)
attack_noun = list("tap","light strike")
attack_verb = list("tapped", "lightly struck")
desc = "Sparring: A light strike to your opponent. So light, it won't even leave a mark! They WILL feel this, but will suffer no dangerous side effect, unless you punch them into cardiac arrest!"
damage = 2
shredding = 0
damage = 0
shredding = 0
sharp = 0
edge = FALSE
attack_name = "light hit"
@@ -279,9 +279,7 @@
canbrush = TRUE
meat_type = /obj/item/reagent_containers/food/snacks/meat/adhomai
meat_amount = 4
faction = "Adhomai"
vehicle_version = /obj/vehicle/animal/climber
natural_armor = list(
melee = ARMOR_MELEE_MEDIUM,
@@ -349,7 +349,6 @@
named = TRUE
gender = FEMALE
icon_state = "crusher"
icon_state = "crusher"
icon_living = "crusher"
icon_dead = "crusher_dead"
icon_rest = "crusher_rest"
@@ -18,7 +18,6 @@
response_harm = "stomps"
stop_automated_movement = 1
friendly = "pinches"
mob_size = 5
hunger_enabled = 0
var/obj/item/inventory_head
var/obj/item/inventory_mask
@@ -20,7 +20,6 @@
icon_living = "cod"
icon_dead = "cod_dead"
icon_rest = "cod_rest"
item_state = "cod"
holder_type = /obj/item/holder/fish/cod
@@ -30,4 +29,3 @@
icon_living = "gupper"
icon_dead = "gupper_dead"
icon_rest = "gupper_rest"
item_state = "gupper"
@@ -59,7 +59,7 @@
response_help = "pets"
response_disarm = "gently pushes aside"
response_harm = "kicks"
attacktext = "kicked"
attacktext = "gored"
faction = "Moghes"
maxHealth = 200
@@ -70,7 +70,6 @@
melee_damage_lower = 15
melee_damage_upper = 15
armor_penetration = 20
attacktext = "gored"
attack_sound = 'sound/weapons/pierce.ogg'
canbrush = TRUE
brush = /obj/item/reagent_containers/glass/rag
@@ -22,7 +22,6 @@
var/min_explode_time = 1200
density = 0
holder_type = /obj/item/holder/mushroom
mob_size = 2
canbrush = TRUE
brush = /obj/item/reagent_containers/glass/rag
@@ -11,7 +11,7 @@
response_help = "passes through"
response_disarm = "shoves"
response_harm = "hits"
speed = -1
speed = 4
maxHealth = 80
health = 80
environment_smash = 2
@@ -32,7 +32,6 @@
min_n2 = 0
max_n2 = 0
minbodytemp = 0
speed = 4
faction = "faithless"
@@ -83,14 +83,13 @@
poison_per_bite = 10
speed = -2
poison_type = /singleton/reagent/soporific
poison_per_bite = 3
var/playable = TRUE
fed = 1
minbodytemp = 0
maxbodytemp = 350
min_oxy = 0
max_co2 = 0
max_tox = 0
var/playable = TRUE
/mob/living/simple_animal/hostile/giant_spider/nurse/servant/Life()
..()
@@ -6,14 +6,13 @@
icon_living = "clown"
icon_dead = "clown_dead"
icon_gib = "clown_gib"
speak_chance = 0
speak_chance = 1
turns_per_move = 5
response_help = "pokes"
response_disarm = "gently pushes aside"
response_harm = "hits"
speak = list("HONK", "Honk!", "Welcome to clown planet!")
emote_see = list("honks")
speak_chance = 1
universal_speak = FALSE
a_intent = I_HURT
stop_automated_movement_when_pulled = 0
@@ -41,7 +41,7 @@
emote_see = list("flutters its wings")
speak_chance = 1//1% (1 in 100) chance every tick; So about once per 150 seconds, assuming an average tick is 1.5s
universal_speak = FALSE
universal_speak = TRUE
turns_per_move = 5
meat_type = /obj/item/reagent_containers/food/snacks/cracker/
@@ -50,7 +50,6 @@
response_disarm = "gently moves aside"
response_harm = "swats"
stop_automated_movement = 1
universal_speak = 1
canbrush = TRUE
flying = TRUE
@@ -25,9 +25,8 @@
max_tox = 0
speed = -1
stop_automated_movement = 1
status_flags = 0
faction = "cult"
status_flags = CANPUSH
faction = "cult"
hunger_enabled = 0
appearance_flags = NO_CLIENT_COLOR|KEEP_TOGETHER
var/obj/item/residue = /obj/item/ectoplasm
+2 -4
View File
@@ -131,12 +131,10 @@
body_part = FOOT_RIGHT
icon_position = RIGHT
parent_organ = BP_R_LEG
joint = "right ankle"
amputation_point = "right ankle"
limb_flags = ORGAN_CAN_MAIM | ORGAN_CAN_AMPUTATE | ORGAN_CAN_STAND
dislocated = -1
joint = "structural ligament"
amputation_point = "branch"
limb_flags = ORGAN_CAN_MAIM | ORGAN_CAN_AMPUTATE | ORGAN_CAN_STAND
dislocated = -1
/obj/item/organ/external/hand/diona
name = "left grasper"
@@ -91,7 +91,6 @@
knife_x_offset = 23
knife_y_offset = 13
fire_delay = 25
w_class = ITEMSIZE_LARGE
accuracy = -3
scoped_accuracy = 4
@@ -452,11 +452,10 @@
item_state = "l6closedmag"
w_class = ITEMSIZE_LARGE
force = 10
slot_flags = 0
slot_flags = SLOT_BACK
max_shells = 50
caliber = "a762"
origin_tech = list(TECH_COMBAT = 6, TECH_MATERIAL = 1, TECH_ILLEGAL = 2)
slot_flags = SLOT_BACK
ammo_type = "/obj/item/ammo_casing/a762"
allowed_magazines = list(/obj/item/ammo_magazine/a762)
fire_sound = 'sound/weapons/gunshot/gunshot_saw.ogg'
@@ -562,9 +561,6 @@
is_wieldable = TRUE
can_bayonet = TRUE
magazine_type = /obj/item/ammo_magazine/c762/dpra
allowed_magazines = list(/obj/item/ammo_magazine/c762/dpra)
@@ -639,7 +635,6 @@
suppressor_y_offset = null
handle_casings = DELETE_CASINGS
max_shells = 30
allowed_magazines = list(/obj/item/ammo_magazine/submachinemag/assassin)
/obj/item/gun/projectile/automatic/tommygun/assassin/update_icon()
..()
@@ -46,7 +46,6 @@
desc = "A small gas-powered dartgun, capable of delivering chemical cocktails swiftly across short distances."
icon = 'icons/obj/guns/dartgun.dmi'
icon_state = "dartgun-empty"
icon_state = "dartgun-empty"
caliber = "dart"
fire_sound = 'sound/weapons/click.ogg'
fire_sound_text = "a metallic click"
@@ -329,7 +329,7 @@
name = "gauss thumper"
desc = "An outdated gauss weapon which sees sparing use in modern times."
w_class = ITEMSIZE_NORMAL
slot_flags = 0
slot_flags = SLOT_BACK
magazine_type = /obj/item/ammo_magazine/gauss
allowed_magazines = list(/obj/item/ammo_magazine/gauss)
icon = 'icons/obj/guns/gauss_thumper.dmi'
@@ -342,7 +342,6 @@
handle_casings = DELETE_CASINGS
force = 15
slot_flags = SLOT_BACK
can_bayonet = TRUE
knife_x_offset = 23
knife_y_offset = 13
@@ -588,6 +588,5 @@
reagent_state = SOLID
color = "#DCDCDC"
taste_mult = 0 //no taste
fallback_specific_heat = 18
fallback_specific_heat = 0.859
@@ -3375,7 +3375,6 @@
taste_description = "orange peel"
color = "#fc782b"
strength = 12
taste_description = "orange peel"
glass_icon_state = "glass_orange"
glass_name = "glass of triple sec"
@@ -5596,7 +5595,6 @@
glass_icon_state = "darmadhirbrew_glass"
glass_name = "glass of Darmadhir Brew"
description = "A rare and expensive brand of nm'shaan liquor."
/singleton/reagent/alcohol/treebark_firewater
name = "Tree-Bark Firewater"
@@ -6044,7 +6042,6 @@
description = "A delicious seasonal flavoring."
color = "#AE771C"
taste_description = "autumn bliss"
condiment_name = "bottle of pumpkin spice"
condiment_name = "Pumpkin Spice"
condiment_desc = "Every teenager's favorite seasonal ingredient."
condiment_icon_state = "pumpkinspice"
@@ -6436,7 +6433,6 @@
glass_icon_state = "pulque_dyn"
glass_name = "dyn pulque"
description = "A traditional Mictlanian drink made from fermented sap of maguey. This one is dyn flavored."
/singleton/reagent/alcohol/pulque/banana
name = "Banana Pulque"
@@ -6446,7 +6442,6 @@
glass_icon_state = "pulque_banana"
glass_name = "banana pulque"
description = "A traditional Mictlanian drink made from fermented sap of maguey. This one is banana flavored."
/singleton/reagent/alcohol/pulque/berry
name = "Berry Pulque"
@@ -6456,7 +6451,6 @@
glass_icon_state = "pulque_berry"
glass_name = "berry pulque"
description = "A traditional Mictlanian drink made from fermented sap of maguey. This one is berry flavored."
/singleton/reagent/alcohol/pulque/coffee
name = "Coffee Pulque"
@@ -6466,7 +6460,6 @@
glass_icon_state = "pulque_coffee"
glass_name = "coffee pulque"
description = "A traditional Mictlanian drink made from fermented sap of maguey. This one is coffee flavored."
/singleton/reagent/drink/jyalra
name = "Jyalra"
@@ -384,12 +384,11 @@
color = "#5c4033"
overdose = 10
od_minimum_dose = 2
specific_heat = 1
specific_heat = 1.2
scannable = TRUE
metabolism = REM / 3.33 // 0.06ish units per tick
ingest_met = REM / 1.5 // Should be 0.13 units per tick
breathe_met = REM * 4 // .8 units per tick
specific_heat = 1.2
/singleton/reagent/morphine/affect_blood(var/mob/living/carbon/M, var/alien, var/removed, var/datum/reagents/holder)
var/list/joy_messages = list("You feel soothed and at ease.", "You feel content and at peace.", "You feel a pleasant emptiness.", "You feel like sharing the wonderful memories and feelings you're experiencing.", "All your anxieties fade away.", "You feel like you're floating off the ground.", "You don't want this feeling to end.")
@@ -259,7 +259,6 @@
name = "getmore energy can"
desc = "An extremely ill-advised combination of excessive caffeine and alcohol. Getmore's most controversial product to date!"
icon_state = "thirteen_loko"
icon_state = "thirteen_loko"
center_of_mass = list("x"=16, "y"=10)
reagents_to_add = list(/singleton/reagent/alcohol/thirteenloko = 30)
@@ -789,8 +789,8 @@
name = "Boryeong '45 soju"
desc = "A rice-based liquor commonly consumed by the non-synthetic residents of Konyang. This particular brand originates from the city of Boreyeong, on Konyang."
desc_extended = "While most commonly associated with Konyang, soju can be found throughout the Sol Alliance thanks to the inexpensive cost of producing it and a successful \
marketing campaign carried out during the robotics boom on Konyang. It is traditionally consumed neat, or without mixing any other liquids into it. The '45 in this brand's \
name refers to its alcohol by volume content, and not a calendar year."
marketing campaign carried out during the robotics boom on Konyang. It is traditionally consumed neat, or without mixing any other liquids into it. The '45 in this brand's name \
refers to its alcohol by volume content, and not a calendar year."
icon_state = "sojubottle"
center_of_mass = list("x"=16, "y"=4)
reagents_to_add = list(/singleton/reagent/alcohol/soju = 100)
@@ -289,7 +289,6 @@
center_of_mass = list("x"=16, "y"=10)
reagents_to_add = list(/singleton/reagent/nutriment = 5)
reagent_data = list(/singleton/reagent/nutriment = list("poppy seeds" = 2, "pretzel" = 3))
bitesize = 2
/obj/item/reagent_containers/food/snacks/bagel
name = "bagel"
@@ -61,7 +61,6 @@
filling_color = "#ffeb94"
reagents_to_add = list(/singleton/reagent/nutriment = 3, /singleton/reagent/nutriment/gelatin = 5)
reagent_data = list(/singleton/reagent/nutriment = list("pineapple sorbet" = 5, "cherry jello" = 5))
trash = /obj/item/trash/snack_bowl
bitesize = 2
/obj/item/reagent_containers/food/snacks/floatingisland/update_icon()
@@ -15,7 +15,6 @@
possible_transfer_amounts = null
atom_flags = ATOM_FLAG_OPEN_CONTAINER
slot_flags = SLOT_BELT
center_of_mass = null
var/name_label
var/spent = FALSE
matter = list(MATERIAL_GLASS = 400, DEFAULT_WALL_MATERIAL = 200)
@@ -1,11 +1,10 @@
/spell/radiant_aura
name = "Radiant Aura"
desc = "Form a protective layer of light around you, making you immune to laser fire."
school = "transmutation"
school = "conjuration"
feedback = "ra"
invocation_type = SpI_EMOTE
invocation = "conjures a sphere of fire around themselves."
school = "conjuration"
charge_max = 300
cooldown_min = 200
level_max = list(Sp_TOTAL = 2, Sp_SPEED = 2, Sp_POWER = 0)
-1
View File
@@ -409,7 +409,6 @@
icon_state = "snow_on"
bike_icon = "snow"
land_speed = 2
land_speed = 4
protection_percent = 10
can_hover = FALSE