mirror of
https://github.com/Aurorastation/Aurora.3.git
synced 2026-08-21 12:02:31 +01:00
Water Hard Del Fix (#22210)
Small mistake that makes fire extinguishers cause a hard delete. Water effects were nulling the effect reagents before calling their parent, but then their parent attempts to QDEL_NULL(reagents) a reference that it can no longer correctly cleanup. The simple solution was to get rid of the Destroy() override on effect/water since it wasn't needed.
This commit is contained in:
@@ -9,9 +9,6 @@
|
||||
. = ..()
|
||||
QDEL_IN(src, 15 SECONDS) // In case whatever made it forgets to delete it
|
||||
|
||||
/obj/effect/effect/water/Destroy()
|
||||
reagents = null
|
||||
return ..()
|
||||
|
||||
/obj/effect/effect/water/proc/set_color() // Call it after you move reagents to it
|
||||
if(!reagents)
|
||||
|
||||
@@ -0,0 +1,4 @@
|
||||
author: Hellfirejag
|
||||
delete-after: True
|
||||
changes:
|
||||
- bugfix: "Fixed a hard delete in water effects."
|
||||
Reference in New Issue
Block a user