Water Hard Del Fix (#22210)

Small mistake that makes fire extinguishers cause a hard delete. Water
effects were nulling the effect reagents before calling their parent,
but then their parent attempts to QDEL_NULL(reagents) a reference that
it can no longer correctly cleanup. The simple solution was to get rid
of the Destroy() override on effect/water since it wasn't needed.
This commit is contained in:
VMSolidus
2026-04-12 22:19:13 +00:00
committed by GitHub
parent ba9f358d65
commit aeee6aa3ef
2 changed files with 4 additions and 3 deletions
-3
View File
@@ -9,9 +9,6 @@
. = ..()
QDEL_IN(src, 15 SECONDS) // In case whatever made it forgets to delete it
/obj/effect/effect/water/Destroy()
reagents = null
return ..()
/obj/effect/effect/water/proc/set_color() // Call it after you move reagents to it
if(!reagents)