cyberpresidentvanellope/Aurora.3
1
0
Fork 0
mirror of https://github.com/Aurorastation/Aurora.3.git synced 2026-08-27 06:54:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

Update contributing guidelines to reflect recent changes to the peer review system. (#12727)

Browse Source 
Co-authored-by: Werner <Arrow768@users.noreply.github.com>
This commit is contained in:
Werner
2021-11-07 21:28:03 +01:00
committed by GitHub
co-authored by Werner
parent b88684d593
commit afea1a74c9
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/CONTRIBUTING.md
+6 -4
View File
@@ -46,11 +46,13 @@ license permits the intended use of the content in the appropriate manner.
All pull requests are subject to peer review prior to being merged. After said reviews, they are given a final once-over by a maintainer and
then merged if good.
A **feature** pull request will require *two* reviews, with one of them being a community developer's. There is also a minimum time out of
*three days* before a feature pull request can be merged. This is to ensure that there is enough time to review and discuss new additions
from the game.
A **feature** pull request will require **two** reviews, with one of them being a community developer's.
The other review can come from a "trusted reviewer" or a developer.
Contributors who have shown that they are capable of properly reviewing pull requests can request the "trusted reviewer" role.
There is also a minimum time-out of **three days** before a feature pull request can be merged.
This is to ensure that there is enough time to review and discuss new additionsfrom the game.
A **bug fix** pull request will require *two* reviews, if it is to be merged in the first 24 hours, or *one* following the first 24 hours.
A **bug fix** pull request will require **two** reviews, if it is to be merged in the first 24 hours, or **one** following the first 24 hours.
### Prefer Atomic Pull-Requests
Pull requests should do **one** thing.