The last time the Light Sensitivity code was changed, I remarked in a
review that "This should probably be a component so that its code isn't
being run on every mob forever". Well I've gotten around to doing that
myself, except I figured out it's even better off as an Element in this
situation rather than a Component. So this is now my first time adding
Elements to the repo. It turns out they're really awesome when paired
with signals.
This PR removes the hardcoded check for the light senstivity and dark
phobia traits from the Life() path, replacing them instead with two
Elements which hook into the pre-existing signal used to handle vision
updates for human mobs. I've mainly done this to help cut down on the
overwhelmingly high cost of the Life() codepath, which is currently one
of the most expensive paths we have.
While I was at it with refactoring these two, I noticed that there
wasn't a trait selection for either of them, so I added selections for
both traits to the disabilities tab so that players can opt-in to being
light sensitive or afraid of the dark!
<img width="318" height="336" alt="image"
src="https://github.com/user-attachments/assets/a1e60e83-d899-44df-8ea3-0cd5a87c231c"
/>
# Summary
This PR updates the default behavior of airlocks on powerloss and adds a
manual override for them.
By default airlocks now keep closed (and close if opened) on powerloss.
Additionally a new mechanic has been added allowing people to manually
open unpowered, unbolted and unsecure airlocks without power by
utilizing a manual override.
## Mechanics
- On power loss doors will stay closed.
- On power loss opened doors will now close.
- Manual override mechanic:
If a door is functional but unpowered and features an override handle
(previously called "insecure" by default, false for vaults and similar)
the user can now engage the manual override. It works by cranking a
hydraulic lever multiple times to force open the door without a crowbar,
this process takes around 15 seconds. The process is divided into
3-second steps each given a ratchet sound. When user waits long enough
the door will open. Doors that have been opened with the manual override
will automatically close again after the door receives power again, just
like the old behavior. While waiting the user will be informed about the
length of the process by seeing a small oil gauge fill up (via chat
message).
Process:
- User clicked unpowered door
- 3 second action (including a ratchet sound) x 5
- Every action feedback is given:
<img width="784" height="169" alt="image"
src="https://github.com/user-attachments/assets/4cf940bb-458b-4bce-8893-3cd96b5b2455"
/>
<hr>
Idea originated from: [Forum
thread](https://forums.aurorastation.org/topic/22728-airlocks-opening-on-powerloss/#findComment-182862)
## Changes
- Renamed `insecure` airlock feature to
`features_powerloss_manual_override`.
- Adjusted default powerloss behavior to close instead to open, if not
already closed.
- Added manual override feature.
- Update all `insecure = FALSE` references to
`features_powerloss_manual_override = FALSE` (vaults and similar
locations).
- Fixed a CI issue with a `RegisterSignal`.
Part one of our nefarious plans to destroy lag forever, and also
accomplish some cool shit.
This replaces our renderer system with plane masters, this will also be
used to turn skyboxes into backdrops and thus totally remove skybox
updating lag. Additionally, this will let us manipulate entire planes
very easily to do all sorts of zany shit. All credit goes to the
original coders, this is some seriously cool stuff.
Also fixes some bizarre smoothing behaviour, reduces updateoverlays
calls since now not every single structure in the game tries smoothing
with nothing.
<img width="1349" height="1349" alt="image"
src="https://github.com/user-attachments/assets/9b7cecd7-3c47-448b-9dd8-9b904640bf82"
/>
<img width="1349" height="1349" alt="image"
src="https://github.com/user-attachments/assets/647d75a2-1bff-45ca-ab92-0aea10631afd"
/>
---------
Co-authored-by: Matt Atlas <liermattia@gmail.com>
Refactored hitby to be in line with TG's version.
Refactored item weight defines to a more clear naming scheme, also in
line with TG's version.
Refactored how the movement bumps are handled, ported signals to handle
them, in preparation for the movement update.
Fixed disposal hit bouncing the hitting atom on the wall.
Items do not push other items anymore if they are tiny.
* autolathe 1
* FUCK MY LIFE
* more fixes
* autolathe queueing
* cl
* garbage collection
* wire fixes
* some final tweaks
* on second thought this might be annoying
* fix that
* whoopsies
* that didn't work for shit
---------
Co-authored-by: Matt Atlas <liermattia@gmail.com>
* Update the codebase to 515.
* edit that
* WHOOPS
* maor
* maybe works
* libcall and shit
* do that too
* remove that
* auxtools isnt updated so get rid of it
* actually remove auxtools lol
Co-authored-by: Matt Atlas <liermattia@gmail.com>
The components port #8890 only partially implemented a later tg PR #49098 suggested by ninjanomnom here. Missing an important part that affected elements. The result of that was that it wasn't possible to pass any arguments other than the element datum to AddElement().
This PR adds the missing bit, which are the changes in the linked PR here and makes passing arguments to elements work properly.
And another unrelated missing bit that doesn't affect anything (yet)
VMSolidus