Per unathi lore's request.
Unathi can now eat nutriments, but it has half efficiency, while protein
was upgraded to double efficiency.
They can now also drink ethanol with no issues. Note they had an
existing ethanol weakness making them 20% more vulnerable to it compared
to humans.
## About PR
- Materials no longer cache pre-coloured icons, instead this is handled
by color var. This will allow mappers to colour walls more conveniently
without resorting to code crimes
- Clears some repetitive checks in the wall code
- Adds RESET_COLOR flag to some wall overlays, so they don't inherit the
walls' color
Tested the init time with and without the changes on horizon map several
times, with away sites disabled. There's no change in speed
There's about ~5500 processing entries in the Machinery subsystem, at
any given point showers are about 50 of them. This PR just makes it so
that showers that aren't on automatically remove themselves from
processing to free up time for the machinery subsystem.
* Mining point balances are now loaded only when interacting with mining
machinery or transferring a mining point card, preventing unrelated ID
cards from querying mining point history.
* Claiming zero mining points no longer creates a persistent balance
record.
AI usage disclosure: Code committed by myself were generated using GPT
5.6 Sol.
This adds a takeout box that can be crafted from cardboard and found in
the kitchen dinnerware vending machine.
Food (made and grown) can be put into it as well as liquid reagents to
create a meal. It cannot be taken out once put in it.
When all food in it has been eaten, it is turned into a trash item.
The box itself can be eaten from with any utensil and can be opened and
closed with alt-click or using it in-hand.
<img width="210" height="160" alt="dreamseeker_RghC7jk3th"
src="https://github.com/user-attachments/assets/92f7c4a0-f02d-496d-8fd8-ed783c6daa49"
/>
### Asset Licenses
The following assets that **have not** been created by myself are
included in this PR:
- Takeout boxes
| Path | Original Author | License |
| --- | --- | --- |
| icons/obj/kitchen.dmi | Tomixcomics (Aurora Station) | CC-BY |
Reduces decloner damage so it falls just under the threshold to give a
tumor, on all but the most powerful guns.
Tumors from genetic damage are now also a chance, rather than guaranteed
at any genetic damage over 10.
You are guaranteed to have at least one tumor if your limb reaches
maximum genetic damage.
Resolves a lot of broken exterior lighting in a few offsites/offships,
inclusive of the Xanu Frigate and Ranger Corvette. Adds a few missing
entry points to the Xanu Frigate so its gunnery nacelles can be shot
from the fore.
As title. I'm not sure why this was set to the layer it was, but it
meant any shutters lowered over airlocks - such as those in both
holodecks - were effectively invisible.
* Please describe the intent of your changes in a clear fashion.
This PR addresses the `Cannot read null.stat_panel` error occurring in
`SSstatpanels/fire()`.
**Root Cause:**
The primary cause was a race condition during client login. A `client`
object was added to `GLOB.clients` in `client/Login()` before its
`stat_panel` member had been fully initialized. This allowed the
`SSstatpanels/fire()` subsystem, which iterates over `GLOB.clients`, to
attempt to access `target.stat_panel.is_ready()` on a `null`
`stat_panel`, leading to a runtime error. Recent changes increasing the
frequency of `stat_panel` updates exacerbated this issue.
**Solution:**
1. **Reordered Client Initialization:** In
`code/modules/client/client_procs.dm`, the line `GLOB.clients += src`
has been moved to occur *after* `stat_panel = new(src, "statbrowser")`
and `stat_panel.subscribe(...)`. This ensures that a client is only
added to the global list once its `stat_panel` is properly instantiated,
eliminating the race condition.
2. **Defensive Null Checks:** Additional null checks for `stat_panel`
have been added in `code/controllers/subsystems/statpanel.dm`:
* In `fire()`, the condition `!target.stat_panel.is_ready()` was updated
to `!target.stat_panel || !target.stat_panel.is_ready()`.
* In `refresh_client_obj_view()`, an early return
`if(!refresh.stat_panel) return` was added.
These defensive checks provide robustness against any future reordering
issues or unexpected scenarios where `stat_panel` might be null.
* Please make sure that, in the case of mapping changes, you include
images of these changes in the PR's description.
* Please make sure to mark your PR as wip or review required by making a
comment with !wip or !review required
* If you include sprites/sounds/... (assets) that you have not created
yourself specify the license and original author below.
* Ensure that you also credit them in the appropriate location /
changelog as specified in the contributor guidelines
### Asset Licenses
The following assets that **have not** been created by myself are
included in this PR:
| Path | Original Author | License |
| --- | --- | --- |
| icons/example.dmi | ExamplePerson (Example Station) | CC0 |
Fixes
[SERVER-PROD-1M4](https://aurorastation.sentry.io/issues/7547575486/?seerDrawer=true)
---------
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
* Please describe the intent of your changes in a clear fashion.
This PR addresses a runtime error occurring in `mob/proc/LateLogin()`
when `machine.on_user_login(src)` is called. The error happened when the
`machine` variable on a mob was unexpectedly set to a
`/mob/abstract/ghost/observer` (instead of an `/obj`), typically during
the shared dreaming (Srom) wakeup process.
The `on_user_login()` proc is defined on `/obj` but not on `/mob` types.
The fix adds a type check `isobj(machine)` before attempting to call
`machine.on_user_login(src)` in `code/modules/mob/login.dm`, ensuring
the proc is only invoked when `machine` is indeed an object, thus
preventing the 'undefined proc or verb' runtime.
* Please make sure that, in the case of mapping changes, you include
images of these changes in the PR's description.
* Please make sure to mark your PR as wip or review required by making a
comment with !wip or !review required
* If you include sprites/sounds/... (assets) that you have not created
yourself specify the license and original author below.
* Ensure that you also credit them in the appropriate location /
changelog as specified in the contributor guidelines
### Asset Licenses
The following assets that **have not** been created by myself are
included in this PR:
| Path | Original Author | License |
| --- | --- | --- |
| icons/example.dmi | ExamplePerson (Example Station) | CC0 |
Fixes
[SERVER-PROD-2SZ](https://aurorastation.sentry.io/issues/7666863585/?seerDrawer=true)
---------
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
This PR refactors get_pain() to be essentially performance free.
Previously it was a member of the top 5 most expensive procs.
I had to touch a metric shitton of files to make this happen. Notably
get_pain() was also 1/3rd of the entire processing cost for Mobs - Life
* Welding arcs now damage the eyes of visible onlookers within two tiles
who are facing the welder and are not wearing eye protection.
AI usage disclosure: The code for this was created in-part using GPT 5.6
Sol.
* Fixed tails layering oddly in character preview, holograms, photos,
etc.
AI usage disclosure: The code for this was created using GPT 5.6 Sol.
The sprite edits were all done by myself, manually.
Adds the missing [!] to the gravity anomoly overmap icon and a new
psiren overmap icon, so they no longer share an icon with carp.
---------
Signed-off-by: Fyni <itsfyni@gmail.com>
Removes extra grate right above the GTR decal
Fixes broken vent right above the roller bed rack
Removes the medical sign from the recovery room
pharm requests console is no longer mounted on a window in the pharmacy
re-adds a bag of SBS to OR supplies
moves med lobby water cooler to a less weird spot
fixes the fences at the pharmacy desk queue
adds more light to ICU
adds a ringer button to outside of ICU
adds a button to toggle door bolts on the ICU airlock
---------
Signed-off-by: ASmallCuteCat <neofelisnebulosa128@gmail.com>
Co-authored-by: SleepyGemmy <99297919+SleepyGemmy@users.noreply.github.com>
makes `/obj/effect/map_effect/marker/airlock` into `ABSTRACT_TYPE()`
for better organization and stuff
adds:
```
/// External airlock marker, for non-docking non-shuttle airlocks.
/// Just a plain external access airlock.
/obj/effect/map_effect/marker/airlock/external
```
---------
Co-authored-by: DreamySkrell <>
Any ion currently oneshots a mech, by draining it's power cell to zero.
The amount of cell power drained is now random, up to the max charge of
the cell for a heavy EMP.
Up to half the max charge of the cell for a light EMP.
This PR makes EMPs respect energy armour, as the description of energy
armour says they should.
Energy armour is averaged across the mob, weighted for limb size.
This is then the chance to downgrade the EMP.
A heavy EMP can be downgraded into a light EMP, but no further.
A light EMP can either be negated completely, or only affect the mob's
contents.
Eg. A human wearing Ablative armour, (Energy 40), gives a 33% chance to
downgrade a heavy EMP to a light, as it leaves the hands and feet
uncovered.
The same mob struck by a light EMP has a 33% chance to have the EMP only
affect it and not it's contents (internal organs), if that is
successful, there is a further 33% chance to negate the EMP completely.
This means a mech with EM armour is guaranteed to downgrade a heavy EMP
to light, and to ignore light EMPs completely.
All other types of mech armour have Energy 10.
Almost all EMPs are heavy, with the edge of EMP grenades being the only
source of a light EMP.
Ion rifles EMP the target twice, 8 heavy EMP's downgraded to light, will
still seriously damage an unpowered EM armoured mech.
---------
Signed-off-by: FenodyreeAv <fenodyree.av@gmail.com>
* Please describe the intent of your changes in a clear fashion.
Addresses a "list index out of bounds" error occurring in
`obj/item/ammo_pile/proc/remove_ammo` when
`obj/item/ammo_pile/proc/scatter()` was called.
The root cause was a race condition where `scatter()` iterated over the
`ammo` list and called `remove_ammo()` for each item. `remove_ammo()` in
turn called `check_ammo()`, which would `qdel(src)` (and thus empty the
`ammo` list) when only one round remained. This left `scatter()` to
continue its loop and call `remove_ammo()` on an already empty list,
leading to the crash.
The fix rewrites `scatter()` to directly handle the unregistering of
signals, force-moving, and throwing of each bullet. After all bullets
have been processed, the `ammo` list is cleared, overlays are cut, and
the pile is `qdel`'d. This avoids the problematic mid-loop calls to
`remove_ammo()` and `check_ammo()`, preventing the list index out of
bounds error.
* Please make sure that, in the case of mapping changes, you include
images of these changes in the PR's description.
* Please make sure to mark your PR as wip or review required by making a
comment with !wip or !review required
* If you include sprites/sounds/... (assets) that you have not created
yourself specify the license and original author below.
* Ensure that you also credit them in the appropriate location /
changelog as specified in the contributor guidelines
### Asset Licenses
The following assets that **have not** been created by myself are
included in this PR:
| Path | Original Author | License |
| --- | --- | --- |
| icons/example.dmi | ExamplePerson (Example Station) | CC0 |
Fixes
[SERVER-PROD-3N](https://aurorastation.sentry.io/issues/7405041136/?seerDrawer=true)
---------
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
* Please describe the intent of your changes in a clear fashion.
This PR addresses a crash (`SERVER-PROD-2R6`) caused by a temperature
mismatch when adding new reagents, particularly in low-volume metabolism
holders.
The root cause was identified as a combination of:
1. A coarse rounding guard in `set_thermal_energy` that discarded
small-but-valid thermal energy changes.
2. A temperature assertion in `add_reagent` that was too sensitive to
floating-point inaccuracies.
3. The `nicotine` reagent lacking an explicit `fallback_specific_heat`.
Changes implemented:
- **`code/modules/reagents/Chemistry-Temperature.dm`**: Modified
`set_thermal_energy` to remove the `round(delta, 1)` guard. Now,
`if(!delta)` is used, allowing small, non-zero energy changes to be
processed.
- **`code/modules/reagents/Chemistry-Holder.dm`**: Updated the
temperature assertion in `add_reagent` from `round(temperature, 1) !=
round(get_temperature(), 1)` to `abs(temperature - get_temperature()) >
0.1`. This provides a more robust, tolerance-based comparison.
-
**`code/modules/reagents/Chemistry-Reagents/Chemistry-Reagents-Medicine.dm`**:
Added `fallback_specific_heat = 1.67` to
`/singleton/reagent/mental/nicotine` to ensure it has a proper specific
heat value.
* Please make sure that, in the case of mapping changes, you include
images of these changes in the PR's description.
* Please make sure to mark your PR as wip or review required by making a
comment with !wip or !review required
* If you include sprites/sounds/... (assets) that you have not created
yourself specify the license and original author below.
* Ensure that you also credit them in the appropriate location /
changelog as specified in the contributor guidelines
### Asset Licenses
The following assets that **have not** been created by myself are
included in this PR:
| Path | Original Author | License |
| --- | --- | --- |
| icons/example.dmi | ExamplePerson (Example Station) | CC0 |
Fixes
[SERVER-PROD-2R6](https://aurorastation.sentry.io/issues/7661064998/?seerDrawer=true)
---------
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
* Please describe the intent of your changes in a clear fashion.
This PR addresses issue SERVER-PROD-12K by correcting a hard delete
warning related to `/mob/living/simple_animal/hostile/carp` during the
carp migration event.
Previously, in `code/modules/events/carp_migration.dm`, the `end()` proc
was calling `qdel(carp_weakref)` instead of `qdel(fish)`. This meant the
weakref datum was being deleted, but the actual carp mob was left
without a proper `qdel()` call, leading to BYOND's garbage collector
performing a 'hard delete' and logging a warning.
The fix changes `qdel(carp_weakref)` to `qdel(fish)` on line 103,
ensuring the carp mob is correctly soft-deleted when the event ends.
* Please make sure that, in the case of mapping changes, you include
images of these changes in the PR's description.
(No mapping changes in this PR)
* Please make sure to mark your PR as wip or review required by making a
comment with !wip or !review required
* If you include sprites/sounds/... (assets) that you have not created
yourself specify the license and original author below.
* Ensure that you also credit them in the appropriate location /
changelog as specified in the contributor guidelines
### Asset Licenses
The following assets that **have not** been created by myself are
included in this PR:
| Path | Original Author | License |
| --- | --- | --- |
| icons/example.dmi | ExamplePerson (Example Station) | CC0 |
(No new assets included in this PR)
Fixes
[SERVER-PROD-12K](https://aurorastation.sentry.io/issues/7522667244/?seerDrawer=true)
---------
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
## About PR
Makes it so when a turf calls the overlay subsystem (if overlay layer
was left as default) it'll add overlays slightly above the turf layer.
With this we'll no longer have the silly issue where turf smoothing
overlays appear under the adjacent turfs depending on turf load order
In short, here's what it fixes
Before:
<img width="396" height="601" alt="Screenshot_10"
src="https://github.com/user-attachments/assets/91708402-c6c6-433f-af9f-5293ce926731"
/>
After:
<img width="391" height="598" alt="Screenshot_9"
src="https://github.com/user-attachments/assets/556d48dd-d463-4f76-b075-f0d77340e837"
/>
---
to-do:
- [x] Figure out whether to change `is_plating()` check method or add
the missing `initial_flooring` for every exoplanet turf type since this
plays a role in deciding decal layer, suffer as both paths are equally
agonizing
* Please describe the intent of your changes in a clear fashion.
The `die()` proc for the positronic brain
(`/obj/item/organ/internal/machine/posibrain/die()`) was attempting to
transfer `owner.mind` to `stored_mmi.brainmob` without first checking if
`owner.mind` was null. This led to a runtime error (`Cannot execute
null.transfer to().`) when the IPC mob was mindless (e.g., an NPC, a
disconnected player, or if the mind had already been transferred).
This change adds a null-check (`if(owner.mind)`) around the
`transfer_to()` call in `die()` at line 103 of `posibrain.dm`. This
prevents the error by ensuring the transfer only occurs when a mind
object actually exists, mirroring the safe pattern already present in
the `removed()` proc.
* Please make sure that, in the case of mapping changes, you include
images of these changes in the PR's description.
* Please make sure to mark your PR as wip or review required by making a
comment with !wip or !review required
* If you include sprites/sounds/... (assets) that you have not created
yourself specify the license and original author below.
* Ensure that you also credit them in the appropriate location /
changelog as specified in the contributor guidelines
### Asset Licenses
The following assets that **have not** been created by myself are
included in this PR:
| Path | Original Author | License |
| --- | --- | --- |
| icons/example.dmi | ExamplePerson (Example Station) | CC0 |
Fixes
[SERVER-PROD-RG](https://aurorastation.sentry.io/issues/7496141971/?seerDrawer=true)
---------
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
Changelogs