Commit Graph

14353 Commits

Author SHA1 Message Date
Alberyk
4dcfa0d9fa Fix manhacks attacking traitors, pirates and mercenaries (#2268)
This should fix manhacks attacking traitors, heisters and mercenaries, and yes this was tested.
Also fix ipcs being able to repair themselves with cable coil.
2017-05-14 23:40:19 +03:00
Alberyk
9bdd1c81b7 Custom Items 14/05 (#2266)
Adds the following items:

-Null Staff - Kesaos Azaroz - paradoxspace
2017-05-14 20:39:30 +03:00
Ron
9543d5628b Bug fixes (#2109, #1437, and AI Slipper) (#2227)
Fixes #2109
Fixes #1437
2017-05-14 13:34:10 +03:00
Alberyk
2e2a92b39a Fix airlock related hallucination affecting ipcs and dionae (#2261)
This may fix dionae and ipcs touching airlocks while suffering from sm's hallucination, SOMEHOW, and being "shocked" by them.
2017-05-14 13:22:02 +03:00
Alberyk
462f428d5c Fix package wrapper not copying the original item size (#2197)
This will stop all dirty powergamers from using this to stuff shit they should be able to into bags.
2017-05-11 16:41:47 +03:00
Alberyk
f02ceaf570 Fix more click cooldown issues (#2184)
Fix all the issues related with shred behavior and lack of click cooldow, such as hitting cameras, apcs and windowdoors
And fixes #2085
2017-05-06 19:31:10 +03:00
Lohikar
df9394af4f Fix cameras again (#2140)
changes:

Fixed a bug where pictures from cameras would be black if the player clicked on something that was not a turf.
2017-05-01 19:30:28 +03:00
LordFowl
28edd6fe33 Adds surgery: Lobotomies (Cake's request) (#2128)
As per Cake's looser instructions, MMI's will require a lobotomized brain to function. Instead of having the MMI automagically lobotomize a brain, I decided instead to make it a surgical operation and a prerequisite to borging. This also cleans up some snowflake istype() checks by instituting two new variables.

Cortical stacks, slime brains, and golem brains cannot be lobotomized, and as such cannot be put into an MMI.

You can lobotomize a person either by surgical-drilling their brain in surgery, or by surgical-drilling their removed brain.

The roboticist now spawns with a drill to accomodate this change. Surgical drills are not really useful otherwise, so I don't think this is a huge upset of the surgery balance.

Lobotomy will send the following message to the lobotomee;
"You have been lobotomized. Your memories and your former life have been surgically removed from your brain, and while you are lobotomized you remember nothing that ever came before this moment."
2017-04-29 01:29:23 +03:00
Lohikar
5d7c6748e2 Minor fox/corgi fixes (#2133)
changes:

Foxes now have their real_name set properly, preventing them from showing as fox (corgi) to ghosts.
Tweaked the grammar of fox & corgi autospeak slightly.
2017-04-29 00:03:45 +03:00
skull132
77c7e23ebe Port initial Bay12 object listener fix (#2106)
Port of Baystation12/Baystation12#13264

Large PR to put into Master, but the bug is really annoying and since it affect a traitor item, an often used one, I'll take the risk.

Fixes #1956
Fixes explosives implants and lawgiver not working.
2017-04-19 10:15:19 +03:00
skull132
e54af87ebf Fixes #1822 (#2110)
I should make this more robust. Fuck.
2017-04-17 14:25:29 +03:00
Lohikar
ce8cee4cbd Kill some debug spam (#2095)
changes:

Killed some debug statements that aren't needed anymore.
2017-04-16 20:14:39 +03:00
Lohikar
2ed8a41d79 Fix wallhack cameras (#2093)
changes:

Fixed cameras' visibility calculations.
Possibly made cameras slightly faster.
2017-04-14 21:50:49 +03:00
MarinaGryphon
bf6002605e No More Psyborgs (Fixes #2077, adds Industrial Frame functionality requested by Cake) (#2090)
Stopped IPCs from being able to see without optics installed.
Made Industrial Frames actually pressure-proof, which allows them to use suit coolers on their back.
(Apologies for accidentally including some old commits. They've already been merged, anyway, so I hope it's not too much trouble.)
2017-04-14 19:05:12 +03:00
skull132
a3516d7069 Fix/debug BOREALIS (#2086)
Improved the .dll to catch any and all unspecified exceptions. To avoid .dll crashing. They will now be logged into a .txt file.
Made the .dll's code to be more reusable, and look a bit better. Also removed a few hidden files (header).
Added a few debug logs for BOREALIS, specifically towards new features.
Removed a potential runtime error for scheduling a push without a scheduler.
Tested as functional on local build.
2017-04-14 13:29:21 +03:00
Lohikar
f35680ba7a Fix cameras (#2091)
changes:

Cameras now use DVIEW instead of a temporary dummy mob to calculate visibility.
Cameras now render smooth lighting as old-style lights.
Lighting overlays are now a DMI instead of a PNG.
Fixes #1974.
2017-04-14 13:29:09 +03:00
Lohikar
0a1ee41460 Admin PM Fix (#2087)
Fixes an issue with admin PM logging.
2017-04-14 00:27:55 +03:00
NanakoAC
f09afbaeaa Cooking Fixes Pass 2 (#2024)
This PR is a package of fixes for a few cooking issues, and also (largely unrelated but its been annoying me for weeks) more fixing on the Flash issue.

Fixes the cooking sound not being set on cookers

Very thoroughly re-examines all interactions with cooking machines and their verbs, adds safety checks, alters contexts as intended. This gets rid of all the problems with mouse/ghost/AI fuckery.
Note that AIs can toggle the oven door and the power on cooking machines, this is by design.
Animals can remove food from exposed cooking containers, this is also by design.

Sets cooking containers to NOREACT, to prevent some issues with recipes being unmakeable because ingredients would become dough.

Tweaks oven heat loss a little more

Adjusts the mix flag on several potentially problematic recipes to prevent certain undesireable things ending up in finished products (like flour and eggs causing a lump of dough to be ejected from a finished cake)

Alters quite a few recipes which used a whole egg as an ingredient, to use egg yolk instead. Partly becase it makes more sense in context, and partly because cooking containers don't support adding whole eggs. There are now no fryer/oven recipes that need an intact egg.

Scales up plain bread to be a little closer to the other specialised breads in terms of reagent quantity.

Removes a redundant spellburger recipe because item checks use istype

And the flash issue:
For those who missed it, several months ago we had an issue with an object named "flash" appearing in the rightclick menu anywhere, for anyone with admin/dev powers. It was constantly annoying. After enduring the mysterious thing for months i found the cause, it's a hud element. Setting mouse opacity fixed it.

Anyways my fix wasn't comprehensive enough. Several other huds for non human mobs duplicate this thing. So ive set mouse opacity on them too
2017-04-13 23:31:32 +03:00
Lohikar
efc668fa89 RnD Deconstruction Fix (#2081)
changes:

Fixed a bug where the Circuit Imprinter & the Protolathe tried to new() a material name instead of the material's type on deconstruct. This fixes a runtime preventing deconstruction when the machine contained materials.
Fixes #2080.
2017-04-13 23:31:19 +03:00
MarinaGryphon
2cb9f18671 Hopefully fixed IPC surgery. (#2076)
IPC external organs are now encased, which means organ removal now checks for the proper open value (which is 3, not 2). This should fix #2020.
2017-04-12 21:15:39 +03:00
MarinaGryphon
fa3e74bdf8 Fixes #2069 (#2070)
Fixed #2069 by commenting out a statement that set new pAIs' canmove to zero.
2017-04-12 12:40:22 +03:00
Lohikar
3834fd9dec Darkness Fixes & Shell Tweaks (#2066)
changes:

ChangeTurf no longer breaks lighting when switching from statically lit turfs to dynamically lit turfs.
Human-types' is_noisy value is now updated on spawn; boots should now make footstep SFX without having to take them off and put them back on.
Fixed a logic error in is_noisy calculations which could have lead to false-negatives.
Shells can now wear socks & undershirts.
Fixed a bug where changing the dynamic lighting status on an area would attempt to build lighting overlays for the entire map.
Fixes #2027.
Fixes #1982.
2017-04-10 11:55:56 +03:00
Lohikar
c625bbe8e4 Nightmode Tweaks 2: The Fixening (#2065)
I actually fixed it this time I swear

changes:

Nightmode now follows the station's time instead of some random time schedule that made no sense.
Red alert will properly disable night mode now.
Dropping from red alert will reset nightmode to the state it was in before red alert was triggered.
2017-04-10 11:54:09 +03:00
Alberyk
5d025d9ac6 Mark of wizard fix and missing uniform name (#2062)
-unfucks the path of the mark of wizard
-fix the name i may have erased from two uniforms
2017-04-09 13:00:22 +03:00
NanakoAC
f9e7a071c1 Alcohol additions and fixes (#2052)
Project partially commissioned by Senpai Jackboot.

This PR adds a new reagent, butanol. It is an alcohol intended for unathi consumption, intoxicating and safe for them. On other species it is also safe, but has a fairly minimal effect, and humans drinking it is generally a waste.
Butanol moonshine can be made in the kitchen by delinquent lizards.

Adds two butanol based drinks, imported from moghes.

Also adds a new Tajaran Gin, slightly weaker than a normal spirit. This is an ordinary ethanol drink with some kitty flavour text.

Kegs of beer and xuizi juice can now be ordered in cargo. Prices may seem low but they come in a non-returnable large wooden crate

Fixes several bugs with alcohol effects not wearing off.
While fixing this I ran into another issue, and the easiest fix was something i've been meaning to do for a while:
Added a verb for bluespace techs to toggle their god mode on and off.
Intoxication with god mode on is now essentially disabled. It was causing too many buggy effects. If bluespace techs want to get drunk for adminbus RP, they can disable godmode first.

Fixes #1748
2017-04-08 23:17:46 +03:00
Ron
97e8955445 Misc Bug Removal (#2045)
vampire_powers.dm ~ vamps now know if they finished enthralling. Fixes #1705
utility.dm ~unconscious people cant feel things injected anymore. Fixes #606
security.dm ~7 days to play as sec now. Same with detective and warden. might need config option enabled. Fixes #1973
exodus-1.dm ~ removed useless circuit board. Fixes #1991
supplypacks.dm ~ Auxilllary Foensic tools crate spawns with a UV light now. Fixes #1936
tree_networking.dm ~ gave the malf AI more room to type things up. Also fixed typo. Fixes #1914
Made the viral infection outbreak say level 5 all the time so it matches up with sound file.
2017-04-08 19:10:48 +03:00
MarinaGryphon
f849657a62 Fixes #1163 (#2054)
Made the robotics control console check for R.lockcharge instead of !R.canmove to avoid issues with chairs.
Gave silicons their own custom /update_canmove() proc to deal with lockdown.
Made the robotics control console use SetLockdown(), like the lockdown wire.
2017-04-08 17:32:13 +03:00
MarinaGryphon
32b570871f Protohuman Fixes, Transform Procs, and Genetics Fixes (#2059)
Added a Humanize() proc that converts from lesser to greater form.
Made Monkeyize(), Humanize(), handle_post_spawn(), and set_species take a 'keepgenes' argument that tells whether or not to keep or override the gene for lesser or greater form.
Fixed what I presume is a typo in defining the 'hard' genetics bounds.
Made MONKEYBLOCK actually functional.
2017-04-08 17:30:31 +03:00
inselc
238ce7a80c Bugfixes: Drones, Infrared emitters, Implant cases and Limbs (#2049)
This PR contains bugfixes for:

Drones being unable to matter-decompile burnt matches (#717). Burnt matches will be decompiled into a small amount of wood.
Ghosts triggering infrared emitters (#644). Added a check whether the movable passing through the laser beam is actually "visible".
Reagent transfer messages showing up when clicking on chem implant cases, even when the syringe is empty (#704). Added a check whether reagents have actually been transferred. The displayed message will now also display the actual amount transferred. Removed spawn(5)-delay to prevent click-stacking.
Limb relocation messages not showing up for bystanders (#778).
2017-04-07 23:53:21 +03:00
Lohikar
636aef2970 Tactical Holster Fixes & Random Obj Runtime Fix (#2043)
changes:

Fixed some issues with tactical armor's holster.
Made tactical armor qdel its child storage instead of just nulling it out.
Hopefully fixed the runtimes with random voidsuits.
Fixed a bug where random vendors were always depleted.
Fixed a bug where industrials could not set their eye color.
Fixes #2041.
Hopefully fixes #1740.
2017-04-03 22:43:38 +03:00
Lohikar
80fb7af058 IPC Fixes & Nutrition Tweaks (#2037)
changes:

Only normal crew mobs equipped by the job master spawn with randomized nutrition.
Random nutrition's minimum nutrition value has been increased to 50%.
IPC Shells' skin tone and eye color now functions correctly.
Industrials' eyes now work correctly.
Added a nullcheck to random voidsuit spawn.
Fixes #1909.
Fixes #1646.
Fixes #1503.
Probably fixes #1740.
2017-04-02 16:53:53 +03:00
Alberyk
9b5ba48a09 Wizard buffs and fixes (#2038)
-fixes skeletons being unable to break cuffs
-buffed dark form to don't be shit, by giving it more life and some spells
-buffed the healing spells
-buffed mark and recall
2017-04-02 16:52:33 +03:00
Alberyk
ae5ebc19f1 Ghostrap update and minor fixes (#2019)
-moves skeleton minions,wizard familiars and syndicate borgs to the ghost trap system
-allow syndicate command and deathsquid to deploy their suit fully when equipped
-fix some wrong hardsuit modules names in rd
-fix immortal skeletons being able to spam immortality
-removes the alien death proc
-fix items not dropping when hands, feet or heads are cut off
-removes the paint from cargo spam
2017-04-02 00:10:55 +03:00
Werner
59e7377798 UDP Logging (#1997)
This implements UDP Logging with GELF.
It will allow full text search over all the logs and attributes sent over GELF to the log server.
2017-04-01 23:47:00 +03:00
skull132
a07a459f9e Revert "Adds snake people (#2029)" (#2031)
This reverts commit 0167ad4e80.
2017-04-01 23:39:12 +03:00
Alberyk
0167ad4e80 Adds snake people (#2029)
Changes:
-adds snake people as a whitelisted species
-adds tail mechanics, ported from europa station, to the snake people, you can coil it up, people can attack it, stomp the tail and etc
-snake people can spit poison
-snake people can't use shoes
-snake people also have some other features like having a minor brute resist, claws and cuff breaking
-snake people can have different scale colors and eyes colors, but green is the best color without doubt
-also adds snake people
2017-04-01 19:43:43 +03:00
skull132
0f3d8c083e Fix malicious/bad JS exploits 2017-04-01 16:57:56 +03:00
skull132
f6e91b621a Fix double calls to handle_spam_prevention (#2023)
Deadchat is now muted by MUTE_IC and MUTE_DEADCHAT.
2017-03-31 23:07:01 +03:00
skull132
fe5712dab6 Macro specific spam protection + mouse abuse (#2022)
Someone forgot to spam check squeaking.

I forgot to upload anti-macro spam measures.

So let's have both in one go, yay!
2017-03-31 19:32:50 +03:00
Lohikar
e64074c5a7 Runtime fixes (#2017)
changes:

Added more QDELETED checks to organ processing.
Fixed some misc runtimes in lighting & sparks.
2017-03-30 22:06:24 +03:00
Lohikar
2d26596320 Mining Fixes (#2016)
changes:

Fixed hematite and carbon not alloying correctly.
Fixed bad dir on a conveyor belt in the outpost.
Fixes #1752.
2017-03-30 22:00:34 +03:00
Alberyk
b5353d1659 Fix loadout dress uniforms and cult book spam (#2013)
-fix #2011
-fix attacking people with cult books having no delay
-nerf frag grenades a bit
-fix #1988 but this may end allowing you to hit people if you use the wrong tool, but, however will make things far easier for borgs or people doing surgery
2017-03-29 18:38:53 +03:00
skull132
d1597b1ff5 Fixes #1911 (#2012)
Fixes #1911
2017-03-29 17:44:33 +03:00
Lohikar
591fe86468 Organ Runtime Fix (#2005)
changes:

Added a QDELETED check to organ processing so they won't continue to process if they were erroneously left in the processing objects list after being deleted.
Fixed a bad robotic organ check on spiders.
2017-03-28 22:07:52 +03:00
Lohikar
f3b0edf03e Fix smoke (#1996)
changes:

Smoke no longer leaves mysterious patches of darkness.
Smoke now uses client-side animations instead of while loops.
Fixes #1985.
2017-03-26 12:37:35 +03:00
inselc
2d8739a279 Bugfixes: Fax machines (again), crew record formatting, RnD machines and wallets (#1987)
Trying to work off some of the older bugs on the issues list:

Fix faxmachine getting stuck on "0 seconds remaining". There may be a process scheduler issue which causes a long polling interval for the faxmachine's process()-method.
Replace newline in crew record notes with <BR> when generating the records in the filing cabinets.
Surround crew record notes with "preformatted text" HTML tags on PDA / pAI screens.
When constructing protolathes or circuit imprinters, transfer the reagents contained in the beakers to internal reagent container upon completion.
Fix suspension field generator not clearing the qdel'd suspension_field reference. This fixes being unable to unwrench the generator, too.
Fix wallet sprite still showing an empty wallet when inserting a guest pass.
2017-03-25 23:47:04 +02:00
Alberyk
a998108216 Fix cake/pizza slices spawning without any nutriment (#1986)
-fix the slices of food spawning without food inisde the lunch box
-fix all the food New() procs not using full paths
2017-03-24 21:43:26 +02:00
Alberyk
670adb46a2 Do not Nerf pylons, sadly, and other things (#1962)
-nerfed overall accuracy, and removed burst, of the scout rifle
-removed a fuckton of white space from nanacode
-should fix ipcs being stung by changelings at long last
2017-03-22 20:14:45 +02:00
skull132
5df9b2a0c1 Make renaming silicons from VV invoke rename-silicon (#1965) 2017-03-22 15:39:48 +02:00
NanakoAC
791dfda69f Pylon Balance Pass 1 (#1963)
Iterative balancing of pylon turrets based on feedback and observations. Small nerfs in a variety of areas.

Notably, removed armor penetration from the base (non-empowered) turrets.
Slightly reduced damage, range, durability and empower gain
2017-03-22 15:17:50 +02:00