Files
VMSolidus 201592f6bd Mob Destroy Refactoring (#22573)
Refactoring the entire destroy proc path from Mob Human all the way down
to Atom while trying to find the causes for the damn mob human hard
deletes. This PR comprehensively reorganizes every single stray
snowflake var used by /atom/ all the way to /mob/living/carbon/human,
and makes sure that every var that COULD store a reference, is now
cleared during the entirety of the Mob Destroy() parent hierarchy.

This may very well be the end of the lag war. 

In total, I've hunted down and cleared 39 hanging references between
/atom and /mob/living/carbon/human

---------

Signed-off-by: VMSolidus <evilexecutive@gmail.com>
2026-06-03 15:15:56 +00:00

178 lines
3.9 KiB
Plaintext

// EYE
//
// A mob that another mob controls to look around the station with.
// It streams chunks as it moves around, which will show it what the controller can and cannot see.
/mob/abstract/eye
name = "Eye"
var/name_suffix = "Eye"
icon = 'icons/mob/eye.dmi'
icon_state = "default-eye"
alpha = 127
density = FALSE
var/sprint = 10
var/cooldown = 0
var/acceleration = 1
var/owner_follows_eye = 0
status_flags = GODMODE
invisibility = INVISIBILITY_EYE
var/mob/owner = null
var/list/visibleChunks = list()
var/datum/visualnet/visualnet
///Set if the eye uses special click handling. Distinct from parent mob click handling for AI eye.
var/click_handler_type = /datum/click_handler/eye
///Whether or not our eye uses normal living vision handling
var/living_eye = TRUE
/mob/abstract/eye/Destroy()
release(owner)
owner = null
visualnet = null
return ..()
/mob/abstract/eye/Move(n, direct)
if(owner == src)
return EyeMove(n, direct)
return 0
/mob/abstract/eye/can_ztravel(var/direction)
return TRUE
/mob/abstract/eye/airflow_hit(atom/A)
airflow_speed = 0
airflow_dest = null
/mob/abstract/eye/ExaminateVerb()
set popup_menu = 0
set src = usr.contents
return 0
/mob/abstract/eye/pointed()
set popup_menu = 0
set src = usr.contents
return FALSE
/mob/abstract/eye/examine(mob/user, distance, is_adjacent, infix, suffix, show_extended)
SHOULD_CALL_PARENT(FALSE)
return TRUE
/mob/abstract/eye/proc/possess(var/mob/user)
if(owner && owner != user)
return
if(owner && owner.eyeobj != src)
return
owner = user
owner.eyeobj = src
name = "[owner.name] ([name_suffix])"
if(owner.client)
owner.client.eye = src
LAZYDISTINCTADD(owner.additional_vision_handlers, src)
apply_visual(owner)
if(click_handler_type)
owner.PushClickHandler(click_handler_type)
setLoc(owner)
visualnet?.update_eye_chunks(src, TRUE)
/mob/abstract/eye/proc/release(var/mob/user)
if(owner != user || !user)
return
if(owner.eyeobj != src)
return
remove_visual(owner)
LAZYREMOVE(owner.additional_vision_handlers, src)
visualnet?.remove_eye(src)
owner.eyeobj = null
if(owner.client)
owner.client.eye = owner
if(click_handler_type)
owner.RemoveClickHandler(click_handler_type)
owner = null
name = initial(name)
// Use this when setting the eye's location.
// It will also stream the chunk that the new loc is in.
/mob/abstract/eye/proc/setLoc(var/T)
if(!owner)
return FALSE
T = get_turf(T)
if(!T || T == loc)
return FALSE
forceMove(T)
if(owner.client)
owner.client.eye = src
if(owner_follows_eye)
owner.forceMove(loc)
visualnet?.update_eye_chunks(src)
return TRUE
/mob/abstract/eye/proc/getLoc()
if(owner)
if(!isturf(owner.loc) || !owner.client)
return
return loc
/mob/proc/EyeMove(n, direct)
if(!eyeobj)
return
return eyeobj.EyeMove(n, direct)
/mob/abstract/eye/EyeMove(n, direct)
var/initial = initial(sprint)
var/max_sprint = 50
if(cooldown && cooldown < world.timeofday)
sprint = initial
for(var/i = 0; i < max(sprint, initial); i += 20)
var/turf/step = get_turf(get_step(src, direct))
if(step && check_allowed_movement(step))
setLoc(step)
cooldown = world.timeofday + 5
if(acceleration)
sprint = min(sprint + 0.5, max_sprint)
else
sprint = initial
return 1
/// If the eye movement needs to be restricted by any additional means, override this.
/mob/abstract/eye/proc/check_allowed_movement(turf/step)
return TRUE
/mob/abstract/eye/ClickOn(atom/A, params)
if(owner)
return owner.ClickOn(A, params)
return ..()
/mob/abstract/eye/proc/apply_visual(mob/M)
if(M != owner || !M.client)
return FALSE
return TRUE
/mob/abstract/eye/proc/remove_visual(mob/M)
if(M != owner || !M.client)
return FALSE
return TRUE
/datum/click_handler/eye/OnClick(atom/A, params)
var/mob/abstract/eye = user.eyeobj
if(!eye) //Something has broken, ensure the click handler doesn't stick around
user.RemoveClickHandler(src)
return
eye.ClickOn(A, params)
/datum/click_handler/eye/OnDblClick(atom/A, params)
OnClick(A, params)