mirror of
https://github.com/Aurorastation/Aurora.3.git
synced 2025-12-22 16:12:19 +00:00
a3ec0cf45d
The system used to be of complexity O(n^2). Essentially two for loops running per every argument. Which ended up being surprisingly slow (there were instances where I saw the argument parser as using quite a lot of CPU time).
This replaces it with a more linear algorithm. It's somewhere near O(n) where n is the length of the unparsed query. Which is more stable and faaaster. This comes with two changes, however:
Parameters inside the query now have to be delimited from both sides with : (colons). The alternative to this would be to use something like $n or just assume that space marks the end of a marker. Only the former is workable, the latter would break a few queries already.
Arguments in the argument array no longer have to be prefixed by : (colons). So, while in the query you would write :thing:, you'd initialize the array of args as: list("thing" = somevar). It could be made to work without it, but eh, I think this is fine.
Argument validation is slightly weaker. What I mean by this is that with the old system, unused keys would result in an error. This is no longer a thing. Missing keys will still result in an error, however.
One more improvement: double delimiting removes an edge case where if key A partially covers key B, depending on the order, key A would mangle key B.
Updated and tested all queries that I could find. So this should be good.
84 lines
3.6 KiB
Plaintext
84 lines
3.6 KiB
Plaintext
/datum/category_item/player_setup_item/general/language
|
|
name = "Language"
|
|
sort_order = 2
|
|
|
|
/datum/category_item/player_setup_item/general/language/load_character(var/savefile/S)
|
|
S["language"] >> pref.alternate_languages
|
|
|
|
/datum/category_item/player_setup_item/general/language/save_character(var/savefile/S)
|
|
S["language"] << pref.alternate_languages
|
|
|
|
/datum/category_item/player_setup_item/general/language/gather_load_query()
|
|
return list("ss13_characters" = list("vars" = list("language" = "alternate_languages"), "args" = list("id")))
|
|
|
|
/datum/category_item/player_setup_item/general/language/gather_load_parameters()
|
|
return list("id" = pref.current_character)
|
|
|
|
/datum/category_item/player_setup_item/general/language/gather_save_query()
|
|
return list("ss13_characters" = list("id" = 1,
|
|
"ckey" = 1,
|
|
"language"))
|
|
|
|
/datum/category_item/player_setup_item/general/language/gather_save_parameters()
|
|
return list("language" = list2params(pref.alternate_languages),
|
|
"id" = pref.current_character,
|
|
"ckey" = pref.client.ckey)
|
|
|
|
/datum/category_item/player_setup_item/general/language/sanitize_character(var/sql_load = 0)
|
|
if (sql_load)
|
|
pref.alternate_languages = params2list(pref.alternate_languages)
|
|
|
|
if(!islist(pref.alternate_languages))
|
|
pref.alternate_languages = list()
|
|
|
|
/datum/category_item/player_setup_item/general/language/content()
|
|
. += "<b>Languages</b><br>"
|
|
var/datum/species/S = all_species[pref.species]
|
|
if(S.language)
|
|
. += "- [S.language]<br>"
|
|
if(S.default_language && S.default_language != S.language)
|
|
. += "- [S.default_language]<br>"
|
|
if(S.num_alternate_languages)
|
|
if(pref.alternate_languages.len)
|
|
for(var/i = 1 to pref.alternate_languages.len)
|
|
var/lang = pref.alternate_languages[i]
|
|
. += "- [lang] - <a href='?src=\ref[src];remove_language=[i]'>remove</a><br>"
|
|
|
|
if(pref.alternate_languages.len < S.num_alternate_languages)
|
|
. += "- <a href='?src=\ref[src];add_language=1'>add</a> ([S.num_alternate_languages - pref.alternate_languages.len] remaining)<br>"
|
|
else
|
|
. += "- [pref.species] cannot choose secondary languages.<br>"
|
|
|
|
/datum/category_item/player_setup_item/general/language/OnTopic(var/href,var/list/href_list, var/mob/user)
|
|
if(href_list["remove_language"])
|
|
var/index = text2num(href_list["remove_language"])
|
|
pref.alternate_languages.Cut(index, index+1)
|
|
return TOPIC_REFRESH
|
|
else if(href_list["add_language"])
|
|
var/datum/species/S = all_species[pref.species]
|
|
if(pref.alternate_languages.len >= S.num_alternate_languages)
|
|
alert(user, "You have already selected the maximum number of alternate languages for this species!")
|
|
else
|
|
var/list/available_languages = S.secondary_langs.Copy()
|
|
for(var/L in all_languages)
|
|
var/datum/language/lang = all_languages[L]
|
|
if(!(lang.flags & RESTRICTED) && (!config.usealienwhitelist || is_alien_whitelisted(user, L) || !(lang.flags & WHITELISTED)))
|
|
available_languages |= L
|
|
|
|
// make sure we don't let them waste slots on the default languages
|
|
available_languages -= S.language
|
|
available_languages -= S.default_language
|
|
available_languages -= pref.alternate_languages
|
|
|
|
if(!available_languages.len)
|
|
alert(user, "There are no additional languages available to select.")
|
|
else
|
|
var/new_lang = input(user, "Select an additional language", "Character Generation", null) as null|anything in available_languages
|
|
if(new_lang)
|
|
if (pref.alternate_languages.len >= S.num_alternate_languages)
|
|
alert(user, "You have already selected the maximum number of alternate languages for this species!")
|
|
else
|
|
pref.alternate_languages |= new_lang
|
|
return TOPIC_REFRESH
|
|
return ..()
|