mirror of
https://github.com/Aurorastation/Aurora.3.git
synced 2025-12-25 09:31:13 +00:00
a3ec0cf45d
The system used to be of complexity O(n^2). Essentially two for loops running per every argument. Which ended up being surprisingly slow (there were instances where I saw the argument parser as using quite a lot of CPU time).
This replaces it with a more linear algorithm. It's somewhere near O(n) where n is the length of the unparsed query. Which is more stable and faaaster. This comes with two changes, however:
Parameters inside the query now have to be delimited from both sides with : (colons). The alternative to this would be to use something like $n or just assume that space marks the end of a marker. Only the former is workable, the latter would break a few queries already.
Arguments in the argument array no longer have to be prefixed by : (colons). So, while in the query you would write :thing:, you'd initialize the array of args as: list("thing" = somevar). It could be made to work without it, but eh, I think this is fine.
Argument validation is slightly weaker. What I mean by this is that with the old system, unused keys would result in an error. This is no longer a thing. Missing keys will still result in an error, however.
One more improvement: double delimiting removes an edge case where if key A partially covers key B, depending on the order, key A would mangle key B.
Updated and tested all queries that I could find. So this should be good.
87 lines
4.6 KiB
Plaintext
87 lines
4.6 KiB
Plaintext
/datum/category_item/player_setup_item/player_global/ui
|
||
name = "UI"
|
||
sort_order = 1
|
||
|
||
/datum/category_item/player_setup_item/player_global/ui/load_preferences(var/savefile/S)
|
||
S["UI_style"] >> pref.UI_style
|
||
S["UI_style_color"] >> pref.UI_style_color
|
||
S["UI_style_alpha"] >> pref.UI_style_alpha
|
||
S["ooccolor"] >> pref.ooccolor
|
||
|
||
/datum/category_item/player_setup_item/player_global/ui/save_preferences(var/savefile/S)
|
||
S["UI_style"] << pref.UI_style
|
||
S["UI_style_color"] << pref.UI_style_color
|
||
S["UI_style_alpha"] << pref.UI_style_alpha
|
||
S["ooccolor"] << pref.ooccolor
|
||
|
||
/datum/category_item/player_setup_item/player_global/ui/gather_load_query()
|
||
return list("ss13_player_preferences" = list("vars" = list("UI_style", "UI_style_color", "UI_style_alpha", "ooccolor"), "args" = list("ckey")))
|
||
|
||
/datum/category_item/player_setup_item/player_global/ui/gather_load_parameters()
|
||
return list("ckey" = pref.client.ckey)
|
||
|
||
/datum/category_item/player_setup_item/player_global/ui/gather_save_query()
|
||
return list("ss13_player_preferences" = list("UI_style", "UI_style_color", "UI_style_alpha", "ooccolor", "ckey" = 1))
|
||
|
||
/datum/category_item/player_setup_item/player_global/ui/gather_save_parameters()
|
||
return list("ckey" = pref.client.ckey, "UI_style_alpha" = pref.UI_style_alpha, "UI_style_color" = pref.UI_style_color, "UI_style" = pref.UI_style, "ooccolor" = pref.ooccolor)
|
||
|
||
/datum/category_item/player_setup_item/player_global/ui/sanitize_preferences()
|
||
pref.UI_style = sanitize_inlist(pref.UI_style, all_ui_styles, initial(pref.UI_style))
|
||
pref.UI_style_color = sanitize_hexcolor(pref.UI_style_color, initial(pref.UI_style_color))
|
||
pref.UI_style_alpha = sanitize_integer(text2num(pref.UI_style_alpha), 0, 255, initial(pref.UI_style_alpha))
|
||
pref.ooccolor = sanitize_hexcolor(pref.ooccolor, initial(pref.ooccolor))
|
||
|
||
/datum/category_item/player_setup_item/player_global/ui/content(var/mob/user)
|
||
. += "<b>UI Settings</b><br>"
|
||
. += "<b>UI Style:</b> <a href='?src=\ref[src];select_style=1'><b>[pref.UI_style]</b></a><br>"
|
||
. += "<b>Custom UI</b> (recommended for White UI):<br>"
|
||
. += "-Color: <a href='?src=\ref[src];select_color=1'><b>[pref.UI_style_color]</b></a><3E><table style='display:inline;' bgcolor='[pref.UI_style_color]'><tr><td>__</td></tr></table><3E><a href='?src=\ref[src];reset=ui'>reset</a><br>"
|
||
. += "-Alpha(transparency): <a href='?src=\ref[src];select_alpha=1'><b>[pref.UI_style_alpha]</b></a><3E><a href='?src=\ref[src];reset=alpha'>reset</a><br>"
|
||
if(can_select_ooc_color(user))
|
||
. += "<b>OOC Color:</b><3E>"
|
||
if(pref.ooccolor == initial(pref.ooccolor))
|
||
. += "<a href='?src=\ref[src];select_ooc_color=1'><b>Using Default</b></a><br>"
|
||
else
|
||
. += "<a href='?src=\ref[src];select_ooc_color=1'><b>[pref.ooccolor]</b></a> <table style='display:inline;' bgcolor='[pref.ooccolor]'><tr><td>__</td></tr></table><3E><a href='?src=\ref[src];reset=ooc'>reset</a><br>"
|
||
|
||
/datum/category_item/player_setup_item/player_global/ui/OnTopic(var/href,var/list/href_list, var/mob/user)
|
||
if(href_list["select_style"])
|
||
var/UI_style_new = input(user, "Choose UI style.", "Character Preference", pref.UI_style) as null|anything in all_ui_styles
|
||
if(!UI_style_new || !CanUseTopic(user)) return TOPIC_NOACTION
|
||
pref.UI_style = UI_style_new
|
||
return TOPIC_REFRESH
|
||
|
||
else if(href_list["select_color"])
|
||
var/UI_style_color_new = input(user, "Choose UI color, dark colors are not recommended!", "Global Preference", pref.UI_style_color) as color|null
|
||
if(isnull(UI_style_color_new) || !CanUseTopic(user)) return TOPIC_NOACTION
|
||
pref.UI_style_color = UI_style_color_new
|
||
return TOPIC_REFRESH
|
||
|
||
else if(href_list["select_alpha"])
|
||
var/UI_style_alpha_new = input(user, "Select UI alpha (transparency) level, between 50 and 255.", "Global Preference", pref.UI_style_alpha) as num|null
|
||
if(isnull(UI_style_alpha_new) || (UI_style_alpha_new < 50 || UI_style_alpha_new > 255) || !CanUseTopic(user)) return TOPIC_NOACTION
|
||
pref.UI_style_alpha = UI_style_alpha_new
|
||
return TOPIC_REFRESH
|
||
|
||
else if(href_list["select_ooc_color"])
|
||
var/new_ooccolor = input(user, "Choose OOC color:", "Global Preference") as color|null
|
||
if(new_ooccolor && can_select_ooc_color(user) && CanUseTopic(user))
|
||
pref.ooccolor = new_ooccolor
|
||
return TOPIC_REFRESH
|
||
|
||
else if(href_list["reset"])
|
||
switch(href_list["reset"])
|
||
if("ui")
|
||
pref.UI_style_color = initial(pref.UI_style_color)
|
||
if("alpha")
|
||
pref.UI_style_alpha = initial(pref.UI_style_alpha)
|
||
if("ooc")
|
||
pref.ooccolor = initial(pref.ooccolor)
|
||
return TOPIC_REFRESH
|
||
|
||
return ..()
|
||
|
||
/datum/category_item/player_setup_item/player_global/ui/proc/can_select_ooc_color(var/mob/user)
|
||
return config.allow_admin_ooccolor && check_rights(R_ADMIN, 0, user)
|