[MIRROR] Gives Detective ACCESS_SECURITY, moves security equipment to ACCESS_BRIG [MDB IGNORE] (#13658)

* Gives Detective ACCESS_SECURITY, moves security equipment to ACCESS_BRIG (#66990)

* Gives Detective ACCESS_SECURITY, moves security equipment to ACCESS_BRIG

* Removed Forensics access from brig closet, security records

* Gives Detective ACCESS_SECURITY, moves security equipment to ACCESS_BRIG

Co-authored-by: Son-of-Space <63861499+Son-of-Space@users.noreply.github.com>

code/__DEFINES/access.dm

@@ -1,6 +1,6 @@
-// Security equipment, security records, gulag item storage, secbots
+// Security general access, security records, gulag item storage, secbots
 #define ACCESS_SECURITY 1
-/// Brig cells+timers, permabrig, gulag+gulag shuttle, prisoner management console
+/// Brig cells+timers, permabrig, gulag+gulag shuttle, prisoner management console, security equipment
 #define ACCESS_BRIG 2
 /// Armory, gulag teleporter, execution chamber
 #define ACCESS_ARMORY 3

code/datums/id_trim/jobs.dm

@@ -245,8 +245,8 @@
 	assignment = "Detective"
 	trim_state = "trim_detective"
 	sechud_icon_state = SECHUD_DETECTIVE
-	extra_access = list()
-	minimal_access = list(ACCESS_BRIG, ACCESS_COURT, ACCESS_FORENSICS, ACCESS_BRIG_ENTRANCE,ACCESS_MAINT_TUNNELS, ACCESS_MORGUE,
+	extra_access = list(ACCESS_BRIG)
+	minimal_access = list(ACCESS_SECURITY, ACCESS_COURT, ACCESS_FORENSICS, ACCESS_BRIG_ENTRANCE,ACCESS_MAINT_TUNNELS, ACCESS_MORGUE,
 					ACCESS_MECH_SECURITY, ACCESS_MINERAL_STOREROOM, ACCESS_WEAPONS)
 	config_job = "detective"
 	template_access = list(ACCESS_CAPTAIN, ACCESS_HOS, ACCESS_CHANGE_IDS)

code/game/machinery/computer/security.dm

@@ -3,7 +3,7 @@
 	desc = "Used to view and edit personnel's security records."
 	icon_screen = "security"
 	icon_keyboard = "security_key"
-	req_one_access = list(ACCESS_SECURITY, ACCESS_FORENSICS, ACCESS_HOP)
+	req_one_access = list(ACCESS_SECURITY, ACCESS_HOP)
 	circuit = /obj/item/circuitboard/computer/secure_data
 	light_color = COLOR_SOFT_RED
 	var/rank = null

code/game/objects/structures/crates_lockers/closets/secure/security.dm

@@ -230,7 +230,7 @@
 
 /obj/structure/closet/secure_closet/brig
 	name = "brig locker"
-	req_access = list(ACCESS_BRIG)
+	req_one_access = list(ACCESS_BRIG)
 	anchored = TRUE
 	var/id = null