Fixes timer buckets going into negatives and adds a regression test

This commit is contained in:
ninjanomnom
2018-08-16 14:50:09 -04:00
parent 690b37b6d6
commit 01a79dccb0
3 changed files with 8 additions and 2 deletions
+1
View File
@@ -212,6 +212,7 @@ SUBSYSTEM_DEF(timer)
if(!(qtimer.flags & TIMER_LOOP))
qdel(qtimer)
else
bucket_count++
qtimer.spent = 0
qtimer.bucketEject()
if(qtimer.flags & TIMER_CLIENT_TIME)
+4 -2
View File
@@ -1,9 +1,11 @@
//include unit test files in this module in this ifdef
//Keep this sorted alphabetically
#ifdef UNIT_TESTS
#include "unit_test.dm"
#include "reagent_recipe_collisions.dm"
#include "reagent_id_typos.dm"
#include "reagent_recipe_collisions.dm"
#include "spawn_humans.dm"
#include "subsystem_init.dm"
#include "timer_sanity.dm"
#include "unit_test.dm"
#endif
+3
View File
@@ -0,0 +1,3 @@
/datum/unit_test/timer_sanity/Run()
if(SStimer.bucket_count < 0)
Fail("SStimer is going into negative bucket count from something")