cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-31 00:58:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Allows late-joiners to have a chance at commending other people [MDB IGNORE] (#16931)

Browse Source 
* Allows late-joiners to have a chance at commending other people (#70574)

About The Pull Request

Basically, it was iterating the list of the people that had joined the game, in order. There's only one problem with that: The first entries in that list were always the round-start people, so as soon as you late-join into the shift, you can say goodbye to your chance at commending someone else, which explains why certain players claim to never have had the chance to commend someone else whilst I can oftentimes get the prompt for three or four rounds in a row.

Why It's Good For The Game

Makes the system work as intended, by actually making everyone that joined the round and is still alive at the end of it, a chance to commend others.

* Allows late-joiners to have a chance at commending other people

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
This commit is contained in:
SkyratBot
2022-10-17 16:57:31 +00:00
committed by GitHub
co-authored by GoldenAlpharex
parent 94f5571711
commit 395759529f
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/__HELPERS/hearted.dm
+4 -1
View File
@@ -9,7 +9,10 @@
return
message_admins("Polling [number_to_ask] players for commendations.")
for(var/i in GLOB.joined_player_list)
// We need the list to be random, otherwise we'll end up always asking the same people to give out commendations.
var/list/eligible_player_list = shuffle(GLOB.joined_player_list)
for(var/i in eligible_player_list)
var/mob/check_mob = get_mob_by_ckey(i)
if(!check_mob?.mind || !check_mob.client)
continue