Power cell overlay now updates when exiting an object's contents (#85079)

## About The Pull Request
The charge indicator overlay on power cells is now properly updated when
the cell is charged/discharged. Before, you could use a power cell until
it's empty and the overlay wouldn't change at all.
## Why It's Good For The Game
The overlay is there to indicate the charge of the cell. It should work.
## Changelog
🆑
fix: The charge indicators on power cells now work properly.
code: Removed some now redundant power cell appearance updates
/🆑

---------

Co-authored-by: jimmyl <70376633+mc-oofert@ users.noreply.github.com>
This commit is contained in:
Nick
2024-07-31 12:30:57 -04:00
committed by SkyratBot
co-authored by jimmyl
parent 676907223c
commit 3af4e6ae79
13 changed files with 7 additions and 12 deletions
-1
View File
@@ -147,7 +147,6 @@
if(!cell || !cell_removable)
return FALSE
cell.update_appearance()
cell.forceMove(get_turf(src))
balloon_alert(user, "removed [cell]")
cell = null
-1
View File
@@ -504,7 +504,6 @@
/obj/item/melee/baton/security/Exited(atom/movable/mov_content)
. = ..()
if(mov_content == cell)
cell.update_appearance()
cell = null
active = FALSE
update_appearance()
@@ -517,7 +517,6 @@ GLOBAL_LIST_INIT(command_strings, list(
if(istype(item_to_drop, /obj/item/stock_parts/power_store/cell))
var/obj/item/stock_parts/power_store/cell/dropped_cell = item_to_drop
dropped_cell.charge = 0
dropped_cell.update_appearance()
return
if(istype(item_to_drop, /obj/item/storage))
@@ -214,7 +214,6 @@ GLOBAL_LIST_INIT(blacklisted_borg_hats, typecacheof(list( //Hats that don't real
if(!wiresexposed && !issilicon(user))
if(!cell)
return
cell.update_appearance()
cell.add_fingerprint(user)
to_chat(user, span_notice("You remove \the [cell]."))
user.put_in_active_hand(cell)
@@ -556,7 +556,6 @@
if(istype(item_to_drop, /obj/item/stock_parts/power_store/cell))
var/obj/item/stock_parts/power_store/cell/dropped_cell = item_to_drop
dropped_cell.charge = 0
dropped_cell.update_appearance()
else if(istype(item_to_drop, /obj/item/storage))
var/obj/item/storage/storage_to_drop = item_to_drop
@@ -754,7 +754,6 @@
new /obj/item/stack/cable_coil/cut(Tsec)
if(cell)
cell.forceMove(Tsec)
cell.update_appearance()
cell = null
new /obj/effect/decal/cleanable/oil(loc)
-1
View File
@@ -173,7 +173,6 @@
/obj/item/mod/core/standard/proc/uninstall_cell()
if(!cell)
return
cell.update_appearance()
cell = null
mod.update_charge_alert()
-1
View File
@@ -308,7 +308,6 @@
/obj/machinery/power/apc/Exited(atom/movable/gone, direction)
. = ..()
if(gone == cell)
cell.update_appearance()
cell = null
charging = APC_NOT_CHARGING
update_appearance()
-1
View File
@@ -320,7 +320,6 @@
balloon_alert(user, "cell removed")
var/turf/user_turf = get_turf(user)
cell.forceMove(user_turf)
cell.update_appearance()
cell = null
charging = APC_NOT_CHARGING
update_appearance()
@@ -63,7 +63,6 @@
return
user.visible_message(span_notice("[user] removes [cell] from [src]!"), span_notice("You remove [cell]."))
user.put_in_hands(cell)
cell.update_appearance()
cell = null
add_fingerprint(user)
+7
View File
@@ -57,6 +57,13 @@
)
AddElement(/datum/element/connect_loc, loc_connections)
/obj/item/stock_parts/power_store/Moved(atom/old_loc, movement_dir, forced, list/old_locs, momentum_change = TRUE)
. = ..()
if(!isturf(old_loc))
update_appearance()
/**
* Signal proc for [COMSIG_ITEM_MAGICALLY_CHARGED]
*
@@ -91,7 +91,6 @@
/obj/item/reagent_containers/cup/maunamug/attack_hand(mob/living/user, list/modifiers)
if(cell && open)
cell.update_appearance()
user.put_in_hands(cell)
cell = null
to_chat(user, span_notice("You remove the power cell from [src]."))
@@ -100,7 +100,6 @@
/obj/vehicle/ridden/wheelchair/motorized/attack_hand(mob/living/user, list/modifiers)
if(!power_cell || !panel_open)
return ..()
power_cell.update_appearance()
to_chat(user, span_notice("You remove [power_cell] from [src]."))
user.put_in_hands(power_cell)
power_cell = null