Tcomms Soundloop Comes From One Source And Is Less Awful (#74908)

## About The Pull Request

The ``soundloop/server`` now only comes from the server hub, so it
doesn't have stacking audio sources. The sound has been made more
uniform when up close, but is overall quieter. Additionally, all the
files have been run through a low pass filter to remove the highest of
it's pitches.
## Why It's Good For The Game

I'm sick of not wanting to be around telecomms because of how bad every
single machine sounds. Now, things are significantly easier on the ear,
quieter, more uniform, and better for everyone's sanity. I asked the
maintainers in the coding channel if I could just remove it and they
said no.

I can't get a video recording, I've tried with win+G, OBS, and sharex
and it's just fucked.
## Changelog
🆑
qol: telecomms is quieter and less ear-damaging.
sound: modified tcomms sound to remove high-tones.
fix: the telecomms sound only comes from the server hub machine.
/🆑

---------

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
This commit is contained in:
Cheshify
2023-04-23 10:34:27 -07:00
committed by GitHub
co-authored by Mothblocks
parent 5d726adbbe
commit 3fdd716da5
10 changed files with 23 additions and 8 deletions
@@ -91,11 +91,12 @@
'sound/machines/tcomms/tcomms_mid7.ogg' = 1,
)
mid_length = 1.8 SECONDS
extra_range = -11
falloff_distance = 1
extra_range = -8
falloff_distance = 3
falloff_exponent = 5
volume = 50
volume = 35
ignore_walls = FALSE
pressure_affected = FALSE
/datum/looping_sound/computer
start_sound = 'sound/machines/computer/computer_start.ogg'
@@ -34,6 +34,25 @@
use_power(idle_power_usage)
/obj/machinery/telecomms/hub/update_power()
var/old_on = on
if (toggled && (machine_stat & (BROKEN|NOPOWER|EMPED)))
on = FALSE
soundloop.stop()
else
on = TRUE
soundloop.start()
if(old_on != on)
update_appearance()
/obj/machinery/telecomms/hub/Initialize(mapload)
. = ..()
soundloop = new(src, on)
/obj/machinery/telecomms/hub/Destroy()
QDEL_NULL(soundloop)
return ..()
//Preset HUB
/obj/machinery/telecomms/hub/preset
@@ -104,7 +104,6 @@ GLOBAL_LIST_EMPTY(telecomms_list)
/obj/machinery/telecomms/Initialize(mapload)
. = ..()
soundloop = new(src, on)
GLOB.telecomms_list += src
if(mapload && autolinkers.len)
return INITIALIZE_HINT_LATELOAD
@@ -118,7 +117,6 @@ GLOBAL_LIST_EMPTY(telecomms_list)
/obj/machinery/telecomms/Destroy()
GLOB.telecomms_list -= src
QDEL_NULL(soundloop)
for(var/obj/machinery/telecomms/comm in GLOB.telecomms_list)
remove_link(comm)
links = list()
@@ -150,13 +148,10 @@ GLOBAL_LIST_EMPTY(telecomms_list)
if(toggled)
if(machine_stat & (BROKEN|NOPOWER|EMPED)) // if powered, on. if not powered, off. if too damaged, off
on = FALSE
soundloop.stop()
else
on = TRUE
soundloop.start()
else
on = FALSE
soundloop.stop()
if(old_on != on)
update_appearance()
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.