Fixes nuke ops lobby meta exploit(#59716)

This pr fixes #56332 (Being able to meta nukie spawn. There was a linked solution which amounted to telling the equip to not make noise, but this code is pain)

    Nuke ops leaders are given their paper during the memorize_code proc.
    Nuke ops are moved to spawn after memorize_code is called.
    So: nuke ops leaders got their paper before they were moved to the nuke ops spawn - allowing anyone to hear it that's nearby the spawn box.

This PR just moves the memorize_code call to after nuke ops are moved to their spawn, so it prevents the lobby from hearing the sound of the paper.
This commit is contained in:
MrMelbert
2021-06-20 16:17:43 -07:00
committed by GitHub
parent e03cd1aada
commit 447c45fe2c
+1 -3
View File
@@ -42,7 +42,6 @@
forge_objectives()
. = ..()
equip_op()
memorize_code()
if(send_to_spawnpoint)
move_to_spawnpoint()
// grant extra TC for the people who start in the nukie base ie. not the lone op
@@ -50,8 +49,7 @@
var/datum/component/uplink/U = owner.find_syndicate_uplink()
if (U)
U.telecrystals += extra_tc
memorize_code()
/datum/antagonist/nukeop/get_team()
return nuke_team