cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-23 13:10:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

Greps for pronoun helper spelling mistakes (#83086)

Browse Source 
Fixes #83083

These are case sensitive
This commit is contained in:
Afevis
2024-05-06 17:38:13 -07:00
committed by GitHub
parent 351a0873a4
commit 48d8850ffc
5 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/__DEFINES/pronouns.dm
+2
View File
@@ -17,6 +17,8 @@
/// s, null (she looks, they look) "%PRONOUN_s" = "p_s"
/// es, null (she goes, they go) "%PRONOUN_es" = "p_es"
/// Don't forget to update the grep if you add more! tools/ci/check_grep.sh -> pronoun helper spellcheck
/// A list for all the pronoun procs, if you need to iterate or search through it or something.
#define ALL_PRONOUNS list( \
"%PRONOUN_they" = TYPE_PROC_REF(/datum, p_they), \
code/game/machinery/dna_infuser/organ_sets/carp_organs.dm
+1 -1
View File
@@ -113,7 +113,7 @@
/obj/item/organ/internal/brain/carp/Initialize(mapload)
. = ..()
AddElement(/datum/element/organ_set_bonus, /datum/status_effect/organ_set_bonus/carp)
AddElement(/datum/element/noticable_organ, "%PRONOUN_They seem%PRONOUN_S unable to stay still.")
AddElement(/datum/element/noticable_organ, "%PRONOUN_They seem%PRONOUN_s unable to stay still.")
/obj/item/organ/internal/brain/carp/on_mob_insert(mob/living/carbon/brain_owner)
. = ..()
code/game/machinery/dna_infuser/organ_sets/gondola_organs.dm
+1 -1
View File
@@ -31,7 +31,7 @@ Fluoride Stare: After someone says 5 words, blah blah blah...
/obj/item/organ/internal/heart/gondola/Initialize(mapload)
. = ..()
AddElement(/datum/element/organ_set_bonus, /datum/status_effect/organ_set_bonus/gondola)
AddElement(/datum/element/noticable_organ, "%PRONOUN_They radiate%PRONOUN_S an aura of serenity.")
AddElement(/datum/element/noticable_organ, "%PRONOUN_They radiate%PRONOUN_s an aura of serenity.")
/obj/item/organ/internal/heart/gondola/Insert(mob/living/carbon/receiver, special, movement_flags)
. = ..()
code/game/machinery/dna_infuser/organ_sets/rat_organs.dm
+1 -1
View File
@@ -61,7 +61,7 @@
/obj/item/organ/internal/heart/rat/Initialize(mapload)
. = ..()
AddElement(/datum/element/organ_set_bonus, /datum/status_effect/organ_set_bonus/rat)
AddElement(/datum/element/noticable_organ, "%PRONOUN_They hunch%PRONOUN_ES over unnaturally!")
AddElement(/datum/element/noticable_organ, "%PRONOUN_They hunch%PRONOUN_es over unnaturally!")
/obj/item/organ/internal/heart/rat/on_mob_insert(mob/living/carbon/receiver)
. = ..()
tools/ci/check_grep.sh
+6
View File
@@ -288,6 +288,12 @@ if [ "$pcre2_support" -eq 1 ]; then
echo -e "${RED}ERROR: Initialize override without 'mapload' argument.${NC}"
st=1
fi;
part "pronoun helper spellcheck"
if $grep -P '%PRONOUN_(?!they|They|their|Their|theirs|Theirs|them|Them|have|are|were|do|theyve|Theyve|theyre|Theyre|s|es)' $code_files; then
echo
echo -e "${RED}ERROR: Invalid pronoun helper found.${NC}"
st=1
fi;
else
echo -e "${RED}pcre2 not supported, skipping checks requiring pcre2"
echo -e "if you want to run these checks install ripgrep with pcre2 support.${NC}"