cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-28 15:47:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Creates a unit test for loadout item duplicates (#25747)

Browse Source 
* Creates a unit test for loadout item duplicates

* Update loadout_dupes.dm

* Update loadout_dupes.dm

* Update loadout_dupes.dm

* Update loadout_datum_under.dm

* I'm going to put the cargo shorts under misc/under

* Revert "I'm going to put the cargo shorts under misc/under"

This reverts commit e4cdbd80e42424091ad76be67502ced2cbadec13.
This commit is contained in:
Bloop
2023-12-20 13:44:50 -05:00
committed by GitHub
parent c5433c8f96
commit 49b7f8445e
3 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/unit_tests/_unit_tests.dm
+1
View File
@@ -275,6 +275,7 @@
#include "worn_icons.dm"
// SKYRAT EDIT START
#include "~skyrat\automapper.dm"
#include "~skyrat\loadout_dupes.dm"
#include "~skyrat\opposing_force.dm"
// SKYRAT EDIT END
// END_INCLUDE
code/modules/unit_tests/~skyrat/loadout_dupes.dm
+14
View File
@@ -0,0 +1,14 @@
///Checks that loadout items' item_paths are unique to the category of loadout item it belongs to
/datum/unit_test/loadout_dupes
/datum/unit_test/loadout_dupes/Run()
var/list/item_paths = list()
for(var/datum/loadout_item/item as anything in subtypesof(/datum/loadout_item))
var/loadout_item_category = initial(item.category)
var/item_path = initial(item.item_path)
if(item_paths[item_path] == loadout_item_category)
TEST_FAIL("Duplicate loadout item! [item_path] is already being used by [item].")
if(isnull(item_path)) // can be null, for subcategories of loadout items
continue
item_paths[item_path] = loadout_item_category
modular_skyrat/modules/loadouts/loadout_items/under/loadout_datum_under.dm
-8
View File
@@ -179,10 +179,6 @@ GLOBAL_LIST_INIT(loadout_miscunders, generate_loadout_items(/datum/loadout_item/
item_path = /obj/item/clothing/under/rank/cargo/tech
restricted_roles = list(JOB_CARGO_TECHNICIAN, JOB_QUARTERMASTER, JOB_CUSTOMS_AGENT)
/datum/loadout_item/under/jumpsuit/cargo/shorts
name = "Cargo Technician's Shorts"
item_path = /obj/item/clothing/under/rank/cargo/tech/alt
/datum/loadout_item/under/jumpsuit/cargo/skirt
name = "Cargo Technician's Skirt"
item_path = /obj/item/clothing/under/rank/cargo/tech/skirt
@@ -747,10 +743,6 @@ GLOBAL_LIST_INIT(loadout_miscunders, generate_loadout_items(/datum/loadout_item/
name = "Navy Suit"
item_path = /obj/item/clothing/under/suit/navy
/datum/loadout_item/under/formal/maid_outfit
name = "Maid Outfit"
item_path = /obj/item/clothing/under/costume/maid
/datum/loadout_item/under/formal/maid_uniform
name = "Maid Uniform"
item_path = /obj/item/clothing/under/rank/civilian/janitor/maid