cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-22 04:30:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] windows node bootstrapping now downloads node.exe to a separate file before renaming it [MDB IGNORE] (#19508)

Browse Source 
* windows node bootstrapping now downloads node.exe to a separate file before renaming it (#73586)

This should stop people from getting "corrupt" copies of node.exe in
their `./tools/bootstrap/.cache` directory. I checked before making this
commit that WebClient.DownloadFile can definitely result in a
half-written file.

* windows node bootstrapping now downloads node.exe to a separate file before renaming it

---------

Co-authored-by: willox <me@wiox.me>
This commit is contained in:
SkyratBot
2023-03-10 02:41:14 +00:00
committed by GitHub
co-authored by willox
parent f9ce50bb89
commit 4e5da178a3
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/bootstrap/node_.ps1
+2 -1
View File
@@ -20,7 +20,8 @@ function Download-Node {
Write-Output "Downloading Node v$NodeVersion (may take a while)"
New-Item $NodeTargetDir -ItemType Directory -ErrorAction silentlyContinue | Out-Null
$WebClient = New-Object Net.WebClient
$WebClient.DownloadFile($NodeSource, $NodeTarget)
$WebClient.DownloadFile($NodeSource, "$NodeTarget.downloading")
Rename-Item "$NodeTarget.downloading" $NodeTarget
}
## Convenience variables