cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-26 14:39:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Add signal override back as a runtime [MDB IGNORE] (#18865)

Browse Source 
Add signal override back as a runtime (#72561)

We're not seeing this on CI and I'm not seeing it on my local DD logs
unless I go out of my way to check. Keeping separate file means it's
easy to go through, but this indicates a bug that needs to be fixed and
so it should still be in runtime.

Doesn't revert #70034, as it still keeps log_signal.

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
This commit is contained in:
SkyratBot
2023-01-21 19:52:11 -05:00
committed by GitHub
co-authored by Mothblocks
parent c8916c845b
commit 64e15f1cbd
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/datums/components/_component.dm
+4 -2
View File
@@ -201,7 +201,9 @@
var/list/lookup = (target.comp_lookup ||= list())
if(!override && target_procs[signal_type])
log_signal("[signal_type] overridden. Use override = TRUE to suppress this warning.\nTarget: [target] ([target.type]) Proc: [proctype]")
var/override_message = "[signal_type] overridden. Use override = TRUE to suppress this warning.\nTarget: [target] ([target.type]) Proc: [proctype]"
log_signal(override_message)
stack_trace(override_message)
target_procs[signal_type] = proctype
var/list/looked_up = lookup[signal_type]
@@ -218,7 +220,7 @@
/// Registers multiple signals to the same proc.
/datum/proc/RegisterSignals(datum/target, list/signal_types, proctype, override = FALSE)
for (var/signal_type in signal_types)
RegisterSignal(target, signal_type, proctype)
RegisterSignal(target, signal_type, proctype, override)
/**
* Stop listening to a given signal from target
code/modules/mob/living/simple_animal/hostile/space_dragon.dm
+4 -1
View File
@@ -175,9 +175,12 @@
UnregisterSignal(small_sprite, COMSIG_ACTION_TRIGGER)
/mob/living/simple_animal/hostile/space_dragon/revive(full_heal_flags = NONE, excess_healing = 0, force_grab_ghost = FALSE)
var/was_dead = stat == DEAD
. = ..()
add_dragon_overlay()
RegisterSignal(small_sprite, COMSIG_ACTION_TRIGGER, PROC_REF(add_dragon_overlay))
if (was_dead)
RegisterSignal(small_sprite, COMSIG_ACTION_TRIGGER, PROC_REF(add_dragon_overlay))
/**
* Allows space dragon to choose its own name.