cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-31 09:08:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

[NO GBP] Fixes multiplier applied incorrectly in trans_to() (#92404)

Browse Source 
## About The Pull Request
- Fixes #92401

And many other reagent transfer operations who's multiplier is not 1

## Changelog
🆑
fix: reagent transfer amounts with multiplier applied(e.g. cryotubes)
have been corrected
/🆑
This commit is contained in:
SyncIt21
2025-08-01 10:24:14 +02:00
committed by GitHub
parent 7fbcac8fb6
commit 6bc86d2bd4
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/reagents/chemistry/holder/holder.dm
+2 -3
View File
@@ -485,7 +485,6 @@
continue
else
transfer_amount = reagent.volume * part
transfer_amount *= multiplier
if(preserve_data)
trans_data = copy_data(reagent)
@@ -493,12 +492,12 @@
update_total()
target_holder.update_total()
continue
transfered_amount = target_holder.add_reagent(reagent.type, transfer_amount, trans_data, chem_temp, reagent.purity, reagent.ph, no_react = TRUE, reagent_added = r_to_send, creation_callback = CALLBACK(src, PROC_REF(_on_transfer_creation), reagent, target_holder)) //we only handle reaction after every reagent has been transferred.
transfered_amount = target_holder.add_reagent(reagent.type, transfer_amount * multiplier, trans_data, chem_temp, reagent.purity, reagent.ph, no_react = TRUE, reagent_added = r_to_send, creation_callback = CALLBACK(src, PROC_REF(_on_transfer_creation), reagent, target_holder)) //we only handle reaction after every reagent has been transferred.
if(!transfered_amount)
continue
total_transfered_amount += transfered_amount
reagent.volume -= transfered_amount
reagent.volume -= transfer_amount
transfer_log += "[reagent.type] ([transfered_amount]u, [reagent.purity] purity)"
if(!isnull(target_id))