cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-29 08:08:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Fixes glove offsets not working with negative numbers [MDB IGNORE] (#21434)

Browse Source 
* Fixes glove offsets not working with negative numbers (#75638)

## About The Pull Request

This was changed in the Golem rework -
https://github.com/tgstation/tgstation/pull/74197

If you have a species that have arms that go longer than normal, you can
set the offsets of in-hands to negative y value to lower it. This isn't
an option for gloves however, because it starts at 0 and only increases
if the value is larger.
This fixes it by letting it set a negative number, and comparing your
other hands' offsets to that.

## Why It's Good For The Game

Fixes species that have arms that go longer than normal.

## Changelog

🆑
fix: Species that have longer arms than normal can now properly set
their glove offset to go low and meet their hand.
/🆑

* Fixes glove offsets not working with negative numbers

---------

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
This commit is contained in:
SkyratBot
2023-05-26 11:16:01 +01:00
committed by GitHub
co-authored by John Willard
parent 12574186ca
commit 706cd73bbf
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/mob/living/carbon/human/human_update_icons.dm
+1 -1
View File
@@ -213,7 +213,7 @@ There are several things that need to be remembered:
var/feature_y_offset = 0
for (var/obj/item/bodypart/arm/my_hand as anything in hand_bodyparts)
var/list/glove_offset = my_hand.worn_glove_offset?.get_offset()
if (glove_offset && glove_offset["y"] > feature_y_offset)
if (glove_offset && (!feature_y_offset || glove_offset["y"] > feature_y_offset))
feature_y_offset = glove_offset["y"]
gloves_overlay.pixel_y += feature_y_offset