[MIRROR] add some tests for if empty space is present [MDB IGNORE] (#15394)

* add some tests for if empty space is present (#68582)

About The Pull Request

Fixes: #62140
Fixes part of: #53689
Why It's Good For The Game

Aurora Caelus should no longer run on icebox as intended.
Station goal on stations without space shouldn't get station goals that require space.
Changelog

cl
fix: Added a test in Aurora Caelus event for if the station has the ability to show it.
fix: Stations without space should no longer receive station objectives that require space to be present.
/cl

* add some tests for if empty space is present

Co-authored-by: Mooshimi <85910816+Mooshimi@users.noreply.github.com>
This commit is contained in:
SkyratBot
2022-08-05 01:00:13 +01:00
committed by GitHub
co-authored by Mooshimi
parent 05216242f6
commit 79daec6016
4 changed files with 9 additions and 2 deletions
+5
View File
@@ -185,6 +185,11 @@
/datum/game_mode/proc/generate_station_goals(greenshift)
var/goal_budget = greenshift ? INFINITY : CONFIG_GET(number/station_goal_budget)
var/list/possible = subtypesof(/datum/station_goal)
if(!(SSmapping.empty_space))
for(var/datum/station_goal/goal in possible)
if(goal.requires_space)
///Removes all goals that require space if space is not present
possible -= goal
var/goal_weights = 0
while(possible.len && goal_weights < goal_budget)
var/datum/station_goal/picked = pick_n_take(possible)
+2 -2
View File
@@ -6,7 +6,7 @@
earliest_start = 5 MINUTES
/datum/round_event_control/aurora_caelus/canSpawnEvent(players)
if(!CONFIG_GET(flag/starlight))
if(!CONFIG_GET(flag/starlight)&&!(SSmapping.empty_space))
return FALSE
return ..()
@@ -46,7 +46,7 @@
if(seymour.mind && istype(seymour.mind.assigned_role, /datum/job/cook))
seymour.say("My roast is ruined!!!", forced = "ruined roast")
seymour.emote("scream")
/datum/round_event/aurora_caelus/tick()
if(activeFor % 5 == 0)
+1
View File
@@ -4,6 +4,7 @@
/datum/station_goal/station_shield
name = "Station Shield"
var/coverage_goal = 500
requires_space = TRUE
/datum/station_goal/station_shield/get_report()
return {"The station is located in a zone full of space debris.
@@ -5,6 +5,7 @@ GLOBAL_LIST_EMPTY_TYPED(station_goals, /datum/station_goal)
var/name = "Generic Goal"
var/weight = 1 //In case of multiple goals later.
var/required_crew = 10
var/requires_space = FALSE
var/completed = FALSE
var/report_message = "Complete this goal."