cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2025-12-11 02:01:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes crusher trophies sometimes not dropping when they should/dropping duplicates (#92721)

Browse Source 
## About The Pull Request

Changes crusher trophy drops from butchering to use guaranteed drops
instead of RNG-dependant ones

## Why It's Good For The Game

Some mobs are limited in quantity (rare variants, such as ice/magmawings
for example) and not getting a drop sucks, and getting duplicate drops
is inconsistent with how del on death mob drops work.
This commit is contained in:
SmArtKar
2025-08-26 23:51:50 +02:00
committed by GitHub
parent 29c1513ade
commit 92e77d06c6
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
code/datums/elements/crusher_loot.dm
View File

@@ -36,14 +36,15 @@
var/datum/status_effect/crusher_damage/damage = target.has_status_effect(/datum/status_effect/crusher_damage) var/datum/status_effect/crusher_damage/damage = target.has_status_effect(/datum/status_effect/crusher_damage)
if(damage && prob((damage.total_damage/target.maxHealth) * drop_mod)) //on average, you'll need to kill 4 creatures before getting the item. by default. if(damage && prob((damage.total_damage/target.maxHealth) * drop_mod)) //on average, you'll need to kill 4 creatures before getting the item. by default.
if(islist(trophy_type)) if(!islist(trophy_type))
for(var/trophypath in trophy_type) make_path(target, trophy_type)
make_path(target, trophypath)
return return
make_path(target, trophy_type)
for(var/trophypath in trophy_type)
make_path(target, trophypath)
/datum/element/crusher_loot/proc/make_path(mob/living/target, path) /datum/element/crusher_loot/proc/make_path(mob/living/target, path)
if(drop_immediately) if(drop_immediately)
new path(get_turf(target)) new path(get_turf(target))
else else
target.butcher_results[path] = 1 target.guaranteed_butcher_results[path] = 1