[MIRROR] localizes create_all_lighting_objects (#29110)

* localizes create_all_lighting_objects (#85135)

## About The Pull Request

Moves create_all_lighting_objects to the only thing that uses it - the
lighting subsystem

I saw zero difference in lighting system init time

## Why It's Good For The Game

Reduces global proc pollution and keeps everything in the same place,
improving code readability

## Changelog
🆑
refactor: moves the create_all_lighting_objects proc to the lighting
subsystem
/🆑

* localizes create_all_lighting_objects

---------

Co-authored-by: Jackriip <97582790+Jackriip@users.noreply.github.com>
This commit is contained in:
SkyratBot
2024-07-31 03:55:43 +02:00
committed by GitHub
parent 0df7ac63b4
commit 9cec18423f
3 changed files with 13 additions and 13 deletions
+13
View File
@@ -26,6 +26,19 @@ SUBSYSTEM_DEF(lighting)
return SS_INIT_SUCCESS
/datum/controller/subsystem/lighting/proc/create_all_lighting_objects()
for(var/area/area as anything in GLOB.areas)
if(!area.static_lighting)
continue
for (var/list/zlevel_turfs as anything in area.get_zlevel_turf_lists())
for(var/turf/area_turf as anything in zlevel_turfs)
if(area_turf.space_lit)
continue
new /datum/lighting_object(area_turf)
CHECK_TICK
CHECK_TICK
/datum/controller/subsystem/lighting/fire(resumed, init_tick_checks)
MC_SPLIT_TICK_INIT(3)
if(!init_tick_checks)
-12
View File
@@ -1,12 +0,0 @@
/proc/create_all_lighting_objects()
for(var/area/area as anything in GLOB.areas)
if(!area.static_lighting)
continue
for (var/list/zlevel_turfs as anything in area.get_zlevel_turf_lists())
for(var/turf/area_turf as anything in zlevel_turfs)
if(area_turf.space_lit)
continue
new /datum/lighting_object(area_turf)
CHECK_TICK
CHECK_TICK
-1
View File
@@ -4563,7 +4563,6 @@
#include "code\modules\lighting\lighting_atom.dm"
#include "code\modules\lighting\lighting_corner.dm"
#include "code\modules\lighting\lighting_object.dm"
#include "code\modules\lighting\lighting_setup.dm"
#include "code\modules\lighting\lighting_source.dm"
#include "code\modules\lighting\lighting_turf.dm"
#include "code\modules\lighting\static_lighting_area.dm"