Circuit UI scale no longer suffers from FPEs and doesnt get covered by component menu (#85653)

## About The Pull Request
Added rounding to 1 number after point to prevent FPEs and made the
scale bar shrink when component menu gets open as to prevent it from
getting covered by the menu, which made it impossible to see or increase
current scale

## Changelog
🆑
fix: Circuit UI scale no longer has weird rounding
fix: Circuit UI no longer gets covered by components menu
/🆑
This commit is contained in:
SmArtKar
2024-08-08 19:18:23 +02:00
committed by GitHub
parent 7ffd61b6fa
commit 9f45e565ec
2 changed files with 21 additions and 17 deletions
+20 -17
View File
@@ -123,6 +123,7 @@ export class InfinitePlane extends Component {
imageWidth,
initialLeft = 0,
initialTop = 0,
scalePadding,
...rest
} = this.props;
const { left, top, zoom } = this.state;
@@ -169,23 +170,25 @@ export class InfinitePlane extends Component {
{children}
</div>
<Stack position="absolute" width="100%">
<Stack.Item>
<Button icon="minus" onClick={this.handleZoomDecrease} />
</Stack.Item>
<Stack.Item grow={1}>
<ProgressBar
minValue={ZOOM_MIN_VAL}
value={zoom}
maxValue={ZOOM_MAX_VAL}
>
{zoom}x
</ProgressBar>
</Stack.Item>
<Stack.Item>
<Button icon="plus" onClick={this.handleZoomIncrease} />
</Stack.Item>
</Stack>
<div style={{ paddingRight: scalePadding }}>
<Stack width="100%">
<Stack.Item>
<Button icon="minus" onClick={this.handleZoomDecrease} />
</Stack.Item>
<Stack.Item grow={1}>
<ProgressBar
minValue={ZOOM_MIN_VAL}
value={zoom}
maxValue={ZOOM_MAX_VAL}
>
{zoom.toFixed(1)}x
</ProgressBar>
</Stack.Item>
<Stack.Item>
<Button icon="plus" onClick={this.handleZoomIncrease} />
</Stack.Item>
</Stack>
</div>
</div>
);
}
@@ -535,6 +535,7 @@ export class IntegratedCircuit extends Component {
height="100%"
backgroundImage={resolveAsset('grid_background.png')}
imageWidth={900}
scalePadding={componentMenuOpen ? '300px' : '0'}
onZoomChange={this.handleZoomChange}
onBackgroundMoved={this.handleBackgroundMoved}
initialLeft={screen_x}