[MIRROR] Fixes hitting RCD effects when they're done [MDB IGNORE] (#23311)

* Fixes hitting RCD effects when they're done (#77896)

## About The Pull Request

https://github.com/tgstation/tgstation/pull/77641 made it so that RCD
effects can be hit while they're constructing to stop their
construction. however, the construction effect itself lingers a bit
after things are done constructing, allowing it to eat up clicks. this
fixes it by removing the flag when it's done constructing.

## Why It's Good For The Game

fix good 👯 👯‍♂️ 👯‍♀️ 🎉 🏖️ 🐝

## Changelog

🆑
fix: You should no longer attack RCD effects when they're done
constructing.
/🆑

* Fixes hitting RCD effects when they're done

---------

Co-authored-by: iwishforducks <65363339+iwishforducks@users.noreply.github.com>
Co-authored-by: Pinta <68373373+softcerv@users.noreply.github.com>
This commit is contained in:
SkyratBot
2023-08-24 22:19:41 -04:00
committed by GitHub
co-authored by iwishforducks Pinta
parent d089ee7b17
commit a6d1a3a8ad
@@ -547,6 +547,8 @@
if (status == RCD_DECONSTRUCT)
qdel(src)
else
mouse_opacity = MOUSE_OPACITY_TRANSPARENT
obj_flags &= ~CAN_BE_HIT
icon_state = "rcd_end"
addtimer(CALLBACK(src, PROC_REF(end)), 15)