cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-22 12:41:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixes job changing swapping paycheck dep (#94792)

Browse Source 
## About The Pull Request

Adding job access in the HoP's console (``add_trim_access_to_card``
proc) changes the paycheck department of EVERYONE of that job, because
we assign all players via one job datum using ``SStype_occupations``
(through ``get_job_type``), so everyone's bank account stores the same
job datum as everyone else of their job.

To fix this, we are simply going to update the job of the bank account
to the new one, rather than change the paycheck department. This will
keep it in-sync with the current system while fixing the bug.

## Why It's Good For The Game

WTAF.
This commit is contained in:
John Willard
2026-01-10 12:24:12 -06:00
committed by GitHub
parent 8f4b53f552
commit b068c1e7c9
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/controllers/subsystem/networks/id_access.dm
+1 -1
View File
@@ -508,7 +508,7 @@ SUBSYSTEM_DEF(id_access)
id_card.add_wildcards(trim.wildcard_access, mode = TRY_ADD_ALL)
if(istype(trim, /datum/id_trim/job))
var/datum/id_trim/job/job_trim = trim // Here is where we update a player's paycheck department for the purposes of discounts/paychecks.
id_card.registered_account.account_job.paycheck_department = job_trim.job.paycheck_department
id_card.registered_account.account_job = job_trim.job
// Apply any currently active RETA grants to this card with updated trim access
apply_active_reta_grants_to_card(id_card)