Support stations with multiple z-levels (#35339)

* Remove ZLEVEL_STATION_PRIMARY

* Add Up and Down traits for use by ladders and chasms

* Give map_config creation its own proc

* Combine LoadConfig and ValidateJSON and remove transition_config

* Make space linkage a z-level trait

* Remove ZLEVEL_EMPTY_SPACE

* Update uses of GetFullMapPath

* Handle multi-Z stations and load Lavaland and Reebe at runtime

* Remove unused space maps

* Fix inappropriate z-expansion in map reader, improve logging

* Update comments relating to z-level configuration

* Add Lavaland and Reebe to ALL_MAPS

code/modules/mapping/map_template.dm

@@ -52,7 +52,7 @@
 	var/x = round((world.maxx - width)/2)
 	var/y = round((world.maxy - height)/2)
 
-	var/datum/space_level/level = SSmapping.add_new_zlevel(name, UNAFFECTED, list(ZTRAIT_AWAY = TRUE))
+	var/datum/space_level/level = SSmapping.add_new_zlevel(name, list(ZTRAIT_AWAY = TRUE))
 	var/list/bounds = maploader.load_map(file(mappath), x, y, level.z_value, no_changeturf=(SSatoms.initialized == INITIALIZATION_INSSATOMS), placeOnTop=TRUE)
 	if(!bounds)
 		return FALSE

code/modules/mapping/reader.dm

@@ -94,7 +94,7 @@ GLOBAL_DATUM_INIT(_preloader, /dmm_suite/preloader, new)
 			var/zcrd = text2num(dmmRegex.group[5]) + z_offset - 1
 
 			var/zexpansion = zcrd > world.maxz
-			if(zexpansion)
+			if(zexpansion && !measureOnly)
 				if(cropMap)
 					continue
 				else

code/modules/mapping/space_management/space_level.dm

@@ -1,5 +1,5 @@
 /datum/space_level
-	var/name = "Your config settings failed, you need to fix this for the datum space levels to work"
+	var/name = "NAME MISSING"
 	var/list/neigbours = list()
 	var/list/traits
 	var/z_value = 1 //actual z placement
@@ -7,8 +7,8 @@
 	var/xi
 	var/yi   //imaginary placements on the grid
 
-/datum/space_level/New(new_z, new_name, new_linkage = SELFLOOPING, list/new_traits = list())
+/datum/space_level/New(new_z, new_name, list/new_traits = list())
 	z_value = new_z
 	name = new_name
 	traits = new_traits
-	set_linkage(new_linkage)
+	set_linkage(new_traits[ZTRAIT_LINKAGE])

code/modules/mapping/space_management/space_transition.dm

@@ -1,9 +1,8 @@
 /datum/space_level/proc/set_linkage(new_linkage)
 	linkage = new_linkage
 	if(linkage == SELFLOOPING)
-		neigbours = list()
-		var/list/L = list(TEXT_NORTH,TEXT_SOUTH,TEXT_EAST,TEXT_WEST)
-		for(var/A in L)
+		neigbours = list(TEXT_NORTH,TEXT_SOUTH,TEXT_EAST,TEXT_WEST)
+		for(var/A in neigbours)
 			neigbours[A] = src
 
 /datum/space_level/proc/set_neigbours(list/L)

code/modules/mapping/space_management/traits.dm

@@ -1,15 +1,19 @@
 // Look up levels[z].traits[trait]
 /datum/controller/subsystem/mapping/proc/level_trait(z, trait)
-	if (!z)
+	if (!isnum(z) || z < 1)
 		return null
-	var/list/trait_list
 	if (z_list)
+		if (z > z_list.len)
+			stack_trace("Unmanaged z-level [z]! maxz = [world.maxz], z_list.len = [z_list.len]")
+			return list()
 		var/datum/space_level/S = get_level(z)
-		trait_list = S.traits
+		return S.traits[trait]
 	else
-		var/list/default_map_traits = DEFAULT_MAP_TRAITS
-		trait_list = default_map_traits[z][DL_TRAITS]
-	return trait_list[trait]
+		var/list/default = DEFAULT_MAP_TRAITS
+		if (z > default.len)
+			stack_trace("Unmanaged z-level [z]! maxz = [world.maxz], default.len = [default.len]")
+			return list()
+		return default[z][DL_TRAITS][trait]
 
 // Check if levels[z] has any of the specified traits
 /datum/controller/subsystem/mapping/proc/level_has_any_trait(z, list/traits)
@@ -45,6 +49,24 @@
 				. += S.z_value
 				break
 
+// Attempt to get the turf below the provided one according to Z traits
+/datum/controller/subsystem/mapping/proc/get_turf_below(turf/T)
+	if (!T)
+		return
+	var/offset = level_trait(T.z, ZTRAIT_DOWN)
+	if (!offset)
+		return
+	return locate(T.x, T.y, T.z + offset)
+
+// Attempt to get the turf above the provided one according to Z traits
+/datum/controller/subsystem/mapping/proc/get_turf_above(turf/T)
+	if (!T)
+		return
+	var/offset = level_trait(T.z, ZTRAIT_UP)
+	if (!offset)
+		return
+	return locate(T.x, T.y, T.z + offset)
+
 // Prefer not to use this one too often
 /datum/controller/subsystem/mapping/proc/get_station_center()
 	var/station_z = levels_by_trait(ZTRAIT_STATION)[1]

code/modules/mapping/space_management/zlevel_manager.dm

@@ -13,20 +13,20 @@
 
 	for (var/I in 1 to default_map_traits.len)
 		var/list/features = default_map_traits[I]
-		var/datum/space_level/S = new(I, features[DL_NAME], features[DL_LINKAGE], features[DL_TRAITS])
+		var/datum/space_level/S = new(I, features[DL_NAME], features[DL_TRAITS])
 		z_list += S
 
-/datum/controller/subsystem/mapping/proc/add_new_zlevel(name, linkage = SELFLOOPING, traits = list(), z_type = /datum/space_level)
+/datum/controller/subsystem/mapping/proc/add_new_zlevel(name, traits = list(), z_type = /datum/space_level)
 	var/new_z = z_list.len + 1
 	if (world.maxz < new_z)
 		world.incrementMaxZ()
 		CHECK_TICK
 	// TODO: sleep here if the Z level needs to be cleared
-	var/datum/space_level/S = new z_type(new_z, name, linkage, traits)
+	var/datum/space_level/S = new z_type(new_z, name, traits)
 	z_list += S
 	return S
 
 /datum/controller/subsystem/mapping/proc/get_level(z)
-	. = z_list[z]
-	if (!.)
-		CRASH("Unmanaged z-level: '[z]'")
+	if (z_list && z >= 1 && z <= z_list.len)
+		return z_list[z]
+	CRASH("Unmanaged z-level [z]! maxz = [world.maxz], z_list.len = [z_list ? z_list.len : "null"]")