Fix ling blackbox feedback incrementing changeling_power_purchase when nothing was purchased (#80480)

## About The Pull Request

#80108 added `on_purchase` calls to `regain_powers` as a bugfix, due to
some powers having effects ONLY in "purchase".

Unfortunately we put blackbox logging in there.

So every time `regain_powers` is called, it incremented the tally by one
despite the fact that they weren't purchasing anything, they were
already purchased.
This commit is contained in:
MrMelbert
2023-12-22 20:33:18 +01:00
committed by GitHub
parent d31455d6f4
commit bd424b38ab
2 changed files with 2 additions and 3 deletions
@@ -415,7 +415,8 @@
purchased_powers[power_path] = new_action
new_action.on_purchase(owner.current) // Grant() is ran in this proc, see changeling_powers.dm.
log_changeling_power("[key_name(owner)] adapted the [new_action] power")
log_changeling_power("[key_name(owner)] adapted the [new_action.name] power")
SSblackbox.record_feedback("tally", "changeling_power_purchase", 1, new_action.name)
return TRUE
@@ -40,8 +40,6 @@ the same goes for Remove(). if you override Remove(), call parent or else your p
*/
/datum/action/changeling/proc/on_purchase(mob/user, is_respec)
if(!is_respec)
SSblackbox.record_feedback("tally", "changeling_power_purchase", 1, name)
Grant(user)//how powers are added rather than the checks in mob.dm
/datum/action/changeling/Trigger(trigger_flags)