cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-29 08:08:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Fixes an oversight allowing players to list ckeys and the names of the mobs they're controlling under certain conditions (#2158)

Browse Source 
* Fixes an oversight allowing players to list ckeys and the names of the mobs they're controlling under certain conditions (#55332)

About The Pull Request

• Resolves a probably unknown oversight allowing players to find out who plays who by using the ignore verb, which if the user is a ghost, will list the names of people's mobs alongside their ckey if they are also a ghost.
Why It's Good For The Game

Removes a potential method of metagrudging and addresses a privacy concern for those who wish to play anonymous characters. Yes, you can still see this stuff in the round-end report.
We don't lose anything here. If we're using this verb, we're doing it because we want to ignore someone's OOC messages. We don't need this additional information. I feel like this is just an oversight.
Changelog

🆑
fix: Players can no longer us the ignore verb to gather a list of people's characters and ckeys together.
/🆑

* Fixes an oversight allowing players to list ckeys and the names of the mobs they're controlling under certain conditions

Co-authored-by: KathrinBailey <53862927+KathrinBailey@users.noreply.github.com>
This commit is contained in:
SkyratBot
2020-12-13 13:44:20 +00:00
committed by GitHub
co-authored by KathrinBailey
parent 844e0482f2
commit c0bdfaf777
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/client/verbs/ooc.dm
+2 -2
View File
@@ -250,9 +250,9 @@ GLOBAL_VAR_INIT(normal_ooc_colour, "#002eb8")
// Check if both we and the player are ghosts and they're not using a fakekey
if(isobserver(mob) && isobserver(C.mob) && !C.holder?.fakekey)
// Show us the player's mob name in the list in front of their displayed key
// Show us if the player is a ghost or not after their displayed key
// Add the player's displayed key to the list
players["[C.mob]([displayed_key])"] = displayed_key
players["[displayed_key](ghost)"] = displayed_key
// Add the player's displayed key to the list if we or the player aren't a ghost or they're using a fakekey
else