mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-30 00:29:02 +01:00
Clicking sub sections in lathes will auto scroll to them (#81933)
## About The Pull Request - Fixes #80931 To answer the question > Would be valid to see if it's actually getting the element. if it is, perhaps the issue is with section I guess the problem is with the section because `getElementByID()` requires the `div` element of the section to actually have an `id` which we can retrive & scroll to. I don't like the solution entirely as `key` & `id` are redundant and if there was a way to access the `key` or some other way to access the section without using `getElementByID()` I'm all up for it. ## Changelog 🆑 fix: Clicking sub sections in the design menu of lathe's UIs will auto scroll to them. /🆑
This commit is contained in:
@@ -23,6 +23,8 @@ type Props = Partial<{
|
||||
scrollableHorizontal: boolean;
|
||||
/** Title of the section. */
|
||||
title: ReactNode;
|
||||
/** id to assosiate with the parent div element used by this section, for uses with procs like getElementByID */
|
||||
container_id: string;
|
||||
/** @member Callback function for the `scroll` event */
|
||||
onScroll: ((this: GlobalEventHandlers, ev: Event) => any) | null;
|
||||
}> &
|
||||
@@ -67,6 +69,7 @@ export const Section = forwardRef(
|
||||
scrollable,
|
||||
scrollableHorizontal,
|
||||
title,
|
||||
container_id,
|
||||
...rest
|
||||
} = props;
|
||||
|
||||
@@ -87,6 +90,7 @@ export const Section = forwardRef(
|
||||
|
||||
return (
|
||||
<div
|
||||
id={container_id || ''}
|
||||
className={classes([
|
||||
'Section',
|
||||
fill && 'Section--fill',
|
||||
|
||||
@@ -492,6 +492,7 @@ const CategoryView = <T extends Design = Design>(
|
||||
<Section
|
||||
title={category.title}
|
||||
key={category.anchorKey}
|
||||
container_id={category.anchorKey}
|
||||
buttons={categoryButtons && categoryButtons(category)}
|
||||
>
|
||||
{body}
|
||||
|
||||
Reference in New Issue
Block a user