cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-23 21:18:37 +01:00
Code Issues Packages Projects Releases Wiki Activity

Status effect process has SHOULD NOT OVERRIDE (#71594)

Browse Source 
## About The Pull Request

Adds `SHOULD_NOT_OVERRIDE` to status effect process.

Nothing currently does it but another PR attempted it which is
incorrect.

## Why It's Good For The Game

Status effect subtypes shouldn't extend or override process. They can be
`qdel`ed at the end, and not everything will handle it properly.

Adding processed effects should be done in `tick`, with a set
`tick_interval`.

## Changelog
 
Not necessary
This commit is contained in:
MrMelbert
2022-11-29 15:11:13 -08:00
committed by GitHub
parent 8abe57b430
commit cffce8de2c
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/datums/status_effects/_status_effect.dm
+3 -2
View File
@@ -78,10 +78,11 @@
owner = null
return ..()
// Status effect process. Handles adjusting it's duration and ticks.
// Status effect process. Handles adjusting its duration and ticks.
// If you're adding processed effects, put them in [proc/tick]
// instead of extending / overriding ththe process() proc.
// instead of extending / overriding the process() proc.
/datum/status_effect/process(delta_time, times_fired)
SHOULD_NOT_OVERRIDE(TRUE)
if(QDELETED(owner))
qdel(src)
return