Merge pull request #12795 from KorPhaeron/jobbans

Attempting to convert a jobbaned player offers control of their mob to ghosts

code/game/gamemodes/cult/cult.dm

@@ -187,6 +187,8 @@
 		cult_mind.current.cult_add_comm()
 		update_cult_icons_added(cult_mind)
 		cult_mind.current.attack_log += "\[[time_stamp()]\] <span class='danger'>Has been converted to the cult!</span>"
+		if(jobban_isbanned(cult_mind.current, "Cultist"))
+			replace_jobbaned_player(cult_mind.current, "Cultist")
 		return 1
 
 

code/game/gamemodes/game_mode.dm

@@ -518,6 +518,16 @@
 
 	return max(0, enemy_minimum_age - C.player_age)
 
+/datum/game_mode/proc/replace_jobbaned_player(mob/living/M, role_type, pref)
+	var/list/mob/dead/observer/candidates = pollCandidates("Do you want to play as a [role_type]?", "[role_type]", null, pref, 100)
+	var/mob/dead/observer/theghost = null
+	if(candidates.len)
+		theghost = pick(candidates)
+		M << "Your mob has been taken over by a ghost! Appeal your job ban if you want to avoid this in the future!"
+		message_admins("[key_name_admin(theghost)] has taken control of ([key_name_admin(M)]) to replace a jobbaned player.")
+		M.ghostize()
+		M.key = theghost.key
+
 /datum/game_mode/proc/remove_antag_for_borging(datum/mind/newborgie)
 	ticker.mode.remove_cultist(newborgie, 0)
 	ticker.mode.remove_revolutionary(newborgie, 0)

code/game/gamemodes/gang/gang.dm

@@ -184,6 +184,8 @@ var/list/gang_colors_pool = list("red","orange","yellow","green","blue","purple"
 	gangster_mind.current.attack_log += "\[[time_stamp()]\] <font color='red'>Has been converted to the [G.name] Gang!</font>"
 	gangster_mind.special_role = "[G.name] Gangster"
 	G.add_gang_hud(gangster_mind)
+	if(jobban_isbanned(gangster_mind.current, "Gangster"))
+		replace_jobbaned_player(gangster_mind.current, "Gangster")
 	return 2
 ////////////////////////////////////////////////////////////////////
 //Deals with players reverting to neutral (Not a gangster anymore)//

code/game/gamemodes/revolution/revolution.dm

@@ -249,6 +249,8 @@
 	rev_mind.current.attack_log += "\[[time_stamp()]\] <font color='red'>Has been converted to the revolution!</font>"
 	rev_mind.special_role = "Revolutionary"
 	update_rev_icons_added(rev_mind)
+	if(jobban_isbanned(rev_mind.current, "Revolutionary"))
+		replace_jobbaned_player(rev_mind.current, "Revolutionary")
 	return 1
 //////////////////////////////////////////////////////////////////////////////
 //Deals with players being converted from the revolution (Not a rev anymore)//  // Modified to handle borged MMIs.  Accepts another var if the target is being borged at the time  -- Polymorph.

html/changelogs/Kor-Jobban.yml

@@ -0,0 +1,36 @@
+################################
+# Example Changelog File
+#
+# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb.
+#
+# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.)
+# When it is, any changes listed below will disappear.
+#
+# Valid Prefixes: 
+#   bugfix
+#   wip (For works in progress)
+#   tweak
+#   soundadd
+#   sounddel
+#   rscadd (general adding of nice things)
+#   rscdel (general deleting of nice things)
+#   imageadd
+#   imagedel
+#   spellcheck (typo fixes)
+#   experiment
+#   tgs (TG-ported fixes?)
+#################################
+
+# Your name.  
+author: Kor
+
+# Optional: Remove this file after generating master changelog.  Useful for PR changelogs that won't get used again.
+delete-after: True
+
+# Any changes you've made.  See valid prefix list above.
+# INDENT WITH TWO SPACES.  NOT TABS.  SPACES.
+# SCREW THIS UP AND IT WON'T WORK.
+# Also, this gets changed to [] after reading.  Just remove the brackets when you add new shit.
+# Please surround your changes in  double quotes ("). It works without them, but if you use certain characters it screws up compiling. The quotes will not show up in the changelog.
+changes: 
+  - rscadd: "Converting (to cultist, rev, or gangster) a jobbaned player will now automatically offer control of their character to ghosts."