cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-28 23:58:07 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Fixes an issue with strip menus making duplicate windows (#26944)

Browse Source 
* Fixes an issue with strip menus making duplicate windows (#82055)

## About The Pull Request
Fixes an oversight in #57889, where the strip_menus list is set, but
never accessed, leading to whenever you drag to open the menu, it always
opens a new window.

## Why It's Good For The Game
Noticed this while porting the TGUI strip menu, and I figured I should
fix it here too. From the design of the strippable element, it seems
that this was the original design, but somehow got lost along the way.

## Changelog
🆑
Fix: Opening a mob's strip menu multiple times will now properly update
the window.
/🆑

* Fixes an issue with strip menus making duplicate windows

---------

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
This commit is contained in:
SkyratBot
2024-03-20 06:29:32 -04:00
committed by GitHub
co-authored by Contrabang
parent 68819bd092
commit dbec66f02a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/datums/elements/strippable.dm
+1 -1
View File
@@ -51,7 +51,7 @@
if (!isnull(should_strip_proc_path) && !call(source, should_strip_proc_path)(user))
return
var/datum/strip_menu/strip_menu
var/datum/strip_menu/strip_menu = LAZYACCESS(strip_menus, source)
if (isnull(strip_menu))
strip_menu = new(source, src)